Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placeholder component throws if placeholder key is missing #13

Closed
kamsar opened this issue Oct 15, 2019 · 0 comments
Labels
bug

Comments

@kamsar
Copy link

@kamsar kamsar commented Oct 15, 2019

Reproduction:

  • Take a <Placeholder>
  • Mangle the name to some unknown key like 0xDEADBEEF
Cannot read property 'map' of undefined
TypeError: Cannot read property 'map' of undefined

Because in:

const getComponentsForRenderingData = (placeholderData) => {
    let components = placeholderData.map((rendering, index) => {
      let component = getComponentForRendering(rendering);
      renderingComponents.push(component);
    });
  };

the placeholderData is undefined when the key is invalid

@erzr erzr added the bug label Oct 20, 2019
@erzr erzr closed this Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.