fix: fix unsafe property access#21
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
A concise fix to improve safety when accessing properties in getJSDocComment by using optional chaining.
- Changed unsafe property access of prevSibling.declaration.type to use optional chaining.
- Ensured consistency in safely accessing properties for TSDeclareFunction checks.
Contributor
|
Thanks! Can I ask though--do you happen to know what the triggering code was? |
Contributor
|
Also, looks like I needed to bump |
BREAKING CHANGE: Requires Node >= 20.11.0
Contributor
|
Released as part of v0.52.0 ... I'll look to add to |
Contributor
Author
|
The error happens while linting this line of code
|
Contributor
|
Ah, thanks! So there is such a thing as a declaration without a declaration--go figure! :-)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue occurs while accessing an unsafe property.
Issue reproduction:
https://github.com/ntnyq/eslint-plugin-ntnyq/actions/runs/15802108983/job/44541751654?pr=126