Take on String..split fixing #103

Open
kriskowal opened this Issue Mar 13, 2012 · 4 comments

Projects

None yet

3 participants

@kriskowal
ECMAScript Shims member

via @slevithan, we could fix String..split for regexen, bringing errant engines up to spec.

http://blog.stevenlevithan.com/archives/cross-browser-split

@Yaffle

other solution - https://gist.github.com/2049878 (license free)

split is very powerful function with regexp, so fixing it will be good

but this solution may performs much slower, than native ...

@ljharb ljharb pushed a commit to ljharb/es5-shim that referenced this issue Dec 11, 2013
@fidian fidian Adding Steven Levithan's String.prototype.split for RegExp
I asked and received his blessing:

Tyler, thanks for offering to take this up! I’d be more than happy to see my code for this shared more broadly, and/or improved. My split shim and tests are MIT licensed, like es5-shim. By the way, Kris (author of es5-shim) brought this up before, but no one has done the work to see this through, like you’ve offered to do. See es-shims#103

 /Steven
00a8838
@ljharb
ECMAScript Shims member

Closed by #165.

@ljharb ljharb closed this Dec 23, 2013
@ljharb
ECMAScript Shims member

This is failing some tests in OmniWeb v5.11.2, which makes me concerned it's failing in other ES3 browsers. @slevithan etc, do you have any thoughts here?

@ljharb ljharb reopened this Mar 23, 2015
@ljharb
ECMAScript Shims member

These tests also fail in Opera 10.6, and Firefox 4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment