New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ERR_NON_OBJECT_DESCRIPTOR thrown wrong #19

Closed

Raynos opened this issue Jun 11, 2011 · 1 comment

Contributor

Raynos commented Jun 11, 2011

if (typeof object !== "object" || object === null)
throw new TypeError(ERR_NON_OBJECT_DESCRIPTOR + descriptor);

should be

if (typeof descriptor !== "object" || descriptor === null)
throw new TypeError(ERR_NON_OBJECT_DESCRIPTOR + descriptor);

See https://github.com/kriskowal/es5-shim/blob/master/es5-shim.js#L495

Contributor Author

Raynos commented Jun 11, 2011

See issue #20

Raynos closed this as completed

kriskowal added a commit that referenced this issue


          Merge pull request #20 from Raynos/patch-1

7d4aecd

Fixed issue #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment