New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE8 defineProperty/getOwnPropertyDescriptor clash with shim #5

Closed
allenwb opened this Issue Feb 8, 2011 · 3 comments

Comments

Projects
None yet
4 participants
@allenwb

allenwb commented Feb 8, 2011

As currently implemented, the Object.defineProperty shim will not install on IE8 because IE8 already has such a method. However, the built-in IE8 method only works when applied to DOM objects.

Because the shim does not get installed, the emulation of value: property descriptors on arbitrary objects is not available although it could be. (get: and set: descriptors are a lost cause). The shim installation needs better detection of IE8 (see http://blogs.msdn.com/b/ie/archive/2010/09/07/transitioning-existing-code-to-the-es5-getter-setter-apis.aspx) and should probably and the installed shim should first call the built-in method and then only call the the emulation if the built-in throws).

IE8 also has a DOM only getOwnPropertyDescriptor so the same issues apply to it.

hax added a commit to hax/es5-shim that referenced this issue Jul 18, 2011

@edmellum

This comment has been minimized.

Show comment
Hide comment
@edmellum

edmellum Sep 11, 2011

I think I'm having problems because of this. IE8 gives me this error: Object doesn't support this action on line 532. Has this been merged in yet?

I think I'm having problems because of this. IE8 gives me this error: Object doesn't support this action on line 532. Has this been merged in yet?

@bbqsrc

This comment has been minimized.

Show comment
Hide comment
@bbqsrc

bbqsrc Sep 19, 2011

Contributor

Doesn't look like it was merged, sadly.

Contributor

bbqsrc commented Sep 19, 2011

Doesn't look like it was merged, sadly.

kriskowal added a commit that referenced this issue Sep 19, 2011

@kriskowal

This comment has been minimized.

Show comment
Hide comment
@kriskowal

kriskowal Sep 22, 2011

Member

This needs a retry if anyone is up for it.

Member

kriskowal commented Sep 22, 2011

This needs a retry if anyone is up for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment