Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of implicit DAI handling #29

Closed
wants to merge 1 commit into from
Closed

Get rid of implicit DAI handling #29

wants to merge 1 commit into from

Conversation

davesque
Copy link
Collaborator

Add explicit elif statement in the manner of other checks in the same module.

@davesque davesque mentioned this pull request Jul 10, 2019
Merged
@davesque
Copy link
Collaborator Author

This PR may conflict with #28 and #30 .

@davesque davesque mentioned this pull request Jul 10, 2019
Merged
@pedrouid
Copy link
Contributor

This PR should be replaced with #26 because the way DAI payments where checked are incorrect. It's using xDAI instead of Ethereum Mainnet DAI token. We have refactored it as part of our integration on PR #26, please check txn_check.py

@davesque
Copy link
Collaborator Author

Superseded by changes in #32 .

@davesque davesque closed this Jul 11, 2019
@davesque davesque deleted the explicit-elif branch July 12, 2019 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davesque @pedrouid