/android-image-picker

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Glide v4? #68

Closed
Rainer-Lang opened this Issue Aug 22, 2017 · 5 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Rainer-Lang @esafirm @ks419
@Rainer-Lang
Contributor

Rainer-Lang commented Aug 22, 2017

No description provided.

@esafirm

This comment has been minimized.

Sign in to view
Owner

esafirm commented Aug 29, 2017

Can you tell me a brief pros n cons? Or just a link 😄
@Rainer-Lang

This comment has been minimized.

Sign in to view
Contributor

Rainer-Lang commented Aug 29, 2017 •
edited

I would suggest to read the release changelog: https://github.com/bumptech/glide/releases
And at my point - the changes a dev has to make in code are very small.

UPDATE: Migrating from v3 to v4 https://bumptech.github.io/glide/doc/migrating.html
@esafirm

This comment has been minimized.

Sign in to view
Owner

esafirm commented Sep 2, 2017

@Rainer-Lang will check on it ASAP 😄 👍
@ks419

This comment has been minimized.

Sign in to view

ks419 commented Sep 10, 2017

Please do it asap. Adding glide externally breaks compatibility.

esafirm added a commit that referenced this issue Sep 11, 2017

@esafirm
✨ Update Glide to v4 
#68
d596980
@esafirm

This comment has been minimized.

Sign in to view
Owner

esafirm commented Sep 11, 2017

@Rainer-Lang @ks419 updated and release in 1.9.0 🎉
Please kindly check 🙏

@esafirm esafirm closed this Sep 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment