Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`_.reverse` is buggy #220

Open
mathiasbynens opened this issue Jul 10, 2013 · 2 comments
Open

`_.reverse` is buggy #220

mathiasbynens opened this issue Jul 10, 2013 · 2 comments
Labels

Comments

@mathiasbynens
Copy link

@mathiasbynens mathiasbynens commented Jul 10, 2013

For example:

// To see which symbols are being used here, check:
// http://mothereff.in/js-escapes#1ma%C3%B1ana%20man%CC%83ana
naiveReverse('mañana mañana');
// → 'anãnam anañam'
// Wait, so now the tilde is applied to the `a` instead of the `n`? WAT.

Another issue is explained here: http://stackoverflow.com/a/16776380/96656 (Posting a link because GitHub won’t let me use the symbols in a comment.)

You could use Esrever for this. Something like:

_.reverse = require('esrever').reverse;
@terinjokes
Copy link

@terinjokes terinjokes commented Oct 21, 2013

I'm pulling in the, uhm, "Missy Elliot algorithm" replacing the current _str.reverse and also added the Pile of Poo test. Waiting for phantomjs to install to run the unit tests.

terinjokes added a commit to terinjokes/underscore.string that referenced this issue Oct 21, 2013
@mathiasbynens
Copy link
Author

@mathiasbynens mathiasbynens commented Oct 21, 2013

Awesome! Nice work, @terinjokes! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.