Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Regex and Logcat tag chg feb/mar 2020 #11
…ld 32150 Regex change to match the CalcyIV logcat output changed in v.3.21 build 32150. Around 07feb2020. (Old change, just add it here if anybody stays on an old version, and for the history)
…3a build 32355. Logcat tag change from i to j. Logcat tag change to match the CalcyIV logcat output changed in v.3.23a build 32355. Sometime in the beginning of March 2020. Logcat tag change from i to j.
Logcat tag change in the CalcyIV logcat output in v.3.23a build 32355. Have to chg the regex to match the j . Nothing else change in the regex, as far as I can see (since the big change in v.3.21 build 32150) Sometime in the beginning of March 2020. Logcat tag change from i to j.
esauvisky left a comment
Amazing, thank you. Good PR as well, particularly for a beginner. Easily beats most of my owns
Just a nomenclature tip: PR or MR (Pull/Merge request) is the whole history of commits to be merged. The dummy thing you mentioned is a commit (6548356). If you're the OCD type and want to make a very clear history of commits when sending PRs (good practice), research for squashing commits, particularly using interactive rebasing (git rebase -i)!