Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex and Logcat tag chg feb/mar 2020 #11

Merged
merged 4 commits into from Mar 10, 2020
Merged

Conversation

@J-G-Froejk
Copy link

J-G-Froejk commented Mar 10, 2020

Let's get up to par with the latest public version of CalcyIV - v.3.21 build 32150 .

Merge pull request #10 from J-G-Froejk/master
@J-G-Froejk

This comment has been minimized.

Copy link
Owner Author

J-G-Froejk commented on 6548356 Mar 10, 2020

This PR is a dummy. Just want to be sure my fork got all the change from Esauvisky version, so I do not make updates on old code.
I am still a novice in GitHub :-O

J-G-Froejk added 3 commits Mar 10, 2020
…ld 32150

Regex change to match the CalcyIV logcat output changed in v.3.21 build 32150.
Around 07feb2020.
(Old change, just add it here if anybody stays on an old version, and for the history)
…3a build 32355. Logcat tag change from i to j.

Logcat tag change to match the CalcyIV logcat output changed in v.3.23a build 32355. 
Sometime in the beginning of March 2020.
Logcat tag change from i to j.
Logcat tag change in the CalcyIV logcat output in v.3.23a build 32355. 
Have to chg the regex to match the j .  Nothing else change in the regex, as far as I can see (since the big change in v.3.21 build 32150)
Sometime in the beginning of March 2020.
Logcat tag change from i to j.
Copy link
Owner

esauvisky left a comment

Amazing, thank you. Good PR as well, particularly for a beginner. Easily beats most of my owns 🤣

Just a nomenclature tip: PR or MR (Pull/Merge request) is the whole history of commits to be merged. The dummy thing you mentioned is a commit (6548356). If you're the OCD type and want to make a very clear history of commits when sending PRs (good practice), research for squashing commits, particularly using interactive rebasing (git rebase -i)!

@@ -80,7 +80,7 @@ def __init__(self):
#logger.debug("Running pidof calcy got code %d: %s", return_code, stdout)
#self.calcy_pid = stdout.decode('utf-8').strip()
# cmd = ["adb", "-s", await self.get_device(), "logcat", "-T", "1", "-v", "brief", "--pid", self.calcy_pid]
cmd = ["adb", "-s", await self.get_device(), "logcat", "-T", "1", "-v", "brief" , "MainService:D i:D ClipboardReceiver:D *:S"]
cmd = ["adb", "-s", await self.get_device(), "logcat", "-T", "1", "-v", "brief" , "MainService:D j:D ClipboardReceiver:D *:S"]

This comment has been minimized.

Copy link
@esauvisky

esauvisky Mar 10, 2020

Owner

Any idea what does this character in particular mean?

This comment has been minimized.

Copy link
@J-G-Froejk

J-G-Froejk Mar 10, 2020

Author

It is just a Tag aka a provider identification.
They should make it longer and more describing. I thing it was Calcy in the beginning.
They like hope nobody else in the very big Android dev community, will use the one letter j :-O

@esauvisky esauvisky merged commit 1ae83ad into esauvisky:master Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.