Change the android app styles #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
March 27, 2017 22:57
So this branch is now dependent to the bugfix-android-app-index branch, that is actually a pull request in the original repository. #19
|
For multiline inputs the alignment should not be centered. Will add this soon (this evening/night) |
|
There are some conflicts here. Can you resolve those and then I will review again? :-) |
|
Ok conflicts has been resolved :) |
|
What is the word on this? I'm having issues with the forms displaying on Android as well. Would love to have this fix merged in. |
|
I guess Esben is on it. He already wrote me that he is busy at the moment. Stay tuned, it will not take so much time anymore ;) |
|
Sorry for being pushy I didn't look at how recent this PR was before I commented. Your response time is more than satisfactory. Thanks for all the hard work @esbenp and @markusguenther 😄 |
|
No problem ... your welcome :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The style of the android app is not optimal. The most text components are not centered vertically
and the input text changes the height depending on the inlineLabel property.
This commit does not remove the input lines because this is a component property of
text-input in react native and can be changed in the general behavior.
But to change this you also need the pull request 15.
#15
Fixes: #9