New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

war artefacts produced by 'escalante-lift-war' missing 'WEB-INF/lib' directory #12

Closed
arashi01 opened this Issue Mar 17, 2013 · 4 comments

Comments

Projects
None yet
2 participants
@arashi01
Contributor

arashi01 commented Mar 17, 2013

war files missing runtime dependency jars in 'WEB-INF/lib'.

See sbt-escalante-deps-issue for an example project.

arashi01 added a commit to arashi01/sbt-escalante-deps-issue that referenced this issue Mar 17, 2013

@galderz

This comment has been minimized.

Show comment
Hide comment
@galderz

galderz Mar 18, 2013

Contributor

Thanks Ali! I'll handle it in the next day or so :)

Contributor

galderz commented Mar 18, 2013

Thanks Ali! I'll handle it in the next day or so :)

@galderz

This comment has been minimized.

Show comment
Hide comment
@galderz

galderz Mar 19, 2013

Contributor

Ali, the fix looks good, but the copy-dependencies might need to filter some other libraries out. I need to double check this. Also, I wanna add a scripted SBT test to make sure this works as expected. I'll fork your fix in the next few days and will get back to you when it's done.

Contributor

galderz commented Mar 19, 2013

Ali, the fix looks good, but the copy-dependencies might need to filter some other libraries out. I need to double check this. Also, I wanna add a scripted SBT test to make sure this works as expected. I'll fork your fix in the next few days and will get back to you when it's done.

@galderz

This comment has been minimized.

Show comment
Hide comment
@galderz

galderz Mar 20, 2013

Contributor

I've got a patch to add a test and improve coverage of jars to not be included in WEB-INF/lib, I'll push it later today and I'll release 0.1.2.

Contributor

galderz commented Mar 20, 2013

I've got a patch to add a test and improve coverage of jars to not be included in WEB-INF/lib, I'll push it later today and I'll release 0.1.2.

@galderz

This comment has been minimized.

Show comment
Hide comment
@galderz

galderz Mar 20, 2013

Contributor

This is now integrated and version 0.1.2 of the plugin has been released.

Contributor

galderz commented Mar 20, 2013

This is now integrated and version 0.1.2 of the plugin has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment