Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: accept duration in seconds as option #1

Merged
merged 3 commits into from Mar 10, 2020

Conversation

@gbrlsnchs
Copy link
Contributor

gbrlsnchs commented Mar 10, 2020

No description provided.

@gbrlsnchs gbrlsnchs force-pushed the gbrlsnchs:feature-expiration branch from a8b2b5d to 778fd34 Mar 10, 2020
@gbrlsnchs gbrlsnchs changed the title feat: accept expiration in seconds as option feat: accept duration in seconds as option Mar 10, 2020
src/server.js Outdated Show resolved Hide resolved
@gbrlsnchs gbrlsnchs force-pushed the gbrlsnchs:feature-expiration branch from 2c0a008 to 81ef881 Mar 10, 2020
@gbrlsnchs

This comment has been minimized.

Copy link
Contributor Author

gbrlsnchs commented Mar 10, 2020

@rdumont 81ef881 handles setting a max duration, which defaults to the defaultExpiration.

@gbrlsnchs gbrlsnchs force-pushed the gbrlsnchs:feature-expiration branch from 81ef881 to 15360c4 Mar 10, 2020
@gbrlsnchs gbrlsnchs force-pushed the gbrlsnchs:feature-expiration branch from 15360c4 to 1130974 Mar 10, 2020
@rdumont rdumont merged commit 294253e into escaletech:master Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.