New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt out code added #14 #20

Open
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@rluetke
Copy link

rluetke commented Dec 11, 2018

Hi John,

I added an optOut-function according to General Data Protection Regulation in Europe and https://developers.google.com/analytics/devguides/collection/gajs/#disable.
But I did not add changes to blueprint / admin panel!
It works fine on my website https://blog.dmr-solutions.com/.

Regards, Ralf

@escopecz

This comment has been minimized.

Copy link
Owner

escopecz commented Dec 12, 2018

Looks good! I'll have to find some time to test it, but if someone else would have a minute to do that please write your test results in a comment and I'll merge it if successful.

@rluetke

This comment has been minimized.

Copy link
Author

rluetke commented Dec 12, 2018

Hi John,

meanwhile I commited the readme again with more details about using opt out.

And I did the following tests with my site https://blog.dmr-solutions.com/

  • check JavaScript-Code in HTML source with and without "opt out" enabled: OK
  • open Google Analytics realtime report for this site
  • clicked some pages and check if this is listed in Google Analytics: OK
  • list cookies and look for "ga-disable-UA-9493622-1" (with my tracking ID): not found = OK
  • click on the opt-out-link: opt out message is shown = OK
  • list cookies and look for "ga-disable-UA-9493622-1": found and is "true" = OK
  • clicked some pages and check if this is listed in Google Analytics: not listed = OK
  • delete cookie "ga-disable-UA-9493622-1"
  • clicked some pages and check if this is listed in Google Analytics: OK

The opt out cookie is set and Google Analytics stopps tracking.
This worked as designed, but is only tested by me, the developer :-;

So, perhaps someone else may repeat the tests.

Regards, Ralf

@rluetke

This comment has been minimized.

Copy link
Author

rluetke commented Dec 12, 2018

Hi John,

but you still have to add the two new parameters in blueprints.yaml and language files and test it in admin plugin.

Regards, Ralf

@escopecz

This comment has been minimized.

Copy link
Owner

escopecz commented Dec 13, 2018

@rluetke could you make all changes necessary for this feature, please?

@rluetke

This comment has been minimized.

Copy link
Author

rluetke commented Dec 28, 2018

Hi John,

it took a while but now all changes for this feature are pushed to the repo. "Tracking Opt Out" can be configured in admin panel, too.

You could insert in the change.log e.g.:

  • new: Google Analytics Out Out
  • improved: spanish added for Admin Panel

I did not make any changes in the change.log, only in the read.me.

Regards and happy new year, Ralf

@rluetke

This comment has been minimized.

Copy link
Author

rluetke commented Dec 31, 2018

Hi John,

I moved the "opt out" parameters in the admin panel under an own tab and added some explanations there. I hope this makes "opt out" a bit clearer.

Regards, Ralf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment