previous / next buttons now navigate across QSections #160

Merged
merged 1 commit into from Apr 25, 2012

Conversation

Projects
None yet
2 participants
@bartvandendriessche
Contributor

bartvandendriessche commented Apr 25, 2012

I modified the findNext|PreviousElementToFocusOn methods to take different QSections into account.

@bartvandendriessche

This comment has been minimized.

Show comment
Hide comment
@bartvandendriessche

bartvandendriessche Apr 25, 2012

Contributor

I noticed the state of the next/previous buttons is not always consistent with what happens when you touch them. (This occurs even before my patch)

Particularly, if you have QRoot, with several QElements, when the last QElement is a QMultiLineElement, the next button will appear enabled, but touching it will not jump to the QMultiLineElement.

I'm looking into how to tweak this behaviour a bit.

Contributor

bartvandendriessche commented Apr 25, 2012

I noticed the state of the next/previous buttons is not always consistent with what happens when you touch them. (This occurs even before my patch)

Particularly, if you have QRoot, with several QElements, when the last QElement is a QMultiLineElement, the next button will appear enabled, but touching it will not jump to the QMultiLineElement.

I'm looking into how to tweak this behaviour a bit.

escoz added a commit that referenced this pull request Apr 25, 2012

Merge pull request #160 from bartvandendriessche/next_previous_should…
…_jump_across_sections

previous / next buttons now navigate across QSections

@escoz escoz merged commit 805ef2a into escoz:master Apr 25, 2012

@escoz

This comment has been minimized.

Show comment
Hide comment
@escoz

escoz Apr 25, 2012

Owner

Awesome, thanks for helping!

Owner

escoz commented Apr 25, 2012

Awesome, thanks for helping!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment