New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash when using x[Symbol.toStringTag] = ... #297
Comments
Aye, we hit this today as well. @JoelEinbinder |
Hi folks... So the reason for ESDoc failing here is that it is only assuming
I have a separate fork of ESDoc that supports Babylon as the parser and I have made a patch that fixes this problem, but I want to get your guys feedback before submitting a PR to ESDoc. I also added support for It should be noted that currently ESDoc (or my fork) doesn't parse adding methods to the prototype of a class. IE I'd like to receive some comments on this as a potential enhancement such that when adding methods to a class prototype should they be picked up in the class documentation as a class method. It requires a bit more effort to support this with ESDoc, but should be possible. For now though could you guys take a look and give a quick test with: It's not published on NPM so you have to include it directly from GitHub ala:
A secondary option if you have full control of the source code and want to see
|
@ddude Thanks for report this bug. I fixed it on current master. I will publish new version at shortly. |
You might also handle the literal case:
Without supporting the Literal ESTree AST Node here this will crash: |
I fixed this issue in e59820a |
Hello,
I get a crash when using the following:
However, this works fine:
I just tried with the d0e0934 version of esdoc and it still crashes, here is the stack trace:
The text was updated successfully, but these errors were encountered: