Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this[property] gets recognized as class member in ESDoc. #59

Closed
Rukenshia opened this issue Aug 29, 2015 · 3 comments
Closed

this[property] gets recognized as class member in ESDoc. #59

Rukenshia opened this issue Aug 29, 2015 · 3 comments

Comments

@Rukenshia
Copy link

@Rukenshia Rukenshia commented Aug 29, 2015

I sometimes manipulate properties of my class via this[property] = value. This however generates a public member 'property' in my ESDoc generated document:

class Foo {
  /**
   * Creates a new instance of Foo
   *
   * @constructor
   */
  constructor() {
    /** @type {string} */
    this.foo = 'bar';
  }

  /**
   * Set the given property in the class.
   *
   * @param {string} property property to set
   * @param {*} value new value
   */
  manipulate(property, value) {
    this[property] = value;
  }
}

Result

@h13i32maru
Copy link
Member

@h13i32maru h13i32maru commented Aug 30, 2015

@Rukenshia Thanks for this issue!
This is ESDoc bug. Please wait a little for fixing it.

@h13i32maru
Copy link
Member

@h13i32maru h13i32maru commented Aug 30, 2015

I published ESDoc v0.2.4. Please try to use it 😄

@h13i32maru h13i32maru closed this Aug 30, 2015
@Rukenshia
Copy link
Author

@Rukenshia Rukenshia commented Aug 30, 2015

Works fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.