New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposed more variables to ESParser related plugin callbacks. #263

Merged
merged 1 commit into from Jun 11, 2016

Conversation

Projects
None yet
2 participants
@typhonrt
Contributor

typhonrt commented Apr 9, 2016

@h13i32maru Please review this PR as it exposes all data available in ESParser to parsing related plugin callbacks. It is rather handy to have the file path (filePath) for instance in onHandleCode and onHandleAST for the source code being processed.

Please let me know if any changes need to be made and I'll update the PR. I have a really significant ESDoc plugin for interactive visualization of source code that is blocked without more plugin data for AST processing.

Exposed more variables to ESParser related plugin callbacks. This ext…
…ra data is very useful in handling code and AST parsing.

@h13i32maru h13i32maru merged commit 4fea0f3 into esdoc:master Jun 11, 2016

@h13i32maru

This comment has been minimized.

Show comment
Hide comment
@h13i32maru

h13i32maru Jun 11, 2016

Member

@typhonrt Sorry for late reply 🙇
Thanks for this PR! I merged it!

Member

h13i32maru commented Jun 11, 2016

@typhonrt Sorry for late reply 🙇
Thanks for this PR! I merged it!

@typhonrt

This comment has been minimized.

Show comment
Hide comment
@typhonrt

typhonrt Jun 11, 2016

Contributor

💯 Thanks so much.. You'll really like the plugins I'm releasing soon!

Unrelated: let me know about helping on a switch to babylon as I've got all the work done already!

Contributor

typhonrt commented Jun 11, 2016

💯 Thanks so much.. You'll really like the plugins I'm releasing soon!

Unrelated: let me know about helping on a switch to babylon as I've got all the work done already!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment