New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JSXElement. (no parse) #3

Merged
merged 1 commit into from May 19, 2015

Conversation

Projects
None yet
2 participants
@koba04
Contributor

koba04 commented May 19, 2015

Currently, an error occurs when I target files including jsx syntax like below.

import React from 'react';

class App extends React.Component {
  render() {
    return <div>Hello</div>;
  }
}
  • error trace
Error: Unknown node type JSXElement.
    at Controller.traverse (/Users/koba04/project/node_modules/esdoc/node_modules/estraverse/estraverse.js:515:31)
    at Object.traverse (/Users/koba04/project/node_modules/esdoc/node_modules/estraverse/estraverse.js:707:27)
    at Function.findPathInImportDeclaration (/Users/koba04/project/node_modules/esdoc/out/src/Util/ASTUtil.js:60:31)
    at ClassDoc._resolveLongname (/Users/koba04/project/node_modules/esdoc/out/src/Doc/AbstractDoc.js:943:51)
    at ClassDoc._extends (/Users/koba04/project/node_modules/esdoc/out/src/Doc/ClassDoc.js:137:29)
    at ClassDoc._apply (/Users/koba04/project/node_modules/esdoc/out/src/Doc/ClassDoc.js:53:23)
    at ClassDoc.AbstractDoc (/Users/koba04/project/node_modules/esdoc/out/src/Doc/AbstractDoc.js:54:10)
    at new ClassDoc (/Users/koba04/project/node_modules/esdoc/out/src/Doc/ClassDoc.js:36:20)
    at DocFactory._createDoc (/Users/koba04/project/node_modules/esdoc/out/src/Factory/DocFactory.js:320:14)
    at DocFactory._traverseComments (/Users/koba04/project/node_modules/esdoc/out/src/Factory/DocFactory.js:250:24)

This pull request is for fixing it.
This doesn't include parsing JSX tree.

h13i32maru added a commit that referenced this pull request May 19, 2015

@h13i32maru h13i32maru merged commit ff55c2b into esdoc:master May 19, 2015

@h13i32maru

This comment has been minimized.

Show comment
Hide comment
@h13i32maru

h13i32maru May 19, 2015

Member

@koba04 Thank you this PR 😄

Member

h13i32maru commented May 19, 2015

@koba04 Thank you this PR 😄

@koba04

This comment has been minimized.

Show comment
Hide comment
@koba04

koba04 May 20, 2015

Contributor

thank you! 😊

Contributor

koba04 commented May 20, 2015

thank you! 😊

@koba04 koba04 deleted the koba04:support-jsxelement branch May 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment