Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(comments): Escapes @ symbols in code blocks #436

Merged

Conversation

@pzuraq
Copy link
Contributor

@pzuraq pzuraq commented Jun 26, 2017

@ symbols inside code blocks are currently mistakenly interpreted as tags, making it difficult to have code examples for decorators. This PR escapes them, rather naively. Willing to try to do a better fix, but since this code is marked for refactor I figure @h13i32maru has plans for it anyways.

@pzuraq pzuraq force-pushed the pzuraq:bugfix/properly-escape-descriptions branch from 0daea3c to 304410a Jun 27, 2017
@pzuraq
Copy link
Contributor Author

@pzuraq pzuraq commented Jun 27, 2017

Fixed the regex

Copy link
Member

@h13i32maru h13i32maru left a comment

Thanks!

@h13i32maru h13i32maru merged commit 501d9f4 into esdoc:master Sep 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants