Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow commonjs as configs #71

Merged
merged 1 commit into from Sep 5, 2015
Merged

allow commonjs as configs #71

merged 1 commit into from Sep 5, 2015

Conversation

@raveclassic
Copy link
Contributor

raveclassic commented Sep 4, 2015

Hi!
I suggest 'requiring' esdoc configuration via nodejs instead of manually parsing like it is done in webpack. This provides opportunity to specify some values in config dinamically, do some processing etc.
For example I have 'includes' and 'excludes' values configured in my build system, and i want these values imported to esdoc config.
This change does not break current json-format configurations as nodejs supports 'requiring' json out of the box as well as commonjs.

@h13i32maru
Copy link
Member

h13i32maru commented Sep 5, 2015

@raveclassic Hi! This is awesome changing
Thanks!

h13i32maru added a commit that referenced this pull request Sep 5, 2015
allow commonjs as configs
@h13i32maru h13i32maru merged commit 444972d into esdoc:master Sep 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.