allow commonjs as configs #71

Merged
merged 1 commit into from Sep 5, 2015

Conversation

Projects
None yet
2 participants
@raveclassic
Contributor

raveclassic commented Sep 4, 2015

Hi!
I suggest 'requiring' esdoc configuration via nodejs instead of manually parsing like it is done in webpack. This provides opportunity to specify some values in config dinamically, do some processing etc.
For example I have 'includes' and 'excludes' values configured in my build system, and i want these values imported to esdoc config.
This change does not break current json-format configurations as nodejs supports 'requiring' json out of the box as well as commonjs.

@h13i32maru

This comment has been minimized.

Show comment
Hide comment
@h13i32maru

h13i32maru Sep 5, 2015

Member

@raveclassic Hi! This is awesome changing
Thanks!

Member

h13i32maru commented Sep 5, 2015

@raveclassic Hi! This is awesome changing
Thanks!

h13i32maru added a commit that referenced this pull request Sep 5, 2015

@h13i32maru h13i32maru merged commit 444972d into esdoc:master Sep 5, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment