Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash when [Symbol.iterator] is declared in a class. #78

Merged
merged 2 commits into from Sep 12, 2015

Conversation

@utatti
Copy link
Contributor

utatti commented Sep 10, 2015

Hi,

I've just uploaded the previous PR and I found the issue #73 is somewhat similar to it. However, I cannot be sure if this way is what you would like. Any comment will be welcomed, so that I can modify along with it.

Cheers 馃憤

@utatti
Copy link
Contributor Author

utatti commented Sep 12, 2015

This may conflict with another PR which has just been merged because of CoverageDocTest.js. I'll update soon

Any comment for the rest of the patch?

@h13i32maru
Copy link
Member

h13i32maru commented Sep 12, 2015

@noraesae Thanks for this PR!
But I want to fix this problem with other approach. Because [...](){} has any expression.

  • [foo](){}
  • [foo.bar.baz](){}
  • [foo + bar](){}
  • [foo()](){}
  • etc...

So, I think that generate JS code from the expression AST using escodegen.

utatti added 2 commits Sep 12, 2015
#73

Use Escodegen to parse method names using ES6's computed property names.
@utatti
Copy link
Contributor Author

utatti commented Sep 12, 2015

Updated PR using the suggested escodegen. Please feel free to comment further!

@h13i32maru
Copy link
Member

h13i32maru commented Sep 12, 2015

Wow! Thanks updated!

h13i32maru added a commit that referenced this pull request Sep 12, 2015
fix: crash when [Symbol.iterator] is declared in a class.
@h13i32maru h13i32maru merged commit 6f62ba0 into esdoc:master Sep 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can鈥檛 perform that action at this time.