Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Fetching contributors…

Cannot retrieve contributors at this time

25222 lines (17180 sloc) 929.762 kb
2009-06-15 Mark Rowe <mrowe@apple.com>
Reviewed by Oliver Hunt.
Add a script to automate the rolling over of ChangeLog files when they grow too large.
* Scripts/roll-over-ChangeLogs: Added.
2009-06-15 Simon Fraser <simon.fraser@apple.com>
Reviewed by Mark Rowe.
<rdar://problem/6974857>
Build with ENABLE_3D_RENDERING turned on by default on SnowLeopard.
* Scripts/build-webkit:
2009-06-12 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Mark Rowe.
Reviewed by Simon Hausmann.
Refactor handling of options in the build-webkit script
Options are now defined in one place, and then reused when creating
the usage help text, the arguments to GetOptions(), and when passing
the options on to the underlying port-dependent build systems.
This allows the Qt port to read the defaults for the options from the
pro file (dynamically), and to pass the options on to qmake at build.
* Scripts/build-webkit:
* Scripts/webkitdirs.pm:
2009-06-15 Mark Rowe <mrowe@apple.com>
Reviewed by Cameron Zwarich.
Fix <https://bugs.webkit.org/show_bug.cgi?id=26312>.
Bug 26312: Multiple copies of Safari opened with WebKit nightly and Safari 3.2.3
Skip the trampoline detection for versions of Safari < 4.0 as they don't play these
tricks, and having WebKitNightlyEnabler assume that we were in the trampoline was
preventing our LaunchServices trickery from being run. This led to fresh copies of
WebKit.app being launched when a URL or file was opened from an external application
rather than the existing instance being reused.
* WebKitLauncher/WebKitNightlyEnabler.m:
(insideSafari4OnTigerTrampoline):
(enableWebKitNightlyBehaviour):
2009-06-13 Sam Weinig <sam@webkit.org>
Rubber-stamped by Mark "Snowy" Rowe.
Update iExploder/htdocs/cssproperties.in by running update-iexploder-cssproperties.
* iExploder/htdocs/cssproperties.in:
2009-06-13 John Abd-El-Malek <jam@chromium.org>
Reviewed by Eric Seidel. Landed by Adam Barth.
Removed dead file.
https://bugs.webkit.org/show_bug.cgi?id=26308
* DumpRenderTree/win/TestNetscapePlugin/main.c: Removed.
2009-06-12 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Gustavo Noronha.
[Gtk] use strlen instead of g_utf8_strlen so we can enable more tests.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(dumpHistoryItem):
2009-06-12 Gustavo Noronha Silva <gns@gnome.org>
Reviewed by Jan Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=25599
[GTK] Enable more tests
Implement dumping of status callback.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(webViewStatusBarTextChanged):
(main):
2009-06-11 John Abd-El-Malek <jam@chromium.org>
Reviewed by Steve Falkenburg.
https://bugs.webkit.org/show_bug.cgi?id=26306
Revert 42565 as it leads to DumpRenderTree crashing on startup because
Windows can't find CFURLCacheCopySharedURLCache in CoreNetwork.dll.
* DumpRenderTree/win/DumpRenderTree.cpp:
2009-06-10 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Jan Alonzo.
[gtk] Change DumpRenderTree to use a GtkScrolledWindow instead of GtkFixed
Change the code to use GtkScrolledWindow and resize the GtkScrolledWindow
to pass more tests. Make sure the content is bigger than a thumbnail.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(runTest):
(main):
2009-06-10 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Gustavo Noronha.
Clear the frame name before we run each tests so we don't get
"someFloaString" or "3" in the target frame name.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetWebViewToConsistentStateBeforeTesting):
2009-06-10 Dan Bernstein <mitz@apple.com>
Reviewed by Adele Peterson.
- add a LayoutTestController method for temporarily changing the WebKit
cache model
* DumpRenderTree/LayoutTestController.cpp:
(setCacheModelCallback): Added. Calls
LayoutTestController::setCacheModel() with the first argument as an
integer.
(LayoutTestController::staticFunctions): Added setCacheModel.
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setCacheModel):
* DumpRenderTree/mac/DumpRenderTree.mm:
(setDefaultsToConsistentValuesForTesting): Reset the cache model to
WebCacheModelDocumentBrowser.
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setCacheModel): Added. Calls -[WebPreferences
setCacheModel:].
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setCacheModel):
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::setCacheModel):
2009-06-09 Mark Rowe <mrowe@apple.com>
Reviewed by Sam Weinig.
Have sunspider-compare-results use the system version of the jsc
command line binary as there's no good reason to rebuild from source
to simply compare results.
* Scripts/sunspider-compare-results:
2009-06-09 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Ariya Hidayat.
Removed setUseFixedLayout and renamed setFixedLayoutSize to
setFixedContentsSize.
* DumpRenderTree/qt/jsobjects.cpp:
(LayoutTestController::setFixedContentsSize):
* DumpRenderTree/qt/jsobjects.h:
2009-06-09 Simon Hausmann <simon.hausmann@nokia.com>
Fix the Qt build, add missing function declaration.
* DumpRenderTree/qt/jsobjects.h:
2009-06-09 Mark Rowe <mrowe@apple.com>
Reviewed by Dan Bernstein.
Fix <https://bugs.webkit.org/show_bug.cgi?id=24642>.
Bug 24642: REGRESSION: Nightly builds sometimes erroneously display a message about failing to launch successfully
Safari 4 on Tiger plays some shenanigans during launch that can confuse the nightly launcher application
in to running its initialization code too soon.
* WebKitLauncher/WebKitNightlyEnabler.m:
(insideSafariOnTigerTrampoline): Detect these shenanigans.
(enableWebKitNightlyBehaviour): Delay initialization when needed.
2009-06-08 Brady Eidson <beidson@apple.com>
Reviewed by Antti Koivisto
Add dispatchPendingLoadRequests() to test fix for <rdar://problem/6727495>
* DumpRenderTree/LayoutTestController.cpp:
(dispatchPendingLoadRequestsCallback):
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::dispatchPendingLoadRequests): Implement using [WebView _dispatchPendingLoadRequests] SPI
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::dispatchPendingLoadRequests): Need implementations.
* DumpRenderTree/qt/jsobjects.cpp:
(LayoutTestController::dispatchPendingLoadRequests): Ditto.
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::dispatchPendingLoadRequests): Ditto.
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::dispatchPendingLoadRequests): Ditto.
2009-06-07 Mark Rowe <mrowe@apple.com>
Rubber-stamped by Cameron Zwarich.
Delete the AccessibilityController that we allocated in -init.
* DumpRenderTree/mac/FrameLoadDelegate.mm:
(-[FrameLoadDelegate dealloc]):
2009-06-06 Mark Rowe <mrowe@apple.com>
Reviewed by Dan Bernstein.
Factor out the code to check whether a library contains a given symbol in to a helper function.
* Scripts/webkitdirs.pm:
2009-06-06 Mark Rowe <mrowe@apple.com>
Reviewed by Sam Weinig.
Detect when XHTML MP and WCSS are disabled and skip their associated regression tests.
* Scripts/run-webkit-tests:
* Scripts/webkitdirs.pm:
2009-06-06 Mark Rowe <mrowe@apple.com>
Reviewed by Brady Eidson.
<rdar://problem/6778101> Four SSL-related test failures
With newer versions of CFNetwork we receive a NSURLErrorServerCertificateUntrusted error
code rather than the more specific NSURLErrorServerCertificateHasUnknownRoot that DumpRenderTree
was looking for. Update DumpRenderTree to accommodate the different error code.
* DumpRenderTree/mac/FrameLoadDelegate.mm:
(-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2009-06-03 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Rubber-stamped by Simon Hausmann.
[Qt] Fix Perl warning when calling chdir with an empty/undefined path
This happened when the included makespec was in the same directory as
the parent makespec, so the relative path between the two was empty.
* Scripts/webkitdirs.pm:
2009-06-04 Darin Adler <darin@apple.com>
Reviewed by Tim Hatcher.
Fix crashes due to unbalanced start/stop observer calls.
* DumpRenderTree/mac/DumpRenderTreeWindow.h: Added observingWebView.
* DumpRenderTree/mac/DumpRenderTreeWindow.mm:
(-[DumpRenderTreeWindow startObservingWebView]): Call stopObservingWebView
in case we're already observing some other WebView. Set observingWebView.
(-[DumpRenderTreeWindow stopObservingWebView]): Do nothing if
observingWebView is already NO. Clear observingWebView.
2009-06-03 David Hyatt <hyatt@apple.com>
Reviewed by Sam Weinig.
* DumpRenderTree/mac/FrameLoadDelegate.mm:
(-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setMainFrameIsFirstResponder):
Remove explicit calls to _updateFocusedActiveState when the view is made first responder.
Focused state already properly updates when views become first responders, so these calls
are unnecessary.
(LayoutTestController::setWindowIsKey):
Explicitly call _updateActiveState when our window becomes key, since we're just faking it
and the notification won't be sent.
2009-06-02 Jessie Berlin <jberlin@apple.com>
Reviewed by Mark Rowe.
Add "replace" behavior so that it shows the addition part of the
replacement of the file first, and then shows the changes.
Future: Add in showing the removal part of the replacement.
* Scripts/svn-create-patch:
2009-06-02 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Adam Roben.
Update WinLauncher for WebKitCreateInstance.
https://bugs.webkit.org/show_bug.cgi?id=26136
* WinLauncher/WinLauncher.cpp: Revise implementation to
use WebKitCreateInstance (rather than CoCreateInstance).
* WinLauncher/WinLauncher.h: Modify include path for
WebKit.h to match DumpRenderTree style.
* WinLauncher/WinLauncher.vcproj: Remove unnecessary
WebKit.tlb and EmbeddedIDL flags from build.
2009-06-02 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Rubber-stamped by Adam Roben.
[Qt] Fix Perl warning about uninitialized value (passedConfiguration())
* Scripts/webkitdirs.pm:
2009-06-02 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Rubber-stamped by Simon Hausmann.
Use File::Spec->tmpdir instead of hardcoded paths for tempfile() dir
This fixes the Windows-build if the user does not have a /tmp directory.
* Scripts/bisect-builds:
2009-06-01 Yongjun Zhang <yongjun.zhang@nokia.com>>
Reviewed by Holger Freyther. Landed by Adam Barth.
<https://bugs.webkit.org/show_bug.cgi?id=26070>
[Qt] EventSender.keyDown doesn't support Arrow Up and Down keys.
Add Down and Up key support.
* DumpRenderTree/qt/jsobjects.cpp:
(EventSender::keyDown):
2009-06-01 Mark Rowe <mrowe@apple.com>
Reviewed by Sam Weinig.
svn-create-patch displays confusing "Broken pipe" errors from Subversion
when files have been renamed in local working copy. This was happening
because we invoke 'svn info' to determine the URL that the file was copied
from, but we were closing the pipe to the subprocess before SVN had finished
writing its output.
* Scripts/prepare-ChangeLog: Consume all 'svn info' output before closing the file handle.
* Scripts/svn-create-patch: Ditto.
2009-05-31 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
- implement LayoutTestController::clearAllDatabases() on
Windows.
Needed for storage/transaction-error-callback.html.
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::clearAllDatabases):
2009-05-28 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Added new build flag --filters. More details in WebCore/ChangeLog.
* Scripts/build-webkit:
2009-05-28 Olivier DOLE <odole@pleyo.com>
Reviewed by Maciej.
Add options to sunspider-compare-results to know which test suite to
compare (see bug #15941).
* Scripts/sunspider-compare-results:
2009-05-27 Mark Rowe <mrowe@apple.com>
Rubber-stamped by Dan Bernstein.
Update build-webkit to handle a new version of WebKitSystemInterface.
* Scripts/build-webkit:
2009-05-27 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Maciej Stachowiak.
When building with MinGW, don't use the __declspec(dl{import,export})
decorations and rely on the linker to use its nifty auto-import feature.
It is extremely hard to get the decorations right with MinGW in general
and impossible in WebKit, where the resulting shared library is linking
together some static libraries.
* DumpRenderTree/config.h:
2009-05-23 Mark Rowe <mrowe@apple.com>
Reviewed by Oliver Hunt.
Land the updated version of WebKitLauncher that the nightly builds have been using.
Changes include:
1) Support for self-updating via Sparkle.
2) Now respects the "Open using Rosetta" preference.
3) Passes environment variables through to the spawned Safari process.
4) Logs a list of extensions that are detected to the system console.
5) Disables extensions that are known to cause crashes too early in the
launch process to be detected by the extension-detection code.
* WebKitLauncher/Configurations/Base.xcconfig: Added.
* WebKitLauncher/Configurations/WebKitLauncher.xcconfig: Added.
* WebKitLauncher/Configurations/WebKitNightlyEnabler.xcconfig: Added.
* WebKitLauncher/Info.plist:
* WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
* WebKitLauncher/WebKitNightlyEnabler.h: Added.
* WebKitLauncher/WebKitNightlyEnabler.m:
(myBundleDidLoad):
(myApplicationWillFinishLaunching):
(poseAsWebKitApp):
(webKitLauncherBundle):
(enableWebKitNightlyBehaviour):
* WebKitLauncher/WebKitNightlyEnablerSparkle.h: Added.
* WebKitLauncher/WebKitNightlyEnablerSparkle.m: Added.
(initializeSparkle):
(updatePermissionPromptDescription):
(skipSignatureVerificationInDownloadDidFinish):
(updateAlertPanel):
(updateAlertInitForAlertPanel):
(-[NSAlert webKitHandleButtonPress:]):
(setMethodImplementation):
* WebKitLauncher/main.m:
(displayErrorAndQuit):
(getLastVersionShown):
(saveLastVersionShown):
(getPathForStartPage):
(getCurrentVersion):
(getShowStartPageVersion):
(startPageDisabled):
(addStartPageToArgumentsIfNeeded):
(preferredArchitecture):
(myExecve):
(locateSafariBundle):
(currentMacOSXVersion):
(checkFrameworkPath):
(main):
2009-05-23 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Gustavo Noronha and Xan Lopez.
[Gtk] Enable database and localStorage support
https://bugs.webkit.org/show_bug.cgi?id=25629
Enable database and localStorage for running the storage/ tests.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetWebViewToConsistentStateBeforeTesting):
2009-05-23 David Kilzer <ddkilzer@apple.com>
Part 1 of 2: Bug 25495: Implement PassOwnPtr and replace uses of std::auto_ptr
<https://bugs.webkit.org/show_bug.cgi?id=25495>
Reviewed by Oliver Hunt.
* DumpRenderTree/ForwardingHeaders/wtf/OwnPtrCommon.h: Added.
* DumpRenderTree/ForwardingHeaders/wtf/PassOwnPtr.h: Added.
2009-05-23 David Kilzer <ddkilzer@apple.com>
resolve-ChangeLogs: Add missing newline to status message
* Scripts/resolve-ChangeLogs: Added newline to status message
that is printed when the -c|--continue switch is used but there
are unmerged files remaining in the git working directory.
2009-05-23 Eric Seidel <eric@webkit.org>
Reviewed by Mark Rowe.
Add an error message to a die statement in run-webkit-tests
I hit this die when two users tried to run-webkit-tests at the same time. :(
* Scripts/run-webkit-tests:
2009-05-22 Andre Pedralho <andre.pedralho@openbossa.org>
Reviewed by Simon Hausmann.
Fixed --makeargs usage in Qt build.
* Scripts/build-webkit:
2009-05-22 Zoltan Horvath <horvath.zoltan.6@stud.u-szeged.hu>
Reviewed by Simon Hausmann.
Correcting error message on missing WEBKIT_TESTFONTS
environment varible in Qt-port.
* DumpRenderTree/qt/main.cpp:
(main):
2009-05-21 Eric Seidel <eric@webkit.org>
Rubber-stamped by Antti Koivisto.
Make it possible to write js-only http tests by exposing a /js-test-resources alias.
https://bugs.webkit.org/show_bug.cgi?id=25915
Second attempt at landing, now using -c instead of -C to make sure
that mod_alias is loaded on Apache 1.x instances before using Alias.
* Scripts/run-webkit-httpd:
* Scripts/run-webkit-tests:
2009-05-21 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
Default to running HTTP tests for GTK+.
* Scripts/run-webkit-tests:
2009-05-21 Darin Adler <darin@apple.com>
Rolled the httpd changes out, since many machines (including the bots)
have an older version of Apache that does not support the Alias command.
Or maybe it's something else, but the bots are failing.
* Scripts/run-webkit-httpd: Rolled back.
* Scripts/run-webkit-tests: Ditto.
2009-05-21 Eric Seidel <eric@webkit.org>
Reviewed by Geoffrey Garen.
Make it possible to write js-only http tests by exposing a /js-test-resources alias.
https://bugs.webkit.org/show_bug.cgi?id=25915
* Scripts/run-webkit-httpd:
* Scripts/run-webkit-tests:
2009-05-21 Andre Pedralho <andre.pedralho@openbossa.org>
Reviewed by Gustavo Noronha.
Added --makeargs flag to the build script.
* Scripts/build-webkit:
* Scripts/webkitdirs.pm:
2009-05-14 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=24510 where
Add testHasProperty and testHasMethod to the existing functions
of the PluginObject to be able to test the browser hasproperty
and hasmethod implementation. Invoke them from pluginInvoke.
Change the defines to an enum to avoid manually updating
NUM_METHOD_IDENTIFIERS and assigning numbers.
* DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
(testHasProperty): test hasproperty
(testHasMethod): test hasmethod
(pluginInvoke): invoke the two
2009-05-20 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by George Staikos.
BUG 25843: [Qt] Remove qt-port build flag
<https://bugs.webkit.org/show_bug.cgi?id=25843>
* DumpRenderTree/qt/DumpRenderTree.pro:
* Scripts/webkitdirs.pm:
2009-05-18 Eric Seidel <eric@webkit.org>
Reviewed by Oliver Hunt.
Remove layoutTestController.addFileToPasteboardOnDrag and add eventSender.beginDragWithFiles
https://bugs.webkit.org/show_bug.cgi?id=25852
This allows us to now test multi-file file drags in DumpRenderTree per:
https://bugs.webkit.org/show_bug.cgi?id=25862
I removed the existing tests using addFileToPasteboardOnDrag()
and replaced them with a new test (editing/pasteboard/file-input-files-access)
which covers several more drag-drop cases.
I added a DumpRenderTreeFileDraggingSource class to avoid
the hack of if (!draggingSource) in [DumpRenderTreeDraggingInfo draggingSourceOperationMask]
New Test: editing/pasteboard/file-input-files-access.html
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* DumpRenderTree/DumpRenderTreeFileDraggingSource.h: Added.
* DumpRenderTree/DumpRenderTreeFileDraggingSource.m: Added.
(-[DumpRenderTreeFileDraggingSource draggingSourceOperationMaskForLocal:]):
* DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::staticValues): removed addFileToPasteboardOnDrag support
(LayoutTestController::staticFunctions): removed addFileToPasteboardOnDrag support
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/mac/DumpRenderTree.mm:
(runTest): ASSERT that draggingInfo has been cleared
* DumpRenderTree/mac/EventSendingController.mm:
(+[EventSendingController isSelectorExcludedFromWebScript:]): Sorted selectors.
(+[EventSendingController webScriptNameForSelector:]): Sorted selectors.
(-[EventSendingController beginDragWithFiles:]):
(-[EventSendingController mouseMoveToX:Y:]):
(-[EventSendingController keyDown:withModifiers:]):
(-[EventSendingController fireKeyboardEventsToElement:]): removed spurious { }
* DumpRenderTree/mac/UIDelegate.mm:
(-[UIDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]): removed addFileToPasteboardOnDrag support
2009-05-19 Kevin Ollivier <kevino@theolliviers.com>
wxMSW build fixes for DRT.
* DumpRenderTree/wx/DumpRenderTreeWx.cpp:
(runTest):
* DumpRenderTree/wx/WorkQueueItemWx.cpp:
(LoadItem::invoke):
(ReloadItem::invoke):
(ScriptItem::invoke):
(BackForwardItem::invoke):
2009-05-18 Julien Chaffraix <jchaffraix@webkit.org>
Bug 24569: Add some cookies tests
<https://bugs.webkit.org/show_bug.cgi?id=24569>
Patch by David Kilzer.
* Scripts/make-js-test-wrappers: Added regex to skip
cookies-test-(post|pre).js files.
2009-05-18 Kevin Ollivier <kevino@theolliviers.com>
wx build fix. Use python-config to get Python linking info on Unix OSes.
* wx/build-wxwebkit:
2009-05-18 Kevin Ollivier <kevino@theolliviers.com>
wx build fix, initialize variable that doesn't get set on Windows.
* DumpRenderTree/wx/DumpRenderTreeWx.cpp:
(MyApp::OnInit):
2009-05-18 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Xan Lopez.
[Gtk] Various autotools build refactoring and fixes
https://bugs.webkit.org/show_bug.cgi?id=25286
Add -no-install and -no-fast-install to programs and tests that we
don't install. Also remove -O2 since this is already handled at
configure time.
* GNUmakefile.am:
2009-05-18 Julie Parent <jparent@google.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=25846
Make eventSender dispatch a drag over event.
* DumpRenderTree/mac/UIDelegate.mm:
(-[UIDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]):
2009-05-18 Julie Parent <jparent@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=25716
* Scripts/make-js-test-wrappers: Added exception to avoid overwriting a custom-written test.
2009-05-18 Julie Parent <jparent@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=25716
* Scripts/make-js-test-wrappers: Added exception to avoid overwriting a custom-written test.
2009-05-11 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Jan Michael Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=25787
Merge r41819 into Gtk. Do not use printf but send messages
through the log command.
* DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
(log):
(webkit_test_plugin_new_instance):
(webkit_test_plugin_destroy_instance):
(webkit_test_plugin_set_window):
(webkit_test_plugin_handle_event):
2009-05-11 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Jan Michael Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=25787
Forward port r39877 from main.c of OSX to TestNetscapePlugin
of Gtk.
* DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
(webkit_test_plugin_new_instance):
2009-05-15 Kevin Ollivier <kevino@theolliviers.com>
wx build fix. Don't parse args using getopt since it isn't available on Windows.
* DumpRenderTree/wx/DumpRenderTreeWx.cpp:
(MyApp::OnInit):
2009-05-15 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Holger Freyther.
[GTK] Implement layoutTestController.waitForPolicyDelegate
https://bugs.webkit.org/show_bug.cgi?id=25036
Connect to 'navigation-policy-decision-requested' and handle
waitForPolicy in the callback.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(invalidateAnyPreviousWaitToDumpWatchdog):
(webViewNavigationPolicyDecisionRequested):
(main):
* DumpRenderTree/gtk/DumpRenderTreeGtk.h:
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::notifyDone):
(LayoutTestController::waitForPolicyDelegate):
2009-05-14 David Levin <levin@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=24704
Make paths where data is saved be scoped to the ~ directory,
so that one can run independent instances by setting CFFIXED_USER_HOME.
* DumpRenderTree/mac/DumpRenderTree.mm:
(libraryPath):
(setDefaultsToConsistentValuesForTesting):
(dumpFrameAsPDF):
2009-05-13 David Kilzer <ddkilzer@apple.com>
Fix resolve-ChangeLogs when used with Subversion
Reviewed by Darin Adler.
Fixes the following issue when run on a Subversion repository:
$ ./WebKitTools/Scripts/resolve-ChangeLogs
ERROR: --continue may only be used with a git repository
* Scripts/resolve-ChangeLogs: Check for the boolean value of
$gitRebaseContinue, not whether it's defined, when validating
command-line switches.
2009-05-12 David Kilzer <ddkilzer@apple.com>
Bug 21418: resolve-ChangeLogs should have a --continue option which does git rebase --continue
<https://bugs.webkit.org/show_bug.cgi?id=21418>
Reviewed by Darin Adler.
* Scripts/resolve-ChangeLogs: Added -c|--continue switch that
runs "git rebase --continue" before exiting the script.
(hasGitUnmergedFiles): Added. Returns true if there are
unmerged files in the git repository.
2009-05-11 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Holger Freyther.
[Qt] Make sure that public APIs are properly exported on all Qt platforms
https://bugs.webkit.org/show_bug.cgi?id=25601
* Scripts/webkitdirs.pm: Remove QT_SHARED define from Qt builds, define QT_MAKEDLL in WebCore.pro instead
2009-05-07 Kevin Ollivier <kevino@theolliviers.com>
wx build fixes for Python extension and DRT.
* DumpRenderTree/wx/DumpRenderTreeWx.cpp:
(MyApp::OnInit):
* wx/build-wxwebkit:
2009-05-07 Steve Falkenburg <sfalken@apple.com>
Remove manifest fixup from r42729 to fix clean builds.
* DumpRenderTree/win/DumpRenderTree.vcproj:
2009-05-06 Kevin Ollivier <kevino@theolliviers.com>
wx build fix, fixes for wx trunk builds.
* DumpRenderTree/wx/DumpRenderTreeWx.cpp:
(MyApp::OnInit):
* wx/build-wxwebkit:
2009-05-06 Steve Falkenburg <sfalken@apple.com>
Explicitly set WebKitPaintNativeControls to false to allow Windows results to match Mac.
Reviewed by Adam Roben.
* DumpRenderTree/win/DumpRenderTree.cpp:
(resetWebViewToConsistentStateBeforeTesting):
2009-05-06 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
Build QtWebKit as a framework on Mac
This implies both debug and release build by default, unless
one of the --debug or --release config options are passed to
the build-webkit script.
Frameworks can be disabled by passing CONFIG+=webkit_no_framework
to the build-webkit script.
To be able to build both debug and release targets in parallel
we have to use separate output directories for the generated
sources, which is not optimal, but required to avoid race conditions.
An optimization would be to only require this spit-up on Mac.
* Scripts/webkitdirs.pm:
2009-05-05 Darin Adler <darin@apple.com>
Try to fix Mac build.
* DumpRenderTree/AccessibilityUIElement.cpp: (elementAtPointCallback): Initialize x and y.
2009-05-05 Maclolm MacLeod <mmacleod@webmail.co.za>
Reviewed by Kevin Ollivier.
Have wxWebkit make use of gcc(4 and greater) hidden visibility feature
https://bugs.webkit.org/show_bug.cgi?id=24345
* wx/build-wxwebkit:
2009-05-05 Chris Fleizach <cfleizach@apple.com>
Reviewed by Beth Dakin.
Bug 25574: AXImageMap children links don't respond properly to accessibilityHitTest:
https://bugs.webkit.org/show_bug.cgi?id=25574
* DumpRenderTree/AccessibilityUIElement.cpp:
(elementAtPointCallback):
(getXCallback):
(getYCallback):
(AccessibilityUIElement::getJSClass):
* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(descriptionOfValue):
(AccessibilityUIElement::elementAtPoint):
(AccessibilityUIElement::role):
(AccessibilityUIElement::title):
(AccessibilityUIElement::description):
(AccessibilityUIElement::x):
(AccessibilityUIElement::y):
(AccessibilityUIElement::width):
(AccessibilityUIElement::height):
(AccessibilityUIElement::intValue):
(AccessibilityUIElement::minValue):
(AccessibilityUIElement::maxValue):
(AccessibilityUIElement::insertionPointLineNumber):
(AccessibilityUIElement::supportsPressAction):
(AccessibilityUIElement::lineForIndex):
* DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::elementAtPoint):
(AccessibilityUIElement::x):
(AccessibilityUIElement::y):
2009-05-06 Christian Dywan <christian@twotoasts.de>
Reviewed by Gustavo Noronha.
http://bugs.webkit.org/show_bug.cgi?id=17066
[GTK] Improve frameloader signals
Update GtkLauncher to use the new load-status and progress properties
instead of the previous loading signals.
* GtkLauncher/main.c:
(update_title):
(notify_load_status_cb):
(notify_progress_cb):
(create_browser):
(create_window):
2009-05-05 Adam Roben <aroben@apple.com>
Don't use pdevenv when building with VC++ Express
Fixes Bug 25308: REGRESSION (r42182): Build fails after following
build instructions on webkit.org fail when using VC++ Express
<https://bugs.webkit.org/show_bug.cgi?id=25308>
Reviewed by Eric Seidel.
* Scripts/webkitdirs.pm:
(setupCygwinEnv): When Visual Studio is installed, set $vcBuildPath to
point to pdevenv. When VC++ Express is installed, set $vcBuildPath to
point to VC++ Express, as before.
(buildVisualStudioProject): Use $vcBuildPath to build instead of
hard-coding pdevenv.
2009-05-05 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Rubber-stamped by Simon Hausmann.
Mention --qt as an option in the build-webkit help
* Scripts/build-webkit:
2009-05-04 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Alexey Proskuryakov.
Enable spell-checking in DumpRenderTree.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetWebViewToConsistentStateBeforeTesting):
2009-05-04 Kevin Ollivier <kevino@theolliviers.com>
Reviewed by Eric Seidel.
Initial DRT implementation for wx.
* DumpRenderTree/DumpRenderTree.h:
* DumpRenderTree/wx: Added.
* DumpRenderTree/wx/DumpRenderTree.bkl: Added.
* DumpRenderTree/wx/DumpRenderTreeWx.cpp: Added.
(LayoutWebViewEventHandler::LayoutWebViewEventHandler):
(LayoutWebViewEventHandler::bindEvents):
(LayoutWebViewEventHandler::OnLoadEvent):
(LayoutWebViewEventHandler::OnAlertEvent):
(LayoutWebViewEventHandler::OnConfirmEvent):
(LayoutWebViewEventHandler::OnPromptEvent):
(LayoutWebViewEventHandler::OnConsoleMessageEvent):
(LayoutWebViewEventHandler::OnReceivedTitleEvent):
(LayoutWebViewEventHandler::OnWindowObjectClearedEvent):
(notifyDoneFired):
(dumpFramesAsText):
(dump):
(runTest):
(MyApp::OnInit):
* DumpRenderTree/wx/DumpRenderTreeWx.h: Added.
* DumpRenderTree/wx/GCControllerWx.cpp: Added.
(GCController::collect):
(GCController::collectOnAlternateThread):
(GCController::getJSObjectCount):
* DumpRenderTree/wx/LayoutTestControllerWx.cpp: Added.
(LayoutTestController::~LayoutTestController):
(LayoutTestController::addDisallowedURL):
(LayoutTestController::clearBackForwardList):
(LayoutTestController::copyDecodedHostName):
(LayoutTestController::copyEncodedHostName):
(LayoutTestController::display):
(LayoutTestController::keepWebHistory):
(LayoutTestController::notifyDone):
(LayoutTestController::pathToLocalResource):
(LayoutTestController::queueLoad):
(LayoutTestController::setAcceptsEditing):
(LayoutTestController::setCustomPolicyDelegate):
(LayoutTestController::setMainFrameIsFirstResponder):
(LayoutTestController::setTabKeyCyclesThroughElements):
(LayoutTestController::setUseDashboardCompatibilityMode):
(LayoutTestController::setUserStyleSheetEnabled):
(LayoutTestController::setUserStyleSheetLocation):
(LayoutTestController::setWindowIsKey):
(LayoutTestController::setSmartInsertDeleteEnabled):
(LayoutTestController::setJavaScriptProfilingEnabled):
(LayoutTestController::setWaitToDump):
(LayoutTestController::windowCount):
(LayoutTestController::setPrivateBrowsingEnabled):
(LayoutTestController::setAuthorAndUserStylesEnabled):
(LayoutTestController::setPopupBlockingEnabled):
(LayoutTestController::elementDoesAutoCompleteForElementWithId):
(LayoutTestController::execCommand):
(LayoutTestController::setPersistentUserStyleSheetLocation):
(LayoutTestController::clearPersistentUserStyleSheet):
(LayoutTestController::clearAllDatabases):
(LayoutTestController::setDatabaseQuota):
(LayoutTestController::numberOfActiveAnimations):
(LayoutTestController::setSelectTrailingWhitespaceEnabled):
(LayoutTestController::pauseTransitionAtTimeOnElementWithId):
(LayoutTestController::setIconDatabaseEnabled):
(LayoutTestController::pauseAnimationAtTimeOnElementWithId):
(LayoutTestController::isCommandEnabled):
(LayoutTestController::webHistoryItemCount):
(LayoutTestController::waitForPolicyDelegate):
* DumpRenderTree/wx/WorkQueueItemWx.cpp: Added.
(LoadItem::invoke):
(ReloadItem::invoke):
(ScriptItem::invoke):
(BackForwardItem::invoke):
* Scripts/build-dumprendertree:
* Scripts/run-webkit-tests:
* Scripts/webkitdirs.pm:
* wx/build-wxwebkit:
2009-05-03 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Don't pass an exception parameter if we don't care about the value.
* DumpRenderTree/win/EventSender.cpp:
(keyDownCallback):
2009-05-02 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
Another cut at getting tests passing on Windows again.
* DumpRenderTree/win/FrameLoadDelegate.cpp:
(FrameLoadDelegate::didStartProvisionalLoadForFrame): Tweak formatting.
(FrameLoadDelegate::didFailProvisionalLoadWithError): Ditto.
(FrameLoadDelegate::didCommitLoadForFrame): Ditto.
(FrameLoadDelegate::didFinishLoadForFrame): Ditto.
(FrameLoadDelegate::didFailLoadWithError): Added missing logging.
2009-05-02 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
Try to get tests passing on Windows again.
* DumpRenderTree/win/DumpRenderTree.cpp:
(shouldLogFrameLoadDelegates): Allow either "/" or "\" as a path
separator. Also require separator before as well as after path name.
2009-04-30 Kevin Ollivier <kevino@theolliviers.com>
wx build fix, define ENABLE_JAVASCRIPT_DEBUGGER.
* wx/build-wxwebkit:
2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Timothy Hatcher.
https://bugs.webkit.org/show_bug.cgi?id=25470
Extend the cover of ENABLE_JAVASCRIPT_DEBUGGER to profiler.
* Scripts/build-webkit: Added ENABLE_JAVASCRIPT_DEBUGGER define.
2009-04-29 Mark Rowe <mrowe@apple.com>
Update build.webkit.org configuration for the addition of the new GTK buildbot.
* BuildSlaveSupport/build.webkit.org-config/config.json:
2009-04-29 Mark Rowe <mrowe@apple.com>
Ignore the --use-remote-links-to-tests option for GTK as it leads to
perl errors being spewed at the end of run-webkit-tests.
* Scripts/run-webkit-tests:
2009-04-29 Mark Rowe <mrowe@apple.com>
Implement test-result-archive for GTK.
* BuildSlaveSupport/test-result-archive:
2009-04-28 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by David Kilzer.
https://bugs.webkit.org/show_bug.cgi?id=25462
Make sure "--pixel --add-platform-exceptions" produces platform
specific pixel test results.
* Scripts/run-webkit-tests: Support "--pixel
--add-platform-exceptions"
2009-04-28 Steve Falkenburg <sfalken@apple.com>
Fix link warnings building TestNetscapePlugin on Windows due to mismatched
DLL name vs. LIBRARY directive name.
Reviewed by Jon Honeycutt.
* DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.def:
* DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
* DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin_debug.def: Added.
2009-04-28 Steve Falkenburg <sfalken@apple.com>
Fix warnings about PRODUCTION and ARCHIVE_BUILD on Windows builds
of ImageDiff and DumpRenderTree.
Rubber stamped by Adam Roben.
* DumpRenderTree/win/DumpRenderTree.vcproj:
* DumpRenderTree/win/ImageDiff.vcproj:
2009-04-28 Chris Fleizach <cfleizach@apple.com>
Reviewed by Darin Adler.
Add ability to get the children count of an AX element.
* DumpRenderTree/AccessibilityUIElement.cpp:
(getChildrenCountCallback):
(AccessibilityUIElement::getJSClass):
* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::childrenCount):
* DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::childrenCount):
2009-04-27 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Gustavo Noronha.
[GTK] Make layout tests / jsc tests usable without build-webkit
https://bugs.webkit.org/show_bug.cgi?id=21784
This requires WEBKITOUTPUTDIR to be set to the build directory.
Set the location of the product dir to the location pointed to by
WEBKITOUTPUTDIR.
* Scripts/webkitdirs.pm:
2009-04-27 Gustavo Noronha Silva <gns@gnome.org>
Reviewed by Adam Roben.
Use libsoup's facilities to resolve relative URLs, instead, since
it is a more robust method.
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::queueLoad):
2009-04-26 Gustavo Noronha Silva <gns@gnome.org>
Reviewed by Xan Lopez.
Resolve relative URLs when queueing loads. This fixes
post-goback-same-url.html timing out.
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::queueLoad):
2009-04-24 Kevin Ollivier <kevino@theolliviers.com>
wx build fix. Switching JSCore from a static lib to a dynamic lib
to match the Apple build and fix symbol exports.
* wx/build-wxwebkit:
2009-04-24 Eric Seidel <eric@webkit.org>
Reviewed by Adam Roben.
Add PrettyPatch support to run-webkit-tests
* Scripts/run-webkit-tests:
2009-04-24 Steve Falkenburg <sfalken@apple.com>
Fix nightly for Windows x64 users.
Installed browser location is written to a slightly different registry key in that case.
* FindSafari/FindSafari.cpp:
(getInstalledWebKitDirectory):
2009-04-23 Mark Rowe <mrowe@apple.com>
Fix the Windows DRT build.
* DumpRenderTree/win/PolicyDelegate.h:
2009-04-23 Brady Eidson <beidson@apple.com>
Fix Windows DRT build.
* DumpRenderTree/win/PolicyDelegate.cpp:
(PolicyDelegate::unableToImplementPolicyWithError):
2009-04-22 Brady Eidson <beidson@apple.com>
Reviewed by Maciej Stachowiak
Add additional support for test:
<rdar://problem/5689748> - Cannot redirect to protocols handled by external applications.
* DumpRenderTree/mac/PolicyDelegate.mm:
(-[PolicyDelegate webView:unableToImplementPolicyWithError:frame:]): Dump formatted information when
a policy cannot be implemented.
* DumpRenderTree/win/PolicyDelegate.cpp:
(PolicyDelegate::unableToImplementPolicyWithError): Ditto.
* DumpRenderTree/win/PolicyDelegate.h:
2009-04-22 Sam Weinig <sam@webkit.org>
Rubber-stamped by Darin Adler.
Fix for <rdar://problem/6816957>
Turn off Geolocation by default
* Scripts/build-webkit:
2009-04-21 Dan Bernstein <mitz@apple.com>
Reviewed by Jon Honeycutt.
- dump the node in the element dictionary in the action information
passed to the policy delegate
* DumpRenderTree/mac/PolicyDelegate.mm:
(-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
* DumpRenderTree/win/PolicyDelegate.cpp:
(dumpPath):
(PolicyDelegate::decidePolicyForNavigationAction):
2009-04-21 Adam Roben <aroben@apple.com>
Windows build fix after r42726
* DumpRenderTree/win/DumpRenderTree.cpp: Touched to force a rebuild.
* DumpRenderTree/win/DumpRenderTree.vcproj: Delete any pre-r42726
manifest files during the pre-build event.
2009-04-21 Steve Falkenburg <sfalken@apple.com>
Use new WebKitCreateInstance API instead of CoCreateInstance
or COMPtr's createInstance to instantiate WebKit COM objects.
Reviewed by Adam Roben.
* DumpRenderTree/win/DumpRenderTree.cpp:
(initialize):
(runTest):
(createWebViewAndOffscreenWindow):
(main):
* DumpRenderTree/win/DumpRenderTree.vcproj:
* DumpRenderTree/win/GCControllerWin.cpp:
(GCController::collect):
(GCController::collectOnAlternateThread):
(GCController::getJSObjectCount):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::keepWebHistory):
(LayoutTestController::webHistoryItemCount):
(LayoutTestController::setIconDatabaseEnabled):
* DumpRenderTree/win/WorkQueueItemWin.cpp:
(LoadItem::invoke):
2009-04-20 Timothy Hatcher <timothy@apple.com>
Stop using the fullDocumentTeardownEnabled WebPreference methods.
Just set the WebKitEnableFullDocumentTeardownPreferenceKey default.
Reviewed by Darin Adler.
* DumpRenderTree/mac/DumpRenderTree.mm:
(setDefaultsToConsistentValuesForTesting):
(resetWebViewToConsistentStateBeforeTesting):
2009-04-21 Geoffrey Garen <ggaren@apple.com>
Rubber-stamped by Adam Roben.
Disabled one more Mozilla JS test because it fails intermittently on Windows.
(See https://bugs.webkit.org/show_bug.cgi?id=25160.)
* Scripts/run-javascriptcore-tests:
2009-04-21 Adam Roben <aroben@apple.com>
Fix running run-safari and run-webkit-tests from the paths recommended
on webkit.org
Reviewed by Steve Falkenburg and Sam Weinig.
* Scripts/run-webkit-nightly.cmd: Moved quotes from variable
definitions to variable uses. Otherwise cmd.exe can get confused about
the quoting.
* Scripts/run-webkit-tests: Changed to use an absolute path to
execAppWithEnv so that run-webkit-tests will work when run from
outside the source tree.
2009-04-21 Adam Roben <aroben@apple.com>
Rename JavaScriptCore_debug.dll to JavaScriptCore.dll in the Debug
configuration
This matches the naming scheme for WebKit.dll, and will be necessary
once Safari links against JavaScriptCore.dll. This change also causes
run-safari not to fail (because the launcher printed by FindSafari was
always looking for JavaScriptCore.dll, never
JavaScriptCore_debug.dll).
Part of Bug 25305: can't run safari or drt on windows
<https://bugs.webkit.org/show_bug.cgi?id=25305>
Reviewed by Steve Falkenburg and Sam Weinig.
* DumpRenderTree/win/DumpRenderTree.vcproj: Use
$(WebKitDLLConfigSuffix) for naming JavaScriptCore.{dll,lib}.
2009-04-21 Steve Falkenburg <sfalken@apple.com>
Update FindSafari for JavaScriptCore DLL changes.
Also removed code previously needed to support running nightlies against Safari 3 on Windows.
Reviewed by Mark Rowe.
* FindSafari/FindSafari.cpp:
(getStringValue):
(getInstalledWebKitDirectory):
(_tmain):
2009-04-20 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added PlainTextController.h
and PlainTextController.mm.
* DumpRenderTree/mac/FrameLoadDelegate.mm:
(-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]): Added PlainTextController
as "window.plainText".
* DumpRenderTree/mac/PlainTextController.h: Added.
* DumpRenderTree/mac/PlainTextController.mm: Added.
2009-04-20 Steve Falkenburg <sfalken@apple.com>
Separate JavaScriptCore.dll from WebKit.dll.
Slight performance improvement or no change on benchmarks.
Allows us to break a circular dependency between CFNetwork and WebKit on Windows,
and simplifies standalone JavaScriptCore builds.
Reviewed by Oliver Hunt.
* DumpRenderTree/config.h: Specify JS, WebKit exported data as __declspec(dllimport)
* DumpRenderTree/win/DumpRenderTree.vcproj: Link against JavaScriptCore.dll
2009-04-20 Sam Weinig <sam@webkit.org>
Rubber-stamped by Tim Hatcher.
Add licenses for xcconfig files.
* DumpRenderTree/mac/Configurations/Base.xcconfig:
* DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
* DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
* DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
* DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
2009-04-19 David Kilzer <ddkilzer@apple.com>
Make FEATURE_DEFINES completely dynamic
Reviewed by Darin Adler.
Make FEATURE_DEFINES depend on individual ENABLE_FEATURE_NAME
variables for each feature, making it possible to remove all
knowledge of FEATURE_DEFINES from build-webkit.
* Scripts/build-webkit: Define individual ENABLE_FEATURE_NAME
variables instead of the whole FEATURE_DEFINES string when
building with Xcode. Miscellaneous clean up:
- Reordered/sorted command-line switch variables.
- Reordered/sorted command-line switches in $usage.
- Reordered/sorted command-line switches in GetOptions().
- Defined $svgSupport to true if any --svg-feature switch is
set in order to match "Implies SVG Support" claim.
- Build JavaScriptGlue after JavaScriptCore again!
- Fixed --[no-]geolocation for GTK+ port and sorted GTK+
command-line switches.
- Added "exit 0" statement at the end of the script.
2009-04-17 David Kilzer <ddkilzer@apple.com>
Simplify FEATURE_DEFINES definition
Reviewed by Darin Adler.
This moves FEATURE_DEFINES and its related ENABLE_FEATURE_NAME
variables to their own FeatureDefines.xcconfig file. It also
extracts a new ENABLE_GEOLOCATION variable so that
FEATURE_DEFINES only needs to be defined once.
* Scripts/build-webkit: Realphabetized code related to enabling
Geolation features for WebKit. Also set ENABLE_GEOLOCATION
variable for xcodebuild.
2009-04-16 Darin Fisher <darin@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=25223
REGRESSION: Back button after form submission to the same URL fails to navigate.
* DumpRenderTree/mac/FrameLoadDelegate.mm:
(-[FrameLoadDelegate processWork:]): Need to defer processing the work
queue if a navigation started between locationChangeDone and our
delayed processWork call. This can happen when using queueLoadingScript
to load script that simulates a click on a link or submit button since
those clicks happen asynchronously.
* DumpRenderTree/win/FrameLoadDelegate.cpp:
(FrameLoadDelegate::processWork): Same as above.
2009-04-16 Geoffrey Garen <ggaren@apple.com>
Build fix: updated check-for-global-initializers to account for code motion.
* Scripts/check-for-global-initializers:
2009-04-16 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Adam Roben.
Compare test's response mime type and dump test as text properly.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(dump):
2009-04-16 Adam Roben <aroben@apple.com>
Skip yet another JavaScriptCore test that sometimes fails on Windows
See Bug 25160: Various ecma/Date tests sometimes fail on Windows (but
not Mac)
<https://bugs.webkit.org/show_bug.cgi?id=25160>
* Scripts/run-javascriptcore-tests: Skip ecma/Date/15.9.2.2-6.js.
2009-04-15 Steve Falkenburg <sfalken@apple.com>
Redo last build fix in a more straightforward way.
* DumpRenderTree/win/DumpRenderTree.cpp:
(sharedCFURLCache):
2009-04-15 Steve Falkenburg <sfalken@apple.com>
Fix Windows build of DumpRenderTree.
* DumpRenderTree/win/DumpRenderTree.cpp:
(sharedCFURLCache):
(main):
2009-04-15 Adam Roben <aroben@apple.com>
Skip yet another JavaScriptCore test that sometimes fails on Windows
See Bug 25160: Various ecma/Date tests sometimes fail on Windows (but
not Mac)
<https://bugs.webkit.org/show_bug.cgi?id=25160>
* Scripts/run-javascriptcore-tests: Skip ecma/Date/15.9.2.2-2.js (who
didn't see it coming?).
2009-04-14 Adam Roben <aroben@apple.com>
Skip another JavaScriptCore test that sometimes fails on Windows
See Bug 25160: Various ecma/Date tests sometimes fail on Windows (but
not Mac)
<https://bugs.webkit.org/show_bug.cgi?id=25160>
Rubber-stamped by Geoff Garen.
* Scripts/run-javascriptcore-tests: Skip ecma/Date/15.9.2.2-3.js.
2009-04-14 Kevin Ollivier <kevino@theolliviers.com>
wx build fix. Move the DerivedSources.make calls into build-wxwebkit so that
the FEATURE_DEFINES are parsed properly.
* wx/build-wxwebkit:
2009-04-14 Adam Roben <aroben@apple.com>
Small run-javascriptcore-tests cleanup
Reviewed by Cameron Zwarich.
* Scripts/run-javascriptcore-tests: Move the list of tests to skip
into its own variable, annotated with the bugs that are filed about
the various failures.
2009-04-14 Adam Roben <aroben@apple.com>
Skip another sometimes-failing ecma/Date test on Windows
These failing tests are covered by Bug 25160: Various ecma/Date tests
sometimes fail on Windows (but not Mac)
<https://bugs.webkit.org/show_bug.cgi?id=25160>
Reviewed by Cameron Zwarich.
* Scripts/run-javascriptcore-tests: Added ecma/Date/15.9.2.1.js to the
list of tests to skip.
2009-04-14 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Holger Freyther.
[Gtk] disable soup auth dialog when running DRT
https://bugs.webkit.org/show_bug.cgi?id=24598
Disable soup's auth dialog when running the tests.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(setDefaultsToConsistentStateValuesForTesting):
* GNUmakefile.am:
2009-04-13 Darin Adler <darin@apple.com>
Reviewed by Mark Rowe.
* Scripts/check-for-exit-time-destructors: Add ERROR: and WARNING: prefixes to
make these scripts work better with the build window in new versions of Xcode.
* Scripts/check-for-global-initializers: Ditto.
* Scripts/check-for-weak-vtables: Ditto.
2009-04-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Disabled another JavaScriptCore test because it fails on Windows but
not Mac, so it makes the bots red.
* Scripts/run-javascriptcore-tests:
2009-04-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Disabled two JavaScriptCore tests because they fail on Window or Mac but
not both, so they make the bots red.
* Scripts/run-javascriptcore-tests:
2009-04-13 Darin Adler <darin@apple.com>
* Scripts/make-js-test-wrappers: Added another exception.
2009-04-10 Adam Roben <aroben@apple.com>
Add our new test font to the list that DRT knows about
Reviewed by Dan Bernstein.
* DumpRenderTree/win/DumpRenderTree.cpp:
(initialize): Added WebKit Layout Tests 2.ttf.
2009-04-09 Jan Michael Alonzo <jmalonzo@webkit.org>
Unreviewed Gtk build fix for undefined reference: g_thread_init.
Add GLIB_LIBS to DRT and GtkLauncher build config.
* GNUmakefile.am:
2009-04-09 David Kilzer <ddkilzer@apple.com>
Reinstating <rdar://problem/6718589> Option to turn off SVG DOM Objective-C bindings
Rolled r42345 back in. The build failure was caused by an
internal script which had not been updated the same way that
build-webkit was updated.
* Scripts/build-webkit:
2009-04-09 David Levin <levin@chromium.org>
Reviewed by David Kilzer.
https://bugs.webkit.org/show_bug.cgi?id=25101
Launch DumpRenderTree and the image diff tool in a way that will work from perl threads.
This is a workaround due to a perl limitation. When perl does open* calls on a thread, it ignores
the environment of the current thread and simply uses the environment of the main thread instead.
* Scripts/execAppWithEnv: Added.
* Scripts/run-webkit-tests:
2009-04-09 Alexey Proskuryakov <ap@webkit.org>
Reverting <rdar://problem/6718589> Option to turn off SVG DOM Objective-C bindings.
It broke Mac build, and I don't know how to fix it.
* Scripts/build-webkit:
2009-04-08 David Kilzer <ddkilzer@apple.com>
<rdar://problem/6718589> Option to turn off SVG DOM Objective-C bindings
Reviewed by Darin Adler and Maciej Stachowiak.
Introduce the ENABLE_SVG_DOM_OBJC_BINDINGS feature define so
that SVG DOM Objective-C bindings may be optionally disabled.
* Scripts/build-webkit: Added --[no-]svg-dom-objc-bindings
command-line argument. Set special ENABLE_SVG_DOM_OBJC_BINDINGS
Xcode variable required by WebCore.xcconfig.
2009-04-07 Adam Roben <aroben@apple.com>
Print the number of files being compiled when using pdevenv
* Scripts/parallelcl:
2009-04-07 Mark Rowe <mrowe@apple.com>
Land the current build.webkit.org configuration for safekeeping.
* BuildSlaveSupport/build.webkit.org-config/README: Added.
* BuildSlaveSupport/build.webkit.org-config/Makefile:
* BuildSlaveSupport/build.webkit.org-config/buildbot.tac:
* BuildSlaveSupport/build.webkit.org-config/config.json: Added.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
* BuildSlaveSupport/build.webkit.org-config/public_html/buildbot.css: Renamed from BuildSlaveSupport/build.webkit.org-config/buildbot.css.
* BuildSlaveSupport/build.webkit.org-config/public_html/index.html: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/robots.txt: Added.
* BuildSlaveSupport/build.webkit.org-config/webkit/__init__.py: Removed.
* BuildSlaveSupport/build.webkit.org-config/webkit/auth.py: Removed.
* BuildSlaveSupport/build.webkit.org-config/webkit/basesteps.py: Removed.
* BuildSlaveSupport/build.webkit.org-config/webkit/builders.py: Removed.
* BuildSlaveSupport/build.webkit.org-config/webkit/factories.py: Removed.
* BuildSlaveSupport/build.webkit.org-config/webkit/schedulers.py: Removed.
* BuildSlaveSupport/build.webkit.org-config/webkit/status.py: Removed.
* BuildSlaveSupport/build.webkit.org-config/webkit/steps.py: Removed.
2009-04-07 Mark Rowe <mrowe@apple.com>
Ignore the mysterious exception that Cygwin's Python is throwing when attempting
to remove the layout-test-results directory.
* BuildSlaveSupport/test-result-archive:
2009-04-07 Mark Rowe <mrowe@apple.com>
Change the working directory before removing the test result directory
in the hopes of making the Windows build slaves happier.
* BuildSlaveSupport/test-result-archive:
2009-04-07 Mark Rowe <mrowe@apple.com>
Reviewed by Adam Roben.
Make the links to tests in the uploaded results.html files on build.webkit.org point to the test files.
* Scripts/VCSUtils.pm: Add a function that will return the location of a file relative to the root of the working copy.
* Scripts/run-webkit-tests: Convert the path in to a remote URL if the path is below the layout tests directory.
2009-04-07 Mark Rowe <mrowe@apple.com>
Remove the layout-test-results directory after we have archived it so that
log files and results are reset between runs of the tests.
* BuildSlaveSupport/test-result-archive:
2009-04-07 Mark Rowe <mrowe@apple.com>
Helper script for uploading layout test results for display on build.webkit.org.
* BuildSlaveSupport/test-result-archive: Copied from WebKitTools/BuildSlaveSupport/built-product-archive.
2009-04-11 Brian Weinstein <bweinstein@gmail.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=24908
Allows timeout to be set in run-webkit-tests as a command line argument.
* Scripts/run-webkit-tests:
2009-04-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Tor Arne Vestbø.
Add /Programs to the productDir for GTK+, instead of adding
/JavaScriptCore, when running jsc.
* Scripts/run-sunspider:
2009-04-04 Kevin Ollivier <kevino@theolliviers.com>
Build fixes for wxMac/Tiger and PPC builds.
* wx/build-wxwebkit:
2009-04-04 Kevin Ollivier <kevino@theolliviers.com>
wx build fix. Update the version of ICU dlls.
* wx/build-wxwebkit:
2009-04-03 Stephanie Lewis <slewis@apple.com>
Reviewed by Mark Rowe.
Fix running DumpRenderTree with a root.
* Scripts/run-webkit-tests:
2009-04-02 Adam Roben <aroben@apple.com>
Build fix for Windows machines that don't have WebKitTools/Scipts in
their PATH
* Scripts/pdevenv: Add WebKitTools/Scripts to PATH when launching
Visual Studio/VC++ Express.
2009-04-02 Adam Roben <aroben@apple.com>
Use pdevenv when building .vcproj files via our scripts
Reviewed by Mark Rowe.
* Scripts/webkitdirs.pm:
(sub buildVisualStudioProject): Use pdevenv instead of invoking Visual
Studio/VC++ Express directly.
2009-04-01 Mark Rowe <mrowe@apple.com>
Windows support for built-product-archive.
* BuildSlaveSupport/built-product-archive:
2009-03-31 Adam Roben <aroben@apple.com>
Make resolve-ChangeLogs -f work when the working tree has spaces in
its path
Reviewed by Mark Rowe and David Kilzer.
* Scripts/resolve-ChangeLogs:
(sub fixMergedChangeLogs): Quote the path to resolve-ChangeLogs in
case it contains spaces.
2009-03-31 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=24777
WebKit tools are broken on Tiger
* Scripts/webkitdirs.pm: Don't use arch command with options on Tiger.
2009-03-31 Darin Adler <darin@apple.com>
* Scripts/add-include: Added.
2009-03-31 Mark Rowe <mrowe@apple.com>
Fix use of incorrect constant.
* BuildSlaveSupport/built-product-archive:
2009-03-30 Mark Rowe <mrowe@apple.com>
Rubber-stamped by Stephanie Lewis.
Add a script in support of the new build.webkit.org configuration.
* BuildSlaveSupport/built-product-archive: Added.
2009-03-30 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
Make policy-delegate logging work even for local files by processing the URLs as we
do for other delegates.
* DumpRenderTree/mac/PolicyDelegate.mm:
(-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
Use _drt_descriptionSuitableForTestResult on the URL.
* DumpRenderTree/win/PolicyDelegate.cpp:
(PolicyDelegate::decidePolicyForNavigationAction): Use urlSuitableForTestResult on the URL.
2009-03-30 Adam Roben <aroben@apple.com>
Windows build fix
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::waitForPolicyDelegate): Added this empty stub.
* DumpRenderTree/win/WorkQueueItemWin.cpp:
(LoadItem::invoke):
(ScriptItem::invoke):
Changed to use data members instead of removed member functions.
2009-03-30 Jan Michael Alonzo <jmalonzo@webkit.org>
Gtk DRT build fix per changeset
http://trac.webkit.org/changeset/42082. Not reviewed.
* DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
(LoadItem::invoke):
(ScriptItem::invoke):
2009-03-29 Darin Adler <darin@apple.com>
* DumpRenderTree/qt/jsobjects.cpp: Rolled out changes to this file. Maybe this will fix
Qt building of DumpRenderTree.
2009-03-29 Darin Adler <darin@apple.com>
Reviewed by Cameron Zwarich.
Bug 24922: change WorkQueue-based navigation tests to not depend on synchronous form submission
https://bugs.webkit.org/show_bug.cgi?id=24922
Don't rely on delegate methods to guess whether a queued step starts a load or not, because
script-triggered loads can't be detected that way. Instead have the steps themselves indicate
whether or not a load was triggered.
* DumpRenderTree/LayoutTestController.cpp:
(queueLoadingScriptCallback): Added. Version for scripts that perform loads.
(queueNonLoadingScriptCallback): Added. Version for scripts that do not perform loads.
(LayoutTestController::staticFunctions): Replaced queueScript with queueLoadingScript and
queueNonLoadingScript.
(LayoutTestController::queueBackNavigation): Moved here since it's platform-independent now.
(LayoutTestController::queueForwardNavigation): Ditto.
(LayoutTestController::queueLoadingScript): Replacement for queueScript. Here since it's
platform-independent.
(LayoutTestController::queueNonLoadingScript): Ditto.
(LayoutTestController::queueReload): Moved here since it's platform-independent now.
* DumpRenderTree/LayoutTestController.h: Ditto.
* DumpRenderTree/WorkQueue.cpp:
(WorkQueue::processWork): Added. Shared by the different platform's work queue implementations.
* DumpRenderTree/WorkQueue.h: Ditto.
* DumpRenderTree/WorkQueueItem.h: Changed the invoke function to return true if the item
started a load. Removed unused getter functions. Made invoke functions private.
Added LoadingScriptItem and NonLoadingScriptItem, making ScriptItem an abstract base.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(processWork): Use the new WorkQueue::processWork function to implement the new rule.
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Removed queue functions that are now
platform-independent and in LayoutTestController.cpp.
* DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
(LoadItem::invoke): Return true.
(ReloadItem::invoke): Ditto.
(ScriptItem::invoke): Ditto.
(BackForwardItem::invoke): Ditto.
* DumpRenderTree/mac/FrameLoadDelegate.mm:
(-[FrameLoadDelegate processWork:]): Use the new WorkQueue::processWork function to implement
the new rule.
* DumpRenderTree/mac/LayoutTestControllerMac.mm: Removed queue functions that are now
platform-independent and in LayoutTestController.cpp.
* DumpRenderTree/mac/WorkQueueItemMac.mm:
(LoadItem::invoke): Return true.
(ReloadItem::invoke): Ditto.
(ScriptItem::invoke): Ditto.
(BackForwardItem::invoke): Ditto.
* DumpRenderTree/qt/jsobjects.cpp:
(LayoutTestController::processWork): Use the new WorkQueue::processWork function to implement
the new rule. Removed queue functions that are now platform-independent and in
LayoutTestController.cpp.
* DumpRenderTree/win/FrameLoadDelegate.cpp:
(FrameLoadDelegate::processWork): Use the new WorkQueue::processWork function to implement
the new rule.
* DumpRenderTree/win/LayoutTestControllerWin.cpp: Removed queue functions that are now
platform-independent and in LayoutTestController.cpp.
* DumpRenderTree/win/WorkQueueItemWin.cpp:
(LoadItem::invoke): Return false when we fail, true when we succeed.
(ReloadItem::invoke): Ditto.
(ScriptItem::invoke): Ditto.
(BackForwardItem::invoke): Ditto.
2009-03-28 Kevin Ollivier <kevino@theolliviers.com>
Reviewed by Eric Seidel.
Always use wxGraphicsContext on Mac to ensure path, matrix, etc. support.
* wx/build-wxwebkit:
2009-03-27 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
* Scripts/extract-localizable-strings: Fixed version check for perl 5.10 compatibility.
2009-03-27 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
Added waitForPolicyDelegate, a more-reliable way to make our mailto form submission
tests work.
* DumpRenderTree/AccessibilityController.cpp:
(getFocusedElementCallback): Use static_cast instead of reinterpret_cast because there's
no reason to use reinterpret_cast just to get from void* to a specific type.
(getRootElementCallback): Ditto.
* DumpRenderTree/AccessibilityUIElement.cpp:
(toAXElement): Ditto.
* DumpRenderTree/GCController.cpp:
(collectCallback): Ditto.
(collectOnAlternateThreadCallback): Ditto.
(getJSObjectCountCallback): Ditto.
* DumpRenderTree/LayoutTestController.cpp:
(many functions): Ditto.
(waitForPolicyDelegateCallback): Added.
(LayoutTestController::staticFunctions): Sorted functions by name.
Added waitForPolicyDelegate.
* DumpRenderTree/LayoutTestController.h: Sorted functions by name.
Added waitForPolicyDelegate.
* DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebViewToConsistentStateBeforeTesting): Added code to reset the state of the
policy delegate.
(runTest): Added an additional call to resetWebViewToConsistentStateBeforeTesting just
before loading an empty page. This prevents extra policy delegate calls from being logged.
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::waitForPolicyDelegate): Added. Puts us into wait mode, and then
tells the policy delegate to notify when done, then points the web view at the policy delegate.
* DumpRenderTree/mac/PolicyDelegate.h: Added setControllerToNotifyDone: method.
* DumpRenderTree/mac/PolicyDelegate.mm:
(-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
Added code to do notifyDone if controllerToNotifyDone is set.
(-[PolicyDelegate setControllerToNotifyDone:]): Added.
* DumpRenderTree/win/DumpRenderTree.cpp:
(resetWebViewToConsistentStateBeforeTesting): Added code to reset the state of the
policy delegate. Also moved the call to resetUndoManager in here.
(runTest): Removed the call to resetUndoManager (see above). Added an additional call to
resetWebViewToConsistentStateBeforeTesting to match the Mac code.
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setCustomPolicyDelegate): 0, not NULL.
* DumpRenderTree/win/PolicyDelegate.cpp:
(PolicyDelegate::PolicyDelegate): Initialize m_controllerToNotifyDone to 0.
(PolicyDelegate::decidePolicyForNavigationAction): Added code to do notifyDone if
m_controllerToNotifyDone is set.
* DumpRenderTree/win/PolicyDelegate.h: Added setControllerToNotifyDone and
m_controllerToNotifyDone.
2009-03-27 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough.
Fix for https://bugs.webkit.org/show_bug.cgi?id=24765
prepare-ChangeLog and svn-create-patch doesn't work with svn 1.6
* Scripts/prepare-ChangeLog:
* Scripts/svn-create-patch:
2009-03-26 Darin Adler <darin@apple.com>
Reviewed by Geoff Garen.
* Scripts/do-webcore-rename:Update for rename of JSUnprotectedEventListener to
JSEventListener.
2009-03-26 Darin Adler <darin@apple.com>
Reviewed by Geoff Garen.
* Scripts/do-webcore-rename: Update for rename of JSEventListener to
JSProtectedEventListener. This includes all the related renames, but
not that one because that one renames the file.
2009-03-26 Adam Roben <aroben@apple.com>
Reduce run-webkit-tests's time out limit to 15 seconds (or 2.5 minutes
under GuardMalloc)
The previous limit was 60 seconds (or 10 minutes under GuardMalloc).
There's no evidence that we need the limit to be this long, and having
it be so long just makes timed-out tests take forever to complete.
DRT's watchdog timer is 10 seconds, so still has time to fire before
run-webkit-tests will cut it off.
Reviewed by Simon Fraser.
* Scripts/run-webkit-tests:
(sub readFromDumpToolWithTimer): Reduced the limit to 15 seconds (or
2.5 mintues under GuardMalloc).
2009-03-26 Adam Roben <aroben@apple.com>
Make DRT's watchdog timer actually work on Windows
We were previously trying to use a CFRunLoopTimer for the watchdog
timer on Windows. This doesn't work because we don't use a CFRunLoop
on the main thread on Windows.
This patch changes the watchdog timer on Windows be a normal Windows
timer.
Reviewed by Simon Fraser.
* DumpRenderTree/DumpRenderTree.h: Moved declaration of
waitToDumpWatchdog from here...
* DumpRenderTree/mac/DumpRenderTreeMac.h: ...to here.
* DumpRenderTree/win/DumpRenderTree.cpp:
(invalidateAnyPreviousWaitToDumpWatchdog): Added. This function
cancels an existing watchdog timer.
(dump): Call invalidateAnyPreviousWaitToDumpWatchdog. This will
prevent watchdogs from previous tests firing during subsequent ones.
This matches Mac's behavior.
* DumpRenderTree/win/DumpRenderTreeWin.h: Added a declaration of
waitToDumpWatchdog.
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(waitUntilDoneWatchdogFired): Converted this to be a Windows
TIMERPROC.
(LayoutTestController::setWaitToDump): Changed to use SetTimer instead
of CFRunLoopAddTimer.
2009-03-25 Mark Rowe <mrowe@apple.com>
Rubber-stamped by Steve Falkenburg.
Update test result search path for Windows now that it has updated versions of ICU, libxml2, and friends.
* Scripts/run-webkit-tests:
2009-03-24 Mark Rowe <mrowe@apple.com>
Fix the Tiger build some more.
* DumpRenderTree/mac/TextInputController.m:
2009-03-24 Mark Rowe <mrowe@apple.com>
Fix the Tiger build.
* DumpRenderTree/mac/TextInputController.m:
2009-03-24 Mark Rowe <mrowe@apple.com>
Reviewed by Jon "The Most Boring Man in the World" Honeycutt.
Explicitly map NSNotFound to -1 so that the result of-characterIndexForPointX:Y: does
not differ between 32- and 64-bit.
* DumpRenderTree/mac/TextInputController.m:
(-[TextInputController characterIndexForPointX:Y:]):
2009-03-24 Mark Rowe <mrowe@apple.com>
Reviewed by Sam Weinig.
Use a different platform search path for tests and skip lists, so that Tiger doesn't end up
using the Leopard skip list. Tests and skip lists are now looked for in the directory for
the current OS and the generic "mac" directory. Tests and skip lists for newer OS versions are
ignored.
* Scripts/run-webkit-tests:
2009-03-23 Stephanie <slewis@apple.com>
Fix root build.
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2009-03-23 Stephanie Lewis <slewis@apple.com>
Reviewed by Mark Rowe.
Add production configuration for creating roots of WebKitTools.
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2009-03-23 Oliver Hunt <oliver@apple.com>
Reviewed by Geoff Garen.
Make testapi run as part of the standard JavaScriptCore tests.
We only run testapi on the mac as currently windows webkit doesn't
place all the necessary files for testapi, and we also test the
JSC/CF APIs as well.
* Scripts/run-javascriptcore-tests:
2009-03-21 Oliver Hunt <oliver@apple.com>
Reviewed by Mark Rowe.
Make build-jsc build testapi and minidom in addition to jsc itself.
* Scripts/build-jsc:
2009-03-20 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Only release the result NPVariant if the call to NPN_Invoke was successful.
* DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
(testNPRuntime):
2009-03-19 Gustavo Noronha Silva <gns@gnome.org>
Reviewed by Mark Rowe.
Make determinePassedArchitecture always consume the --32-bit
option, also in non-AppleMacWebkit platforms. Solution pointed out
by Mark Rowe.
* Scripts/webkitdirs.pm:
2009-03-19 Mark Rowe <mrowe@apple.com>
Reviewed by Oliver Hunt.
Work around <rdar://problem/6698023> by activating fonts from disk.
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Copy fonts into DumpRenderTree.resources
in the built products directory.
* DumpRenderTree/mac/DumpRenderTree.mm:
(activateFonts): Activate the fonts from disk.
2009-03-18 Mark Rowe <mrowe@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/6693300> Don't rely on printf from TestNetscapePlugIn appearing in test results
Switch from using printf to using the NPAPI to invoke console.log so that plug-in messages appear
in test results even when the plug-in's stdout differs from DumpRenderTree's stdout.
* DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
(log): Invoke console.log via the NPAPI.
(NPP_Destroy): Call log instead of printf.
(NPP_SetWindow): Ditto.
(handleEventCarbon): Ditto.
(handleEventCocoa): Ditto.
(NPP_HandleEvent): Pass the instance in to the event handler.
2009-03-17 Mark Rowe <mrowe@apple.com>
Reviewed by Oliver Hunt.
Use the normal search rules for tests inside the platform directory.
This allows tests inside the platform directory to have different results
on different versions of Mac OS X.
* Scripts/run-webkit-tests:
2009-03-17 David Kilzer <ddkilzer@apple.com>
resolve-ChangeLogs should not die on unmerged non-ChangeLog files
Reviewed by Adam Roben.
Fixes the following bug in resolve-ChangeLogs:
Use of uninitialized value in -e at ./WebKitTools/Scripts/resolve-ChangeLogs line 132.
Died at ./WebKitTools/Scripts/resolve-ChangeLogs line 164.
* Scripts/resolve-ChangeLogs:
(findUnmergedChangeLogs): Check the result of findChangeLog() to
make sure we don't add undef values to the list of files being
returned.
2009-03-17 Gustavo Noronha Silva <gns@gnome.org>
Reviewed by Simon Fraser.
Fix the usage of the $architecture variable for non-Apple-Mac
ports.
* Scripts/webkitdirs.pm:
2009-03-17 David Kilzer <ddkilzer@apple.com>
Bug 24645: bisect-builds script doesn't work with Safari 4 Public Beta (version string)
<https://bugs.webkit.org/show_bug.cgi?id=24645>
Reviewed by Mark Rowe.
* Scripts/bisect-builds:
(makeNightlyList): Added checks for Safari 4 Public Beta on
Tiger and Leopard.
2009-03-17 Simon Fraser <simon.fraser@apple.com>
Reviewed by Darin Adler
https://bugs.webkit.org/show_bug.cgi?id=24396
Change the terminology from '3D transforms' to '3D rendering'.
* Scripts/build-webkit:
* Scripts/run-webkit-tests:
* Scripts/webkitdirs.pm:
2009-03-17 Gustavo Noronha Silva <gns@gnome.org>
Reviewed by Mark Rowe.
Enable HTML5 media elements support by default also for the GTK+
port.
* Scripts/build-webkit:
2009-03-17 Kevin Ollivier <kevino@theolliviers.com>
Reviewed by Mark Rowe.
Tweak the BUILDING_ON_* defines so that they work with the default values set by
AvailabilityMacros.h.
https://bugs.webkit.org/show_bug.cgi?id=24630
* DumpRenderTree/mac/DumpRenderTreeMac.h:
2009-03-17 Oliver Hunt <oliver@apple.com>
Reviewed by Alexey Proskuryakov.
Make coverage testing more reliable by ensuring --coverage does not
clobber configuration settings, and by removing the unnecessary
dependency on matplotlib.
* CodeCoverage/regenerate-coverage-display:
* Scripts/webkitdirs.pm:
2009-03-16 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler and John Sullivan.
When a plug-in instance is torn down, all plug-in objects will first be invalidated and then deallocated.
Since objects can be deallocated in any order, it is not safe to call NPN_ReleaseObject on member variables.
Instead, just zero out the member variable in invalidate.
* DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
(pluginInvalidate):
(pluginDeallocate):
2009-03-16 Eric Seidel <eric@webkit.org>
Reviewed by Sam Weinig.
REGRESSION: undo-iframe-location-change.html is failing on the buildbots
https://bugs.webkit.org/show_bug.cgi?id=24626
Added a call to [[webview undoManager] removeAllActions]
to make sure anything left on the undo stack after one test
will not affect any later test.
* DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebViewToConsistentStateBeforeTesting):
2009-03-14 Mark Rowe <mrowe@apple.com>
Reviewed by Dan Bernstein.
Change the layout test result search policy for Mac OS X to fit better with the idea of
newer OS versions improving on previous OS versions.
The results for the latest version of Mac OS X are placed in the "mac" directory. The
results for older versions of Mac OS X are structured as a series of overlays. When
running on Leopard, the results in "mac-leopard" are searched before those in "mac".
When running on Tiger, the results in "mac-tiger" are searched before those in
"mac-leopard" and "mac".
* Scripts/run-webkit-tests:
2009-03-13 Mark Rowe <mrowe@apple.com>
Rubber-stamped by Dan Bernstein.
Take advantage of the ability of recent versions of Xcode to easily switch the active
architecture.
* DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2009-03-13 Mark Rowe <mrowe@apple.com>
Reviewed by Timothy Hatcher.
Remove the --64-bit argument from scripts in favor of them detecting when 64-bit should be preferred.
The scripts will automatically target 64-bit if the system and hardware support it. This can be
overridden by passing --32-bit to individual scripts, or using set-webkit-configuration --32-bit
to make the override persistent.
* Scripts/build-webkit: Remove architecture-related code.
* Scripts/gdb-safari: Remove architecture-related code, and clean up how the environment variables are passed to gdb.
* Scripts/run-javascriptcore-tests: Remove architecture-related code.
* Scripts/run-safari: Ditto.
* Scripts/run-webkit-tests: Ditto.
* Scripts/set-webkit-configuration: Handle the --32-bit and --64-bit arguments. The --32-bit argument will set the
architecture preference to the 32-bit architecture of the machine. The --64-bit argument will remove any architecture
override that is in effect so that 64-bit support will be automatically detected.
* Scripts/webkitdirs.pm: Add auto-detection of the best architecture for the machine, and the ability to override the
auto-detection.
2009-03-13 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/6610666> Revise the Cocoa event model text API
Add a case statement for NPCocoaEventTextInput.
* DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
(handleEventCocoa):
2009-03-12 Kevin Ollivier <kevino@theolliviers.com>
wx build fix. Let DerivedSources.make know we want database APIs.
* wx/build-wxwebkit:
2009-03-12 David Kilzer <ddkilzer@apple.com>
Bug 24378: resolve-ChangeLogs should use git status or svn status to find and fix unmerged ChangeLogs
<https://bugs.webkit.org/show_bug.cgi?id=24378>
Reviewed by Adam Roben.
* Scripts/resolve-ChangeLogs: If -f|--fix-merged is not passed
and no file or directory names are specified on the command-line
then try to find unmerged ChangeLog files based on 'svn stat' or
'git diff'. Added global $isGit and $isSVN variables so that
isGit() and isSVN() only have to be called once.
(findUnmergedChangeLogs): Added.
2009-03-11 David Kilzer <ddkilzer@apple.com>
Clarify comments regarding order of FEATURE_DEFINES
Rubber-stamped by Mark Rowe.
* Scripts/build-webkit: Added warning about keeping
FEATURE_DEFINES in order and the consequences when they are not.
2009-03-11 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Holger Freyther.
Gtk] Implement LayoutTestControllerGtk::setPrivateBrowsingEnabled
https://bugs.webkit.org/show_bug.cgi?id=24487
Also reset WebSettings to its default state for JavaScript
profiling, Developer Extras and Private Browsing before running
the test (can be after each test but we want to be consistent with
other ports in this regard)
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetWebViewToConsistentStateBeforeTesting):
(runTest):
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setPrivateBrowsingEnabled):
2009-03-11 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Holger Freyther.
[GTK]DumpRenderTree doesn't compile for non-X11 GTK ports anymore
https://bugs.webkit.org/show_bug.cgi?id=2260
Add plugin support only for X11 builds
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(setDefaultsToConsistentStateValuesForTesting):
* GNUmakefile.am:
2009-03-08 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Mark Rowe.
Implement setJavaScriptProfilingEnabled by enabling the Developer
Extras and the JavaScript profiling on the WebKitWebInspector. After
this change we pass the three enabled tests in fast/profiler.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(runTest): Reset setJavaScriptProfilingEnabled after each test run
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setJavaScriptProfilingEnabled):
2009-03-07 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Holger Freyther.
[Gtk] Enable http history tests
https://bugs.webkit.org/show_bug.cgi?id=24394
Get the index of the current item from the list of (history) items
to print before adding the back history items to the list. This
will make the 'curr' pointer point to the correct item in the
actual results, therefore, passing some of the http/tests/history
tests.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(dumpBackForwardListForWebView):
2009-03-06 Adam Treat <adam.treat@torchmobile.com>
Reviewed by George Staikos.
When building QtWebKit in release mode make sure that QT_SHARED is defined
otherwise none of the public API will be exported. This leads to missing
symbols and link errors if hidden-visibility is used.
* Scripts/webkitdirs.pm:
2009-03-06 Adam Roben <aroben@apple.com>
Change the isCygwin check in update-webkit to isAppleWinWebKit
This matches a similar check in build-webkit, and is more correct.
Reviewed by Alexey Proskuryakov.
* Scripts/update-webkit: Only call update-webkit-auxiliary-libs if
isAppleWinWebKit is true.
2009-03-06 Adam Roben <aroben@apple.com>
Make update-webkit-support-libs fail if WebKitSupportLibrary.zip is
present but out of date
Reviewed by Alexey Proskuryakov.
* Scripts/update-webkit-support-libs: Changed to use
dieAndInstructToDownload when the zip file doesn't exist. Added an MD5
check to make sure the file is up-to-date. If it is out of date, print
an error message and quit.
(sub dieAndInstructToDownload): Added. Prints an error message and
quits with an error.
2009-03-03 Anders Carlsson <andersca@apple.com>
Reviewed by John Sullivan.
https://bugs.webkit.org/show_bug.cgi?id=22884
<rdar://problem/6449783>
modified layout test crashes Safari
Add destroyNullStream test function to the test plug-in.
* DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
(destroyNullStream):
(pluginInvoke):
2009-03-03 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler
Support layout test covering <rdar://problem/6616664>
Change NSURLRequest/IWebURLRequest dumping to include the mainDocumentURL
* DumpRenderTree/mac/ResourceLoadDelegate.mm:
(-[NSURLRequest _drt_descriptionSuitableForTestResult]): Return both the request URL and the
mainDocumentURL.
* DumpRenderTree/win/ResourceLoadDelegate.cpp:
(descriptionSuitableForTestResult): Return both the request URL and the mainDocumentURL.
2009-03-02 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Enable Geolocation (except on Tiger and Leopard).
* Scripts/build-webkit:
2009-03-02 Kevin Ollivier <kevino@theolliviers.com>
Build fixes for wxWidgets Mac trunk build.
* wx/build-wxwebkit:
2009-03-02 Timothy Hatcher <timothy@apple.com>
Allow for multiline quoted text in JavaScript files when looking for function names.
https://bugs.webkit.org/show_bug.cgi?id=24296
Reviewed by David Kilzer.
* Scripts/prepare-ChangeLog:
2009-03-02 Adam Treat <adam.treat@torchmobile.com>
Reviewed by Eric Seidel.
Add three new drt helper functions that enable all of the tests in
LayoutTests/animation/* and LayoutTests/transitions/* to now pass.
* DumpRenderTree/qt/jsobjects.cpp:
(LayoutTestController::pauseAnimationAtTimeOnElementWithId):
(LayoutTestController::pauseTransitionAtTimeOnElementWithId):
(LayoutTestController::numberOfActiveAnimations):
* DumpRenderTree/qt/jsobjects.h:
2009-03-02 Adam Roben <aroben@apple.com>
Windows build fix after r41349
* DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::getChildrenWithRange):
2009-03-01 Chris Fleizach <cfleizach@apple.com>
Reviewed by Oliver Hunt.
Bug 24282: AX Palindrome error when asking for a specific index of the AXChildren array
Change getChildAtIndex() to get a range of children instead of all the children.
This exercises code in WebCore that returns elements when asked for from a range.
* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::getChildrenWithRange):
(AccessibilityUIElement::getChildAtIndex):
* DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::getChildrenWithRange):
2009-03-01 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Holger Freyther.
[Gtk] get the HTTP layout tests going
https://bugs.webkit.org/show_bug.cgi?id=24259
Determine the frame's response and decide whether to dump as text
or the render tree
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(dump):
2009-03-01 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Holger Freyther.
[Gtk] get the HTTP layout tests going
https://bugs.webkit.org/show_bug.cgi?id=24259
Implement dumping of WebKitWebBackForwardList and its history
items.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(compareHistoryItems):
(dumpHistoryItem):
(dumpBackForwardListForWebView):
(dump):
(runTest):
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::clearBackForwardList):
* DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
(BackForwardItem::invoke):
2009-02-28 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Holger Freyther.
Set the resolution for the default screen to 72.0.
This way, setting font sizes results in expected values.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(setDefaultsToConsistentStateValuesForTesting):
2009-02-28 Gustavo Noronha Silva <gns@gnome.org>
Reviewed by Holger Freyther.
Adds a WebKitMakeArguments environment variable to enable passing
of arguments such as '-j2' to make for the autotools build.
* Scripts/webkitdirs.pm:
2009-02-28 Gustavo Noronha Silva <gns@gnome.org>
Reviewed by Holger Freyther.
Add a GTK+-only option to enable GNOME Keyring when building.
* Scripts/build-webkit:
2009-02-28 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Holger Freyther.
[Gtk] webkitdirs.pm modify path in when detecting 3D transforms and accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=24076
Refactor gtk lib detection and put it in builtDylibPathForName
* Scripts/webkitdirs.pm:
2009-02-28 Christian Dywan <christian@twotoasts.de>
Rubber-stamped by Holger Freyther.
* GtkLauncher/main.c:
(activate_uri_entry_cb):
(main): Use the new webkit_web_view_load_uri to open URIs.
2009-02-27 Xan Lopez <xan@gnome.org>
Rubber-stamped by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=24222
[GTK] Remove checks for old glib versions
libsoup, which is a hard dependency, needs at least glib 2.15.3,
so remove all glib checks for versions older than that.
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setWaitToDump):
2009-02-25 Simon Fraser <simon.fraser@apple.com>
Reviewed by Eric Seidel
Fix spew about a WebView being deallocated while key value observers are
still registered with it by making sure that we always stop observing
_isUsingAcceleratedCompositing in -[DumpRenderTreeWindow close].
* DumpRenderTree/mac/DumpRenderTree.mm:
(dumpRenderTree):
* DumpRenderTree/mac/DumpRenderTreeWindow.mm:
(-[DumpRenderTreeWindow close]):
2009-02-25 Adam Treat <adam.treat@torchmobile.com>
Reviewed by Alexey Proskuryakov.
Do not queue the calls to 'DumpRenderTree::dump()' as this can result
in more than one call as a test that calls 'notifyDone()' can then be
subsequently fully loaded and initiate a second dump. Also make sure
to stop any existing page load that is happening before running the next
test. Combined this serves to produce 217 more passing tests for the
Qt port or roughly 5% at this point.
* DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::DumpRenderTree::DumpRenderTree):
(WebCore::DumpRenderTree::open):
2009-02-25 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein
https://bugs.webkit.org/show_bug.cgi?id=23854
Have the DumpRenderTreeWindow observe the -_isUsingAcceleratedCompositing
property of the WebView, and use that to turn -autodisplay on and off.
This is necessary so that accelerated animations start correctly.
We can thus remove the -display hack in createBitmapContextFromWebView().
* DumpRenderTree/mac/DumpRenderTree.mm:
(createWebViewAndOffscreenWindow):
(dumpRenderTree):
* DumpRenderTree/mac/DumpRenderTreeWindow.h:
* DumpRenderTree/mac/DumpRenderTreeWindow.mm:
(-[DumpRenderTreeWindow close]):
(-[DumpRenderTreeWindow webView]):
(-[DumpRenderTreeWindow startObservingWebView]):
(-[DumpRenderTreeWindow stopObservingWebView]):
(-[DumpRenderTreeWindow observeValueForKeyPath:ofObject:change:context:]):
* DumpRenderTree/mac/PixelDumpSupportMac.mm:
(createBitmapContextFromWebView):
2009-02-25 Adam Treat <adam.treat@torchmobile.com>
Reviewed by Zack Rusin.
https://bugs.webkit.org/show_bug.cgi?id=24158
Implement the queue*() methods of the layoutTestController and begin
implementing the dump of the back/forward list. This results in 2% more
tests passing as well as 23 currently skipped tests now passing.
* DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::DumpRenderTree::dumpBackForwardList):
(WebCore::DumpRenderTree::dump):
* DumpRenderTree/qt/DumpRenderTree.h:
* DumpRenderTree/qt/DumpRenderTree.pro:
* DumpRenderTree/qt/jsobjects.cpp:
(findFrameNamed):
(LoadItem::invoke):
(ReloadItem::invoke):
(ScriptItem::invoke):
(BackForwardItem::invoke):
(LayoutTestController::reset):
(LayoutTestController::processWork):
(LayoutTestController::maybeDump):
(LayoutTestController::queueBackNavigation):
(LayoutTestController::queueForwardNavigation):
(LayoutTestController::queueLoad):
(LayoutTestController::queueReload):
(LayoutTestController::queueScript):
* DumpRenderTree/qt/jsobjects.h:
(LayoutTestController::shouldDumpBackForwardList):
(LayoutTestController::dumpBackForwardList):
2009-02-24 Adam Treat <adam.treat@torchmobile.com>
Reviewed by Alexey Proskuryakov.
Don't print out that you are generating new results if you are not in fact
generating new results and disable generating new results by default for
the all ports other than the canonical Apple Mac port since this can litter
the source directory with hundreds of new results since other ports
are not as up to date.
* Scripts/run-webkit-tests:
2009-02-24 Adam Treat <adam.treat@torchmobile.com>
Reviewed by Cameron Zwarich.
The Qt port does not support these yet nor does the nm check work with
QMake based build.
* Scripts/webkitdirs.pm:
2009-02-24 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Alexey Proskuryakov.
[Gtk] add options for 3D transforms and HTML5 channel messaging to the build
https://bugs.webkit.org/show_bug.cgi?id=24072
Allow toggling of 3D transforms and HTML5 channel messaging
support for the Autotools (Gtk) build.
Also add '--gtk' in the build-webkit help doc and fix autotools
option for web-workers support.
* Scripts/build-webkit:
2009-02-23 Xan Lopez <xan@gnome.org>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=22624
[SOUP][GTK] Need API to get SoupSession from WebKit.
Add soup flags now that dependency is explicit.
* GNUmakefile.am:
2009-02-22 Mark Rowe <mrowe@apple.com>
Reviewed by Oliver Hunt.
Fix assertion failures in editing/pasteboard/paste-RTFD.html and editing/pasteboard/paste-TIFF.html in 64-bit.
* DumpRenderTree/mac/DumpRenderTree.mm:
(swizzleAllMethods): When adding a new method to a class, use the implementation and type of the new method rather
than of an arbitrary existing method on the class.
2009-02-13 Eric Seidel <eric@webkit.org>
Rubber-stamped by Alexey Proskuryakov.
Add a few ignores to make-js-test-wrappers.
* Scripts/make-js-test-wrappers:
2009-02-17 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Alexey Proskuryakov.
Prepend file:// to the test result filename to make
GtkLauncher display the result page.
* Scripts/run-webkit-tests:
2009-02-16 Gustavo Noronha Silva <gns@gnome.org>
Reviewed by Adam Roben
Actually use the installation prefix defined in WebKitInstallationPrefix,
in autotools builds.
* Scripts/webkitdirs.pm:
2009-02-12 Simon Fraser <simon.fraser@apple.com>
No review.
Remove debugging code which was committed by mistake.
* Scripts/run-webkit-tests:
2009-02-12 Simon Fraser <simon.fraser@apple.com>
Reviewed by Adam Roben
https://bugs.webkit.org/show_bug.cgi?id=23928
Add detection of accelerated compositing and 3d transforms,
and add various directories to $ignoredDirectories when these
features are off.
* Scripts/run-webkit-tests:
* Scripts/webkitdirs.pm:
2009-02-12 Adam Roben <aroben@apple.com>
Fix Bug 23922: Warning message from run-webkit-tests when Skipped file
contains non-existent tests is confusing and is given for disabled
tests
<https://bugs.webkit.org/show_bug.cgi?id=23922>
We now no longer warn about disabled tests. The warning now reads:
Skipped list contained '$item', but no file of that name could be
found
Reviewed by John Sullivan.
* Scripts/run-webkit-tests:
(top level): Pass the list name to processIgnoreTests so it can print
out a reasonable warning message.
(processIgnoreTests): Take a list name as a second parameter and use
it to display a better warning message. Also check for a "-disabled"
version of the test before warning about it not existing.
2009-02-11 Adam Roben <aroben@apple.com>
Windows fix for Bug 22239: Implement missing animation & transition
APIs on LayoutTestController for non-mac platforms
<https://bugs.webkit.org/show_bug.cgi?id=22239>
Reviewed by Simon Fraser.
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::pauseAnimationAtTimeOnElementWithId):
(LayoutTestController::pauseTransitionAtTimeOnElementWithId):
(LayoutTestController::numberOfActiveAnimations):
Implemented these by calling through to IWebFramePrivate.
2009-02-10 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
* Scripts/build-webkit:
https://bugs.webkit.org/show_bug.cgi?id=23883
Added support --3d-transforms. Defaults to off
2009-02-11 Adam Roben <aroben@apple.com>
Fix crashes in http/tests/history/redirect-301.pl and friends on
Windows
Reviewed by Alexey Proskuryakov.
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::webHistoryItemCount): Null-check the shared
WebHistory instance before dereferencing it.
2009-02-10 Adam Roben <aroben@apple.com>
Fix Bug 23869: Pixel tests can't be run on Windows
<https://bugs.webkit.org/show_bug.cgi?id=23869>
This patch gets the pixel tests limping along on Windows again.
Reviewed by Dan Bernstein.
* DumpRenderTree/DumpRenderTree.sln: Changed to use the new
Debug_Internal configuration of ImageDiff in the Debug_Internal
configuration of this solution.
* DumpRenderTree/cg/PixelDumpSupportCG.cpp:
(printPNG): Changed to call fwrite in a loop, since this call was
failing due to the buffer being too large on Windows.
(dumpWebViewAsPixelsAndCompareWithExpected): Removed an unnecessary
#if PLATFORM(MAC)/#endif.
* DumpRenderTree/win/ImageDiff.vcproj: Added a Debug_Internal
configuration that matches the Debug configuration but also references
debug_internal.vsprops.
* DumpRenderTree/win/PixelDumpSupportWin.cpp:
(createBitmapContextFromWebView): Renamed from
getBitmapContextFromWebView to match the name used in the
cross-platform code.
2009-02-10 Adam Roben <aroben@apple.com>
Robustify DumpRenderTree/win a little
DumpRenderTree was previously not holding a ref to the WebViews it
created via window.open. It was getting away with this because
WebViews get reffed by being preference notification observers and by
registering for drag-n-drop messages. Now DRT does hold a ref, in case
this situation changes in the future.
Reviewed by Alexey Proskuryakov.
* DumpRenderTree/win/DumpRenderTree.cpp:
(dumpBackForwardListForAllWindows): Added a .get().
(windowToWebViewMap): Changed to use the WindowToWebViewMap typedef.
* DumpRenderTree/win/DumpRenderTreeWin.h: Changed the
windowToWebViewMap() to hold a ref to the WebViews it contains.
2009-02-05 Simon Fraser <simon.fraser@apple.com>
Fix the #include file order, per review comments.
* DumpRenderTree/mac/PixelDumpSupportMac.mm:
2009-02-05 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein
https://bugs.webkit.org/show_bug.cgi?id=23362
If the WebHTMLView uses accelerated compositing, we need for force
the on-screen capture path and also force animations to start with -display
since the DRT window has autodisplay disabled.
* DumpRenderTree/mac/PixelDumpSupportMac.mm:
(createBitmapContextFromWebView):
2009-02-03 miggilin <mr.diggilin@gmail.com>
Reviewed by Darin Adler.
Change the way wxWidgets build gets arguments.
Change "checkForArgumentAndRemoveFromARGV" in build-webkit to check if the
argument passed matches one in ARGV exactly (allows, ie, --wx-args not to be
removed when --wx is checked for).
https://bugs.webkit.org/show_bug.cgi?id=23701
* Scripts/build-webkit:
* Scripts/webkitdirs.pm:
2009-01-30 Chris Fleizach <cfleizach@apple.com>
Reviewed by Oliver Hunt.
Catch exceptions thrown by AppKit when accessing an attribute than an element
doesn't return.
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(attributesOfElement):
2009-01-29 David Kilzer <ddkilzer@apple.com>
Remove semi-colons from the end of ObjC method implementations
Rubber-stamped by Adam Roben.
$ find WebKitTools -name \*.m -o -name \*.mm -exec perl -e 'undef $/; $s = <>; while ($s =~ m/[\n\r][-+].*;[\s\r\n]+\{/g) { print "$ARGV: $&\n"; }' {} \;
* DumpRenderTree/mac/FrameLoadDelegate.mm:
(-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
(-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
(-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
(-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
* DumpRenderTree/mac/UIDelegate.mm:
(-[UIDelegate webViewFrame:]):
2009-01-28 Geoffrey Garen <ggaren@apple.com>
Build fix for GTK.
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::webHistoryItemCount):
2009-01-28 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Added support for querying how many history items were created during a
layout test.
* DumpRenderTree/LayoutTestController.cpp:
(getWebHistoryItemCountCallback):
(LayoutTestController::staticValues):
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::webHistoryItemCount):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::webHistoryItemCount):
2009-01-26 Pierre-Olivier Latour <pol@apple.com>
Tweaked again earlier fix, this time just to print a warning and not abort if
attempting to generate pixel results and Perian is installed.
https://bugs.webkit.org/show_bug.cgi?id=22615
* Scripts/run-webkit-tests:
2009-01-26 Christian Dywan <christian@twotoasts.de>
Rubber stamped by Holger Freyther.
* GtkLauncher/main.c:
(main): Initialize threads, which is required for libSoup.
2009-01-23 David Kilzer <ddkilzer@apple.com>
* Scripts/do-webcore-rename: Removed 10 header guard renames that
had already been fixed, and updated 4 renames whose original values
had changed.
2009-01-22 Anders Carlsson <andersca@apple.com>
Fix Windows build.
* DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
2009-01-22 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Clean up the test plug-in code. We now always use the CG drawing model and the
Cocoa event model. It is however possible to revert to the old Carbon event model by
specifying forcecarbon=true in the embed/object tag.
* DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
* DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
(NPP_New):
(handleEventCarbon):
(handleEventCocoa):
(NPP_HandleEvent):
2009-01-21 Pierre-Olivier Latour <pol@apple.com>
Tweaked earlier fix to only print a warning when Perian is installed,
and fail completely only if attempting to generate new pixel test results.
https://bugs.webkit.org/show_bug.cgi?id=23392
* Scripts/run-webkit-tests:
2009-01-20 Darin Adler <darin@apple.com>
Reviewed by Alexey Proskuryakov.
Bug 23450: string leaks seen in DumpRenderTree accessibility test code
https://bugs.webkit.org/show_bug.cgi?id=23450
* DumpRenderTree/AccessibilityUIElement.cpp:
(isAttributeSettableCallback): Add the missing JSStringRelease call.
(attributeValueCallback): Ditto.
2009-01-20 Pierre-Olivier Latour <pol@apple.com>
Reviewed by Darin Adler.
Print warning regarding display color profile change in run-webkit-tests instead of DRT.
https://bugs.webkit.org/show_bug.cgi?id=23392
* DumpRenderTree/mac/PixelDumpSupportMac.mm:
(setupMainDisplayColorProfile):
* Scripts/run-webkit-tests:
2009-01-20 Pierre-Olivier Latour <pol@apple.com>
Reviewed by Darin Adler.
Changed run-webkit-tests to abort on the Mac if pixel tests are enabled and Perian is installed,
in order to avoid result differences in some media tests.
https://bugs.webkit.org/show_bug.cgi?id=22615
* Scripts/run-webkit-tests:
* Scripts/webkitdirs.pm:
2009-01-19 Sam Weinig <sam@webkit.org>
* Scripts/do-webcore-rename: Add JSValuePtr and ProtectedJSValuePtr.
2009-01-16 Gabor Loki <loki@inf.u-szeged.hu>
Reviewed by Darin Adler.
* Scripts/webkitdirs.pm: Added '--makeargs' parameter which can pass additional
parameters to make command in QMake projects.
2009-01-16 Chris Fleizach <cfleizach@apple.com>
Reviewed by Beth Dakin.
Add AX methods to retrieve the parent of an element.
* DumpRenderTree/AccessibilityUIElement.cpp:
(parentElementCallback):
(AccessibilityUIElement::getJSClass):
* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::parentElement):
* DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::parentElement):
2009-01-16 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Roben.
Set the count to the right number of elements.
* DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
(testEnumerate):
2009-01-14 David Kilzer <ddkilzer@apple.com>
BUILD FIX: Use COM API on Windows in LayoutTestController::setIconDatabaseEnabled()
Rubber-stamped by Alice Liu.
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setIconDatabaseEnabled): Use COM API
to get the shared WebIconDatabase.
2009-01-14 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by Eric Seidel.
<https://bugs.webkit.org/show_bug.cgi?id=16829>
Implement NPN_SetException()
* DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
(pluginInvoke):
* DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
(initializeIdentifiers):
(testHasMethod):
(testInvoke):
2009-01-13 Dmitry Titov <dimich@chromium.org>
Reviewed by David Kilzer.
https://bugs.webkit.org/show_bug.cgi?id=23304
Fix svn-apply to match svn-unapply to recognize added files in 'git diff' patches.
* Scripts/svn-apply: Added a check (similar to svn-unapply) to recognize added files.
2009-01-14 David Kilzer <ddkilzer@apple.com>
BUILD FIX: Implement LayoutTestController::setIconDatabaseEnabled(bool) for GTK
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(runTest): Added call to reset the icon database to match Mac
and Windows ports.
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setIconDatabaseEnabled): Implemented
stub method.
2009-01-14 David Kilzer <ddkilzer@apple.com>
Bug 22795: favicons should be saved to webarchives
<https://bugs.webkit.org/show_bug.cgi?id=22795>
Reviewed by Darin Adler.
* DumpRenderTree/LayoutTestController.cpp:
(setIconDatabaseEnabledCallback): Added.
(setJavaScriptProfilingEnabledCallback): Realphabetized.
(LayoutTestController::staticFunctions): Added entry for calling
LayoutTestController.setIconDatabaseEnabled(bool) from JavaScript.
* DumpRenderTree/LayoutTestController.h:
(setIconDatabaseEnabledCallback): Added declaration.
(setJavaScriptProfilingEnabledCallback): Realphabetized.
* DumpRenderTree/mac/DumpRenderTree.mm:
(runTest): Disable the icon database before each test.
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setIconDatabaseEnabled): Added.
(LayoutTestController::setJavaScriptProfilingEnabled): Realphabetized.
* DumpRenderTree/win/DumpRenderTree.cpp:
(runTest): Disable the icon database before each test.
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setIconDatabaseEnabled): Added.
2009-01-14 Steve Falkenburg <sfalken@apple.com>
Update copyright year in version resources.
Reviewed by Adam Roben.
* DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc:
2009-01-14 Dan Bernstein <mitz@apple.com>
Reviewed by John Sullivan.
- update copyright
* DumpRenderTree/TestNetscapePlugIn.subproj/Info.plist:
* WebKitLauncher/Info.plist:
2009-01-13 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add NPRuntime test.
* DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
(testNPRuntime):
* DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
* DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
(NPP_New):
(NPP_GetValue):
2009-01-12 Mark Rowe <mrowe@apple.com>
Use the modern spelling of WebKit.
* Scripts/find-extra-includes:
* Scripts/report-include-statistics:
* Scripts/run-webkit-app:
* Scripts/svn-unapply:
* Scripts/update-webkit:
2009-01-11 Darin Adler <darin@apple.com>
* Scripts/make-js-test-wrappers: Updated so it won't overwrite tests in the svg/dom
directory that aren't using standard wrappers.
2009-01-11 Robert Blaut <webkit@blaut.biz>
Reviewed by Eric Seidel.
<https://bugs.webkit.org/show_bug.cgi?id=23134>
Update bisect-builds for Safari 3.2 to prevent crashes
* Scripts/bisect-builds: Added Safari 3.2 and the corresponding minimal revision, r37348.
2009-01-08 Adam Treat <adam.treat@torchmobile.com>
Reviewed by Simon Hausmann.
Explicitly set these so that the layout tests do not break.
* DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::WebPage::WebPage):
2009-01-07 Glenn Wilson <gwilson@chromium.org>
Reviewed by Eric Seidel.
Changed DumpRenderTree to re-enable Javascript in web preferences on every test.
This fixes the case when a user mistakenly disables Javascript, and all layout tests crash.
* DumpRenderTree/mac/DumpRenderTree.mm:
(testStringByEvaluatingJavaScriptFromString):
(setDefaultsToConsistentValuesForTesting):
2009-01-07 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Maciej Stachowiak.
Implement numberOfActiveAnimations to fix the build
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::numberOfActiveAnimations):
2009-01-07 Adam Treat <adam.treat@torchmobile.com>
Reviewed by George Staikos.
Fix unused variable warnings
* DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::WebPage::javaScriptAlert):
(WebCore::WebPage::javaScriptConfirm):
(WebCore::WebPage::javaScriptPrompt):
* DumpRenderTree/qt/jsobjects.cpp:
(LayoutTestController::maybeDump):
* DumpRenderTree/qt/main.cpp:
(get_backtrace):
* DumpRenderTree/qt/testplugin.cpp:
(TestPlugin::create):
2009-01-06 Pierre-Olivier Latour <pol@apple.com>
Reviewed by Darin Adler.
Added new JS API numberOfActiveAnimations() that returns the number of active CSS transitions & animations.
This effectively exposes the new AnimationController::numberOfActiveAnimations() API from WebCore.
https://bugs.webkit.org/show_bug.cgi?id=23126
* DumpRenderTree/LayoutTestController.cpp:
(numberOfActiveAnimationsCallback):
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::numberOfActiveAnimations):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::numberOfActiveAnimations):
2009-01-04 David Kilzer <ddkilzer@apple.com>
Don't install internal headers in WebKit framework
Reviewed by Darin Adler.
Since WebHTMLRepresentationInternal.h and WebTypesInternal.h are
no longer installed in WebKit.framework/PrivateHeaders, use the
special relationship of DumpRenderTree within the WebKit source
tree to include the internal headers through relative paths.
Created the concept of mac/InternalHeaders to hide the ugly
paths.
* DumpRenderTree/mac/Configurations/Base.xcconfig: Added
mac/InternalHeaders to HEADER_SEARCH_PATHS.
* DumpRenderTree/mac/InternalHeaders/WebKit/WebHTMLRepresentationInternal.h: Added.
* DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h: Added.
2009-01-02 Adam Treat <treat@kde.org>
Reviewed by George Staikos.
Add support for fixedLayoutSize to the qt DRT
* DumpRenderTree/qt/jsobjects.cpp:
(LayoutTestController::setFixedLayoutSize):
(LayoutTestController::setUseFixedLayout):
* DumpRenderTree/qt/jsobjects.h:
2009-01-03 David D. Kilzer <ddkilzer@webkit.org>
Bug 23091: Some webarchive http tests intermittently fail due to Connection/Keep-Alive header differences
<https://bugs.webkit.org/show_bug.cgi?id=23091>
Reviewed by Darin Adler.
* DumpRenderTree/mac/DumpRenderTree.mm:
(normalizeHTTPResponseHeaderFields): Remove Keep-Alive and
Connection headers from webarchive results.
2008-12-31 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=22812
Prevent TestNetscapePlugin from installing system-wide.
* GNUmakefile.am:
2008-12-31 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=22842
Move WebKitWebView's size allocation into a proper place.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(dump):
(runTest):
2008-12-24 Mark Rowe <mrowe@apple.com>
Reviewed by Timothy Hatcher.
Move the guts of determineCurrentSVNRevision to VCSUtils as svnRevisionForDirectory,
and make it work for git too.
* Scripts/VCSUtils.pm:
* Scripts/webkitdirs.pm:
2008-12-22 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
Reviewed by George Staikos.
Ignore http/tests/wml, if no WML support is present.
Add http/tests/wml to list of HTTP tests, allowed to access local resources.
* Scripts/run-webkit-tests:
2008-12-19 David Levin <levin@chromium.org>
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=22930
Make the git diff command used for preparing the change log avoid using any external diff tools.
* Scripts/prepare-ChangeLog:
2008-12-19 Gustavo Noronha Silva <gns@gnome.org>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=22686
Added files which were missing from the TestNetscapePlugin
directory to the SOURCES variable, so that they will be
distributed in a make dist.
* GNUMakefile.am:
2008-12-18 Cameron Zwarich <zwarich@apple.com>
Reviewed by Geoff Garen.
Add tests for bug 21855: REGRESSION (r37323): Gmail complains about popup blocking when opening a link
<https://bugs.webkit.org/show_bug.cgi?id=21855>
<rdar://problem/6278244>
Add support for scheduling asynchronous clicks to DumpRenderTree, but
only on the Mac.
* DumpRenderTree/mac/EventSendingController.h:
* DumpRenderTree/mac/EventSendingController.mm:
(+[EventSendingController isSelectorExcludedFromWebScript:]): Expose
scheduleAsynchronousClick to JavaScript.
(-[EventSendingController scheduleAsynchronousClick]): Add.
2008-12-15 Darin Adler <darin@apple.com>
* Scripts/make-js-test-wrappers: Added another exception to avoid overwriting
a custom-written test.
2008-12-15 Simon Hausmann <hausmann@webkit.org>
Reviewed by Holger Freyther.
Implement setJavaScriptProfilingEnabled in the Qt DRT to pass fast/profiler.
* DumpRenderTree/qt/jsobjects.cpp:
(LayoutTestController::setJavaScriptProfilingEnabled):
* DumpRenderTree/qt/jsobjects.h:
2008-12-13 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22039
Implement animation and transition pausing.
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::pauseAnimationAtTimeOnElementWithId):
(LayoutTestController::pauseTransitionAtTimeOnElementWithId):
2008-12-12 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=22809
Increase timeout in call to initWithURL so that people actually see
new web pages when they type URLs rather than a blank screen.
* WinLauncher/WinLauncher.cpp:
(loadURL): Increase timeout in initWithURL from 0 to 60 seconds.
2008-12-12 Darin Adler <darin@apple.com>
* Scripts/do-webcore-rename: Add a renaming idea.
2008-12-12 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Simon Hausmann.
Update the WebKit.qrc and add a script to automatically generate the file.
With the way rcc and qmake work this can not be done at build time
as the WebKit.qrc must sit inside the directory that contains the files
and at build time we may not change the content of the source directory.
* Scripts/generate-qt-inspector-resource: Added.
2008-12-11 Cameron Zwarich <zwarich@apple.com>
Rubber-stamped by Mark Rowe.
Roll out r39212 due to assertion failures during layout tests, multiple
layout test failures, memory leaks, and obvious incorrectness.
* DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebViewToConsistentStateBeforeTesting):
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
* DumpRenderTree/win/DumpRenderTree.cpp:
(resetWebViewToConsistentStateBeforeTesting):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::pauseTransitionAtTimeOnElementWithId):
2008-12-10 Glenn Wilson <gwilson@google.com>
Reviewed by Adam Roben.
Changed LayoutTestController and DumpRenderTree to allow for manual
overriding of default preferences at test time. Also added support for
resetting the preferences after each test.
https://bugs.webkit.org/show_bug.cgi?id=20534
* DumpRenderTree/LayoutTestController.cpp: Added callback method for overriding preferences
* DumpRenderTree/LayoutTestController.h: Added signature for callback
* DumpRenderTree/win/DumpRenderTree.cpp: Added calls to reset preferences after each test if necessary
* DumpRenderTree/win/LayoutTestControllerWin.cpp: Added JS override function
* DumpRenderTree/mac/DumpRenderTree.mm: Added calls to reset preferences after each test if necessary
* DumpRenderTree/mac/LayoutTestControllerMac.mm: Added JS override function
2008-12-10 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler.
Implement the new policy delegate (including navigation type and permissive mode) for DRT/win
* DumpRenderTree/win/DumpRenderTree.cpp:
* DumpRenderTree/win/DumpRenderTreeWin.h:
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setCustomPolicyDelegate):
* DumpRenderTree/win/PolicyDelegate.cpp:
(PolicyDelegate::PolicyDelegate):
(PolicyDelegate::decidePolicyForNavigationAction):
* DumpRenderTree/win/PolicyDelegate.h:
(PolicyDelegate::setPermissive):
2008-12-10 Brady Eidson <beidson@apple.com>
Reviewed by Darin
Change the custom policy delegate to actually allow navigation for tests that need it.
The new behavior is opt-in and doesn't require any changes in old tests.
* DumpRenderTree/LayoutTestController.cpp:
(setCustomPolicyDelegateCallback): Allow for a second boolean argument to set the permissive flag on the custom
policy delegate, which will be false by default to maintain original behavior.
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setCustomPolicyDelegate):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setCustomPolicyDelegate): Partially stubbed out for now.
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setCustomPolicyDelegate): Still stubbed out, but with new param.
* DumpRenderTree/mac/PolicyDelegate.h:
* DumpRenderTree/mac/PolicyDelegate.mm:
(-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]): If the permissive flag
is set, allow the navigation.
(-[PolicyDelegate setPermissive:]): Change the behavior between "use" and "ignore" - allowing navigation or not.
2008-12-09 Mark Rowe <mrowe@apple.com>
Rubber-stamped by Ada Chan.
Fix gdb-safari on Tiger.
gdb on Tiger does not take the -arch flag, so do not pass it.
* Scripts/gdb-safari:
2008-12-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
Reviewed by Alexey Proskuryakov.
Ignore WML tests, if no WML support available.
* Scripts/run-webkit-tests:
2008-12-08 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Added a shortcut for --jsDriver-args, which I use a lot.
* Scripts/run-javascriptcore-tests:
2008-12-08 Stephanie Lewis <slewis@apple.com>
Fix Tiger build.
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
2008-12-08 Darin Adler <darin@apple.com>
Reviewed by John Sullivan.
- test machinery for https://bugs.webkit.org/show_bug.cgi?id=22409
REGRESSION: cmd-shift-left/right don't switch tabs, instead select text
* DumpRenderTree/LayoutTestController.cpp:
(isCommandEnabledCallback): Added.
(LayoutTestController::staticFunctions): Added "isCommandEnabled".
* DumpRenderTree/LayoutTestController.h: Ditto.
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::isCommandEnabled): Ditto.
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(-[CommandValidationTarget initWithAction:]): Added. Used to get the
command validation system to tell us if a comment is enabled.
(-[CommandValidationTarget action]): Ditto.
(-[CommandValidationTarget tag]): Ditto.
(LayoutTestController::isCommandEnabled): Ditto.
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::isCommandEnabled): Ditto.
2008-12-08 David Kilzer <ddkilzer@apple.com>
Bug 22555: Sort "children" sections in Xcode project files
<https://bugs.webkit.org/show_bug.cgi?id=22555>
Reviewed by Eric Seidel.
* DrawTest/DrawTest.xcodeproj/project.pbxproj: Sorted.
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Sorted.
* WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj: Sorted.
2008-12-08 David Kilzer <ddkilzer@apple.com>
Bug 22555: Sort "children" sections in Xcode project files
<https://bugs.webkit.org/show_bug.cgi?id=22555>
Reviewed by Timothy Hatcher.
* Scripts/sort-Xcode-project-file: By popular request, don't sort
the mainGroup in the project (the list of items below the top-level
project file).
2008-12-05 David Kilzer <ddkilzer@apple.com>
Bug 22555: Sort "children" sections in Xcode project files
<https://bugs.webkit.org/show_bug.cgi?id=22555>
Reviewed by Darin Adler.
Sort "children" sections alphabetically, moving groups (folders) to
the top of each of the lists. Files are assumed to have extensions,
so %isFile is used to override this behavior.
* Scripts/sort-Xcode-project-file:
(sortChildrenByFileName): Added.
(sortFilesByFileName): Renamed from sortByFileName().
2008-12-05 Eric Seidel <eric@webkit.org>
Reviewed by Geoff Garen.
https://bugs.webkit.org/show_bug.cgi?id=22683
Fix gtk and qt builds which depend on --qt and --gtk being removed from ARGV
Add a new argumentsForConfiguration() function and clean up some old code to use it.
Rename checkArgV to checkForArgumentAndRemoveFromARGV to be more self-documenting.
* Scripts/run-javascriptcore-tests:
* Scripts/run-launcher:
* Scripts/run-webkit-tests:
* Scripts/webkitdirs.pm:
2008-12-03 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
Reviewed by Cameron Zwarich.
Further preparations for WML layout tests.
Ignore WMLTestCase.js, that's going to be in trunk soon.
* Scripts/make-js-test-wrappers:
2008-12-03 Eric Seidel <eric@webkit.org>
Build fix for --gtk and --chromium, no review.
Fix run-javascriptcore-tests to pass --gtk, --qt, --chromium, etc.
through to build-jsc.
* Scripts/build-jsc:
* Scripts/webkitdirs.pm:
2008-12-03 Eric Seidel <eric@webkit.org>
Build fix only, no review.
Remove support for build-webkit --svg-experimental.
All of the "experimental" svg features have their own toggles anyway.
I broke --svg-experimental in my last commit (which then broke clean builds)
I can't find any use of --svg-experimental in our source tree, so removing it.
* Scripts/build-webkit:
2008-12-02 Eric Seidel <eric@webkit.org>
Reviewed by David Hyatt (and Mark Rowe).
Move --coverage support from build-webkit to webkitdirs.pm to share it with build-jsc
Move --coverage support out of run-javascriptcore-tests and into build-jsc
Finally add a buildXCodeProject function to webkitdirs.pm and move --clean support
there from build-webkit (to allow future sharing with other build-* scripts)
Change run-javascriptcore-tests to expect a --jsDriver-args= argument instead of
picking through ARGV with a blacklist of what arguments weren't jsDriver args
this makes run-javascriptcore-tests transparently support all arguments which
webkitdirs.pm gives it support for.
Make run-javascriptcore-tests actually print what commands it's running before running them.
Add --help support to build-jsc and run-javascriptcore-tests!
Make code to support --svg-experimental defaults take up half as many lines.
* Scripts/build-jsc:
* Scripts/build-webkit:
* Scripts/run-javascriptcore-tests:
* Scripts/webkitdirs.pm:
2008-12-03 Adam Roben <aroben@apple.com>
Fix a leak in WinLauncher shutdown
Reviewed by Sam Weinig.
* WinLauncher/WinLauncher.cpp:
(_tWinMain): Replaced a delete with a Release. We can't delete the
WebView properly since we only have a pointer to one of its
interfaces. We also shouldn't be deleting COM objects directly anyway,
for a number of reasons.
2008-12-03 Adam Roben <aroben@apple.com>
Fix a crash on exit in WinLauncher
Reviewed by Sam Weinig.
* WinLauncher/WinLauncher.cpp:
(_tWinMain): Call shutDownWebKit before exiting.
2008-12-03 Adam Roben <aroben@apple.com>
Add a Debug_Internal configuration to WinLauncher
This matches our other projects.
Reviewed by Sam Weinig.
* WinLauncher/WinLauncher.vcproj: Added a Debug_Internal
configuration, which is identical to Debug except that it also
references debug_internal.vsprops. Also removed some settings that we
should be picking up from the .vsprops files.
2008-12-02 Eric Seidel <eric@webkit.org>
Reviewed by David Kilzer.
Hack build-webkit --chromium to use Win32 python instead
of using the default cygwin python. Scons + CYGWIN tries
to build with GCC by default, we force MSVC in our file
but that just results in errors from Scons. Until we can fix
this latest round of errors, at least make build-webkit --chromium
actually "work" under CYGWIN instead of forcing users to use
a cmd shell directly.
This is working around a Scons bug:
http://scons.tigris.org/issues/show_bug.cgi?id=2266
* Scripts/webkitdirs.pm:
2008-12-01 David Kilzer <ddkilzer@apple.com>
Bug 22466: REGRESSION (35867): Many resources missing when saving webarchive of webkit.org
<https://bugs.webkit.org/show_bug.cgi?id=22466>
<rdar://problem/6403593>
Reviewed by Brady Eidson.
* DumpRenderTree/mac/DumpRenderTree.mm:
(normalizeHTTPResponseHeaderFields): Added. Normalizes Date, Etag,
Keep-Alive, Last-Modified and Server header fields to prevent false
positive test failures.
(convertWebResourceResponseToDictionary): Call
normalizeHTTPResponseHeaderFields() to noramlize HTTP response
header fields.
2008-12-01 David D. Kilzer <ddkilzer@webkit.org>
Bug 22559: Report builds left to test in bisect-builds (like git-bisect)
<https://bugs.webkit.org/show_bug.cgi?id=22559>
Reviewed by Adam Roben.
* Scripts/bisect-builds: Updated status message to report the
maximum number of builds left to test after the current one.
(max): Added.
2008-11-27 Alp Toker <alp@nuanti.com>
Build GtkLauncher and minidom with the '-ansi' compiler flag to detect
API header breakage at build time.
* GNUmakefile.am:
2008-11-26 Eric Seidel <eric@webkit.org>
Reviewed by Nikolas Zimmermann and Mark Rowe.
Add support for build-webkit --chromium
https://bugs.webkit.org/show_bug.cgi?id=22515
More cleanups changing isCygwin calls to isAppleWinWebKit and deploying isAppleWebKit where necessary.
* Scripts/build-dumprendertree:
* Scripts/build-jsc:
* Scripts/build-webkit:
* Scripts/gdb-safari:
* Scripts/run-webkit-tests:
* Scripts/webkitdirs.pm:
2008-11-26 Eric Seidel <eric@webkit.org>
Reviewed by Nikolas Zimmermann.
Add support for build-webkit --chromium (tested on mac)
https://bugs.webkit.org/show_bug.cgi?id=22515
Also simplified some code using checkArgv
* Scripts/build-webkit:
* Scripts/webkitdirs.pm:
2008-11-26 Eric Seidel <eric@webkit.org>
Reviewed by Nikolas Zimmermann.
More pre-work for adding a build-webkit --chromium which works on Mac and Windows
https://bugs.webkit.org/show_bug.cgi?id=22515
Change a few calls to isCygwin to isAppleWinWebKit and a few calls to isAppleMacWebKit to isDarwin
in preparation for having a chromium cygwin and chromium mac build
* Scripts/build-webkit:
* Scripts/webkitdirs.pm:
2008-11-26 Eric Seidel <eric@webkit.org>
Reviewed by Nikolas Zimmermann.
Pre-work for getting build-webkit --chromium to work
https://bugs.webkit.org/show_bug.cgi?id=22515
Rename isOSX to isAppleMacWebKit to match what the code does, and add isChromium()
* Scripts/build-dumprendertree:
* Scripts/build-jsc:
* Scripts/build-webkit:
* Scripts/gdb-safari:
* Scripts/run-javascriptcore-tests:
* Scripts/run-webkit-tests:
* Scripts/webkitdirs.pm:
2008-11-26 David Kilzer <ddkilzer@apple.com>
Bug 22488: Make DRT smarter about charset encoding when post-processing webarchive content
<https://bugs.webkit.org/show_bug.cgi?id=22488>
Reviewed by Brady Eidson.
* DumpRenderTree/mac/DumpRenderTree.mm:
(convertWebResourceDataToString): If an IANA charset encoding string
is provided, convert it to a CFStringEncoding value and then to an
NSStringEncoding value, else fall back to NSUTF8StringEncoding. We
also nil-check dataAsString, so the worst-case scenario is that the
data won't be decoded to a string (versus crashing DumpRenderTree).
2008-11-26 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Holger Freyther.
[Gtk] add/remove tests from Skipped and fix netscape plugin test
https://bugs.webkit.org/show_bug.cgi?id=22484
Remove print'ing to stderr
* DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
(NP_Initialize):
(NP_Shutdown):
2008-11-25 Steve Falkenburg <sfalken@apple.com>
Windows build fix.
* DumpRenderTree/cg/PixelDumpSupportCG.h:
2008-11-25 Steve Falkenburg <sfalken@apple.com>
Windows build fix.
* DumpRenderTree/cg/ImageDiffCG.cpp:
2008-11-24 Darin Fisher <darin@chromium.org>
Fix bustage.
https://bugs.webkit.org/show_bug.cgi?id=15643
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setSelectTrailingWhitespaceEnabled):
2008-11-24 Glenn Wilson <gwilson@chromium.org>
Reviewed by Alexey Proskuryakov.
http://bugs.webkit.org/show_bug.cgi?id=15643
Added support for changing the "trailing whitespace" work-around
in LayoutTestController (so layout tests can verify this functionality)
* DumpRenderTree/LayoutTestController.cpp:
(setSelectTrailingWhitespaceEnabledCallback):
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setSelectTrailingWhitespaceEnabled):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setSelectTrailingWhitespaceEnabled):
2008-11-24 Simon Fraser <simon.fraser@apple.com>
Reviewed by Darin Adler
https://bugs.webkit.org/show_bug.cgi?id=22433
Add script that attempts to detect virtual methods
whose signatures differ only by constness (which can
indicate a programming error).
* Scripts/detect-mismatched-virtual-const: Added.
2008-11-24 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=22039
[Gtk+] Implement TestNetscapePlugin for Gtk+ port and add it to the
build.
* DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
* DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(setDefaultsToConsistentStateValuesForTesting):
* DumpRenderTree/gtk/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h: Added.
* DumpRenderTree/gtk/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h: Added.
* DumpRenderTree/gtk/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h: Added.
* GNUmakefile.am:
2008-11-24 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Mark Rowe.
[Gtk+] Add configure option to enable Web Workers and enable it by default
Add --enable-workers to the buildsystem (used by build-webkit) add
the to be build files to the GNUmakefile.am and change build-webkit
to enable Web Workers by default.
* Scripts/build-webkit:
2008-11-24 Mark Rowe <mrowe@apple.com>
Reviewed by Alexey Proskuryakov.
Let gdb-safari accept the --debug and --release options once more.
* Scripts/gdb-safari:
2008-11-23 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Holger Freyther. Landed by Jan Alonzo.
Get SVG tests tested on GTK port.
* Scripts/webkitdirs.pm:
2008-11-19 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=21810
Remove use of static C++ objects that are destroyed at exit time (destructors)
All static C++ objects that create atexit calls are gone. Update script
to indicate how to fix the problem should a new one appear.
* Scripts/check-for-exit-time-destructors:
2008-11-18 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22337
Enable workers by default
* Scripts/build-webkit: Changed the default to enabled.
2008-11-18 Alexey Proskuryakov <ap@webkit.org>
Rubber-stamped by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22306
Disable channel messaging support
* Scripts/build-webkit: Add an option to enable channel messaging.
2008-11-17 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
Reviewed by George Staikos.
Add --(no-)wml build flags.
* Scripts/build-webkit:
* Scripts/run-webkit-tests:
* Scripts/webkitdirs.pm:
2008-11-17 Geoffrey Garen <ggaren@apple.com>
Not reviewed.
Try to fix gtk build.
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::pauseAnimationAtTimeOnElementWithId):
(LayoutTestController::pauseTransitionAtTimeOnElementWithId):
2008-11-17 Pierre-Olivier Latour <pol@apple.com>
Reviewed by Maciej.
Pixel tests should use a default tolerance of 0.1% on Leopard and 1.0%
on Tiger.
https://bugs.webkit.org/show_bug.cgi?id=22271
* Scripts/run-webkit-tests:
2008-11-17 Pierre-Olivier Latour <pol@apple.com>
Reviewed by Sam Weinig.
Added new JavaScript API on LayoutController to pause a running
CSS transition or animation at a given time.
https://bugs.webkit.org/show_bug.cgi?id=21261
* DumpRenderTree/LayoutTestController.cpp:
(pauseAnimationAtTimeOnElementWithIdCallback):
(pauseTransitionAtTimeOnElementWithIdCallback):
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::pauseAnimationAtTimeOnElementWithId):
(LayoutTestController::pauseTransitionAtTimeOnElementWithId):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::pauseAnimationAtTimeOnElementWithId):
(LayoutTestController::pauseTransitionAtTimeOnElementWithId):
2008-11-17 Gabor Loki <loki@inf.u-szeged.hu>
Reviewed by Darin Adler.
<https://bugs.webkit.org/show_bug.cgi?id=22309>
Pass the remaining options to build system on Qt-port
* Scripts/build-webkit:
* Scripts/webkitdirs.pm:
2008-11-16 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=21810
Remove use of static C++ objects that are destroyed at exit time (destructors)
Remove .o files from the exclude list that have had their exit-time destructors removed.
Handle case when there is no current symbol.
* Scripts/check-for-exit-time-destructors:
2008-11-16 Sam Weinig <sam@webkit.org>
* Scripts/do-webcore-rename: Remove now fixed renames.
2008-11-16 Darin Adler <darin@apple.com>
* Scripts/do-webcore-rename: Plan some future renames.
2008-11-15 Darin Adler <darin@apple.com>
Rubber stamped by Geoff Garen.
- do the long-planned StructureID -> Structure rename
* Scripts/check-for-global-initializers: Update name of StructureID.o.
* Scripts/do-webcore-rename: Renaming script that I used.
2008-11-15 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=21810
Remove use of static C++ objects that are destroyed at exit time (destructors)
Create DEFINE_STATIC_LOCAL macro. Change static local objects to leak to avoid
exit-time destructor. Update code that was changed to fix this issue that ran
into a gcc bug (<rdar://problem/6354696> Codegen issue with C++ static reference
in gcc build 5465). Also typdefs for template types needed to be added in some
cases so the type could make it through the macro successfully.
Basically code of the form:
static T m;
becomes:
DEFINE_STATIC_LOCAL(T, m, ());
Also any code of the form:
static T& m = *new T;
also becomes:
DEFINE_STATIC_LOCAL(T, m, ());
Remove .o files from the exclude list that have had their exit-time destructors removed.
* Scripts/check-for-exit-time-destructors:
2008-11-14 Kevin Ollivier <kevino@theolliviers.com>
wx mac buildbot fix. Also, make sure we don't keep hitting this problem.
* wx/install-unix-extras:
2008-11-14 Alp Toker <alp@nuanti.com>
GTK DRT build fix for gcc 4.4 snapshot. Add missing stdio include.
Fixes Debian bug #505723
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=505723
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2008-11-14 Krishna <krishnamurty.podipireddy@nokia.com>
Reviewed by Simon Hausmann.
Fix hanging DRT with Qt.
https://bugs.webkit.org/show_bug.cgi?id=22209
* DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::DumpRenderTree::dump):
Send empty pixel test data 'block', which is now
expected by run-layout-tests.
2008-11-12 Dmitry Titov <dimich@chromium.org>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=22216
* Scripts/build-webkit:
Addes ENABLE_WORKERS to build-webkit so it's possible to build with workers enabled.
2008-11-06 David Kilzer <ddkilzer@apple.com>
BUILD FIX: Backed out r38189 (and r38203) for Xcode 3.0.
Apparently older versions of gcc have issues with this patch.
Backing out a second time until the issues are resolved.
2008-11-06 David Kilzer <ddkilzer@apple.com>
BUILD WAS NOT BROKEN: Rolling r38189 back in.
Please perform a clean build if you see crashes.
2008-11-06 David Kilzer <ddkilzer@apple.com>
BUILD FIX: Backed out r38189 since it apparently broke the world.
2008-11-06 Chris Fleizach <cfleizach@apple.com>
Reviewed by Beth Dakin.
Add ability to query an attribute's settable status and the
ability to retrieve a single attribute from an AXObject
* DumpRenderTree/AccessibilityUIElement.cpp:
(isAttributeSettableCallback):
(attributeValueCallback):
(AccessibilityUIElement::getJSClass):
* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(+[NSString stringWithJSStringRef:]):
(AccessibilityUIElement::attributeValue):
(AccessibilityUIElement::isAttributeSettable):
* DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::attributeValue):
(AccessibilityUIElement::isAttributeSettable):
2008-11-06 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Bug 21810: Remove use of static C++ objects that are destroyed at exit time (destructors)
https://bugs.webkit.org/show_bug.cgi?id=21810
Remove .o files from the exclude list that have had their exit-time destructors removed.
* Scripts/check-for-exit-time-destructors:
2008-11-05 Alp Toker <alp@nuanti.com>
GTK build script tweak.
Make the path relative since it will appear in all -I compiler flags.
Long argument lists cause bizarre slowdowns in libtool and result
in huge build logs.
* Scripts/webkitdirs.pm:
2008-11-05 Anders Carlsson <andersca@apple.com>
Fix 64-bit build.
* DumpRenderTree/mac/DumpRenderTree.mm:
(setDefaultsToConsistentValuesForTesting):
2008-11-04 Simon Fraser <simon.fraser@apple.com>
Add AccessibilityObject.o to the exclude list for the
check for global destructors.
* Scripts/check-for-exit-time-destructors:
2008-11-04 Darin Adler <darin@apple.com>
* Scripts/check-for-exit-time-destructors: Fix failures seen on the
bot, but for some reason not on my computer.
2008-11-03 Darin Adler <darin@apple.com>
Reviewed by Tim Hatcher.
- https://bugs.webkit.org/show_bug.cgi?id=22061
create script to check for exit-time destructors
* Scripts/check-for-exit-time-destructors: Added.
Started as a copy of check-for-global-initializers.
* Scripts/check-for-global-initializers: Added code to make
this script rerun any time it's modified, and also to properly
run again after the first time it reports an error.
2008-11-03 Pierre-Olivier Latour <pol@apple.com>
Reviewed by Dan Bernstein.
Fixed the override of the "AppleScrollBarVariant" system setting to also work with HIToolbox.
https://bugs.webkit.org/show_bug.cgi?id=22054
* DumpRenderTree/mac/DumpRenderTree.mm:
(setDefaultsToConsistentValuesForTesting):
2008-10-31 Cameron Zwarich <zwarich@apple.com>
Not reviewed.
* Scripts/do-webcore-rename:
Add some renames to contemplate for the future.
2008-10-31 Darin Adler <darin@apple.com>
Requested by Mark Rowe.
* Scripts/check-for-global-initializers: s/Web Kit/WebKit/.
2008-10-31 David Kilzer <ddkilzer@apple.com>
Bug 21997: prepare-ChangeLog should filter out ChangeLog files
<https://bugs.webkit.org/show_bug.cgi?id=21997>
Reviewed by Darin Adler.
* Scripts/prepare-ChangeLog:
(generateFileList): Don't add ChangeLog files to %{$functionLists}.
This prevents them from showing up in the new ChangeLog entry. They
were already excluded from @{$changedFiles}.
2008-10-30 Mark Rowe <mrowe@apple.com>
Reviewed by Jon Homeycutt.
Explicitly default to building for only the native architecture in debug and release builds.
* DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2008-10-30 Pierre-Olivier Latour <pol@apple.com>
Reviewed by Dan Bernstein.
Fixed 64 bit build failure.
* DumpRenderTree/mac/PixelDumpSupportMac.mm:
(setupMainDisplayColorProfile):
(createBitmapContextFromWebView):
2008-10-28 Alp Toker <alp@nuanti.com>
Fix GTK DRT following build breakage in r37928.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(dump):
(runTest):
(main):
2008-10-28 Alp Toker <alp@nuanti.com>
Reviewed by Mark Rowe.
Fix recently introduced double-free crashes in GTK DRT.
LayoutTestController was made ref-counted in r36606 and Mac/Win DRT
were updated to call ->deref() but GTK DRT was still deleting
gLayoutTestController manually. This patch updates GTK to match the
other ports and resolves the memory allocation issues.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(runTest):
2008-10-28 Alp Toker <alp@nuanti.com>
Reviewed by Mark Rowe.
Fix GTK DRT hang when running the tests.
Update output from the DRT tool to print an additional '#EOF' to match
breaking changes that were made in r37434.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(dump):
2008-10-28 Adele Peterson <adele@apple.com>
Reviewed by Sam Weinig.
Specify which Localizable.strings to update since we don't always want to update the file in the same
directory where we're searching for the strings to localize.
* Scripts/extract-localizable-strings:
* Scripts/update-webkit-localizable-strings:
2008-10-28 Timothy Hatcher <timothy@apple.com>
Add support for enabling the profiler, so the profiling tests can continue
work now that the profiler is not always enabled.
https://bugs.webkit.org/show_bug.cgi?id=21927
<rdar://problem/6211578> Make the JavaScript profiler opt-in, so it does
not slow down JavaScript all the time
Reviewed by Darin Adler and Kevin McCullough.
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Make the editor use spaces.
* DumpRenderTree/LayoutTestController.cpp:
(setJavaScriptProfilingEnabledCallback): Added. Calls LayoutTestController::setJavaScriptProfilingEnabled.
(LayoutTestController::staticFunctions): Added setJavaScriptProfilingEnabled to the script class.
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setJavaScriptProfilingEnabled): Stubbed out with a FIXME.
* DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebViewToConsistentStateBeforeTesting): Disables the developer extras and disables the profiler.
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setJavaScriptProfilingEnabled): Toggles the developer extras and profiler.
* DumpRenderTree/win/DumpRenderTree.cpp:
(resetWebViewToConsistentStateBeforeTesting): Disables the developer extras and disables the profiler.
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setJavaScriptProfilingEnabled): Toggles the developer extras and profiler.
2008-10-28 Pierre-Olivier Latour <pol@apple.com>
Reviewed by Dan Bernstein
Primary changes in DumpRenderTree:
- Ensure font smoothing is disabled (this is also called LCD anti-aliasing and
is different from regular font CG anti-aliasing) as font-smoothing settings
depends on the display and can also be changed by the user
- Use a new cleared buffer for each test instead of the reusing same one to
avoid potential result corruption across tests
- Can now receive the expected pixel hash as a suffix to the test path or
url as "path'hash"
- Make sure hash is computed in a endian-independent way
- Improve the code that sets/restores the screen color profile
- Make the code more cross-platformy with std::string goodness
- Added an "on-screen" mode where the snapshot will take into account surfaces
on the window (like OpenGL content): this uses the new CG APIs on 10.5 or
reading from the display framebuffer on 10.4. This mode is not active by
default for performance reason, but must be explicitly activated from the test
file using the new "testOnscreen()" JS API.
Primary changes in ImageDiff:
- Provide a new comparison algorithm that is more tolerant to "acceptable"
failures (i.e. very small differences in font rendering, which --threshold is
not really good at handling)
- Generate normalized intensity-only diff images
Primary changes in run-webkit-tests:
- Take advantage of hashes for pixel tests which makes them much faster by
minimizing image comparisons
- Removed repaint options as these should be set from within test files using
JS API
- Replaced "threshold" option in by "tolerance" expressed in percents
- Added more logging when in "verbose" mode
https://bugs.webkit.org/show_bug.cgi?id=21322
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* DumpRenderTree/ForwardingHeaders/wtf/PassRefPtr.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/PassRefPtr.h.
* DumpRenderTree/ForwardingHeaders/wtf/RefPtr.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/RefPtr.h.
* DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(testOnscreenCallback):
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
(LayoutTestController::testOnscreen):
(LayoutTestController::setTestOnscreen):
(LayoutTestController::testPathOrURL):
(LayoutTestController::expectedPixelHash):
* DumpRenderTree/PixelDumpSupport.h:
* DumpRenderTree/cg/ImageDiffCG.cpp:
(strtof):
(releaseMallocBuffer):
(createDifferenceImage):
(imageHasAlpha):
(main):
* DumpRenderTree/cg/PixelDumpSupportCG.cpp:
(computeMD5HashStringForBitmapContext):
(dumpWebViewAsPixelsAndCompareWithExpected):
* DumpRenderTree/cg/PixelDumpSupportCG.h:
(BitmapContext::createByAdoptingBitmapAndContext):
(BitmapContext::~BitmapContext):
(BitmapContext::cgContext):
(BitmapContext::BitmapContext):
* DumpRenderTree/mac/DumpRenderTree.mm:
(shouldIgnoreWebCoreNodeLeaks):
(setDefaultsToConsistentValuesForTesting):
(crashHandler):
(initializeGlobalsFromCommandLineOptions):
(prepareConsistentTestingEnvironment):
(dumpRenderTree):
(sizeWebViewForCurrentTest):
(dump):
(runTest):
* DumpRenderTree/mac/PixelDumpSupportMac.mm:
(restoreMainDisplayColorProfile):
(setupMainDisplayColorProfile):
(createBitmapContextFromWebView):
* DumpRenderTree/win/DumpRenderTree.cpp:
(dump):
(runTest):
* DumpRenderTree/win/PixelDumpSupportWin.cpp:
(getBitmapContextFromWebView):
* Scripts/run-webkit-tests:
2008-10-27 Kevin Ollivier <kevino@theolliviers.com>
wx build fix on Linux/GTK. Enable support for #include <JavaScriptCore/XYZ.h> style includes.
* wx/build-wxwebkit:
2008-10-24 Anders Carlsson <andersca@apple.com>
Try fixing the 64-bit build.
* DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
(testGetProperty):
2008-10-24 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
<rdar://problem/5440917> Support NPN_Construct
* DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
(testCallback):
Fix a memory leak.
(testConstruct):
New test method that treats it first argument as a constructor and invokes it with the rest of the arguments.
(pluginInvoke):
Handle testConstruct.
* DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
(testGetProperty):
Add objectPointer property.
(testEnumerate):
Only enumerate the two first properties.
(testConstruct):
Add a simple construct implementation that just returns the test object.
2008-10-24 David Kilzer <ddkilzer@apple.com>
Bug 21850: svn-apply and svn-unapply should preserve patch line endings
<https://bugs.webkit.org/show_bug.cgi?id=21850>
Reviewed by Adam Roben.
* Scripts/svn-apply: Save end-of-line characters when stripping them
off each line of a patch so that they may be restored after
processing the line.
* Scripts/svn-unapply: Ditto.
2008-10-23 David Kilzer <ddkilzer@apple.com>
Bug 21832: Fix scripts using 'new File::Temp' for Perl 5.10
<https://bugs.webkit.org/show_bug.cgi?id=21832>
Reviewed by Sam Weinig.
* Scripts/bisect-builds: Use imported tempfile() from File::Temp
instead of 'new File::Temp' to make the script work with Perl 5.10.
* Scripts/sort-Xcode-project-file: Ditto.
2008-10-22 Brady Eidson <beidson@apple.com>
Reviewed by Adam Roben
<rdar://6261773> - autocomplete="off" doesn't work on Windows
Implement LayoutTestController::elementDoesAutoCompleteForElementWithId() on Windows
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
2008-10-22 Darin Adler <darin@apple.com>
* Scripts/do-webcore-rename: More renaming plans.
2008-10-21 Steve Falkenburg <sfalken@apple.com>
Exclude strings marked with UNLOCALIZED_STRING or UNLOCALIZED_LPCTSTR.
* Scripts/extract-localizable-strings:
2008-10-17 Maciej Stachowiak <mjs@apple.com>
Reviewed by Mark Rowe.
- default to 1000 tests per dump tool instance again, now that CTI no longer causes
excess different stack logs.
(Also fix a small bug in my last change.)
* Scripts/run-webkit-tests:
2008-10-17 Stephanie Lewis <slewis@apple.com>
Reviewed by Mark Rowe.
Fix layout tests that use prologues and epilogues.
* Scripts/run-webkit-tests: