New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SVG support for Path2D.WIND_EVEN_ODD #67

Merged
merged 4 commits into from May 23, 2018

Conversation

Projects
None yet
4 participants
@davideby
Contributor

davideby commented May 17, 2018

This fixes a bug where setting e.g. a java.awt.LineBorder on a JPanel
results in a solid-fill rectangle obscuring the contents.

Unfortunately I don't know the corresponding fix for PDF and EPS.

A little background:
We're converting SVG export for our project (IGV) over from Batik as it's not ready for Java 9+ and is too heavyweight anyway. We considered writing our own exporter but yours is already in good shape. We found a couple of bugs in testing. This is the first and was pretty easy; we'll see how the next one goes.

Here's the relevant part of the spec.

davideby added some commits May 17, 2018

Added SVG support for Path2D.WIND_EVEN_ODD
This fixes a bug where setting e.g. a java.awt.LineBorder on a JPanel
results in a solid-fill rectangle obscuring the contents.

Unfortunately I don't know the corresponding fix for PDF and EPS.
Removed duplicate test
Not sure how that slipped past me...
@coveralls

This comment has been minimized.

coveralls commented May 17, 2018

Coverage Status

Coverage increased (+0.7%) to 47.548% when pulling 485723d on igvteam:master into b2ba6a6 on eseifert:master.

@seifertm

This comment has been minimized.

Collaborator

seifertm commented May 22, 2018

Thank you for the enhancement!
However, I will only be able to look at things tomorrow, sorry for the delay.

@davideby

This comment has been minimized.

Contributor

davideby commented May 22, 2018

No problem! I was just about to try to figure out the EPS & PDF equivalents as well.

There's a bigger PR coming soon. Maybe I should file a GitHub Issue on that first in case we need to discuss it beforehand.

@davideby

This comment has been minimized.

Contributor

davideby commented May 22, 2018

Added equivalents for EPS & PDF.

@eseifert eseifert merged commit 0c42974 into eseifert:master May 23, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.7%) to 47.548%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment