New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc refactors #3

Open
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@yanick

yanick commented Apr 14, 2018

A few refactorings, each in its own commit so you can pick and chose what you want and you would prefer not.

And yes, I added the port to Moo more for giggles than for anything else. :-)

@eserte

This comment has been minimized.

Owner

eserte commented Apr 14, 2018

I would prefer to keep the Slay::Makefile prereqs as low as possible. So please no Moo. Can you redo the PR without the additional prereqs?

yanick added some commits Apr 14, 2018

use quotemata
... and sort the keys, so we're sure to always get the same regex
@yanick

This comment has been minimized.

yanick commented Apr 16, 2018

Absolutely! Done.

@eserte

This comment has been minimized.

Owner

eserte commented Apr 16, 2018

@yanick

This comment has been minimized.

yanick commented Apr 25, 2018

That was a silly one. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment