cease warnings in replace vmethod (https://rt.cpan.org/Ticket/Display…

….html?id=76694)
eserte · Apr 19, 2012 · 3fe5f0d · 3fe5f0d
1 parent fde062c
commit 3fe5f0d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/lib/Template/VMethods.pm b/lib/Template/VMethods.pm
@@ -220,7 +220,7 @@ sub text_replace {
             my ($chunk, $start, $end) = @_;
             $chunk =~ s{ \\(\\|\$) | \$ (\d+) }{
                 $1 ? $1
-                    : ($2 > $#$start || $2 == 0) ? ''
+                    : ($2 > $#$start || $2 == 0 || !defined $start->[$2]) ? ''
                     : substr($text, $start->[$2], $end->[$2] - $start->[$2]);
             }exg;
             $chunk;

diff --git a/t/vmethods/replace.t b/t/vmethods/replace.t
@@ -200,4 +200,10 @@ oo\$1 bar
 -- expect --
 f!! ba!r! f!!ba!r!
 
-
+-- test --
+-- name: no warnings --
+[% text = 'foo';
+   text.replace('(optional)?(foo)', '$1$2');
+%]
+-- expect --
+foo