New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate META.json #1

Merged
merged 1 commit into from Jul 21, 2016

Conversation

Projects
None yet
2 participants
@ambs
Contributor

ambs commented Jul 20, 2016

EU::MM generates a META.json, the new toy in town, when CPAN::Meta is available.
So, tweaked Makefile.PL in order to allow make dist only if it is available.

This is a Pull Request Challenge PR.

@eserte

This comment has been minimized.

Show comment
Hide comment
@eserte

eserte Jul 21, 2016

Owner

I would like it more to have both conditions in one place, e.g:

if (!$eumm_recent_enough || !eval { require CPAN::Meta; 1 }) {
    ...
}
Owner

eserte commented Jul 21, 2016

I would like it more to have both conditions in one place, e.g:

if (!$eumm_recent_enough || !eval { require CPAN::Meta; 1 }) {
    ...
}
@ambs

This comment has been minimized.

Show comment
Hide comment
@ambs

ambs Jul 21, 2016

Contributor

Sure, but you will lose the personalized error messages. Will update the PR. cheers

Contributor

ambs commented Jul 21, 2016

Sure, but you will lose the personalized error messages. Will update the PR. cheers

@ambs

This comment has been minimized.

Show comment
Hide comment
@ambs

ambs Jul 21, 2016

Contributor

Better?

Contributor

ambs commented Jul 21, 2016

Better?

@eserte eserte merged commit b50c544 into eserte:master Jul 21, 2016

@eserte

This comment has been minimized.

Show comment
Hide comment
@eserte

eserte Jul 21, 2016

Owner

Actually, in the first version we would had only one error message if both conditions were not met. Maybe even nicer it would be if the messages were collected, and all output.

But anyway, I just checked and found out that I have no system perl anymore with older EUMM or without CPAN::Meta ;-)

Owner

eserte commented Jul 21, 2016

Actually, in the first version we would had only one error message if both conditions were not met. Maybe even nicer it would be if the messages were collected, and all output.

But anyway, I just checked and found out that I have no system perl anymore with older EUMM or without CPAN::Meta ;-)

@ambs

This comment has been minimized.

Show comment
Hide comment
@ambs

ambs Jul 21, 2016

Contributor

Hahhaa, yeah, so, not very useful, I understand :-)

Contributor

ambs commented Jul 21, 2016

Hahhaa, yeah, so, not very useful, I understand :-)

@eserte

This comment has been minimized.

Show comment
Hide comment
@eserte

eserte Jul 21, 2016

Owner

Well, at least I had a trigger to create a fresh release which has now META.json included :-)

Owner

eserte commented Jul 21, 2016

Well, at least I had a trigger to create a fresh release which has now META.json included :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment