Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Kwalitee fixes for Makefile.PL #1
Image::Xpm is my dist this month for the CPAN PR Challenge - thanks for taking part. Here are some simple fixes for three of the outstanding kwalitee issues.
As the POD simply says that the license is the GPL with no version identified I've set this to gpl_2 for now - is this a sensible default or is the correct license some other version?
I think that has_meta_json requires no changes to the source, just rebuilding the dist with a modern EUMM should be enough - it does on my copy anyway.
The only remaining non-experimental CPANTS issue is use_warnings. Is this something you would like to have added?
I am just the maintainer, not the author, but everything indicates that gpl_2 is the correct one.
Pro - increased CPANTS rating.
I think I am fine without "use warnings" for now.