New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kwalitee fixes for Makefile.PL #1

Merged
merged 1 commit into from Dec 7, 2016

Conversation

Projects
None yet
2 participants
@openstrike
Contributor

openstrike commented Dec 6, 2016

Image::Xpm is my dist this month for the CPAN PR Challenge - thanks for taking part. Here are some simple fixes for three of the outstanding kwalitee issues.

As the POD simply says that the license is the GPL with no version identified I've set this to gpl_2 for now - is this a sensible default or is the correct license some other version?

I think that has_meta_json requires no changes to the source, just rebuilding the dist with a modern EUMM should be enough - it does on my copy anyway.

The only remaining non-experimental CPANTS issue is use_warnings. Is this something you would like to have added?

Kwalitee fixes for Makefile.PL
	chmod -x
	MIN_PERL_VERSION is 5.5.0 (for $! in xpm.t)
	LICENSE is gpl_2
@eserte

This comment has been minimized.

Show comment
Hide comment
@eserte

eserte Dec 7, 2016

Owner

As the POD simply says that the license is the GPL with no version identified I've set this to gpl_2 for now - is this a sensible default or is the correct license some other version?

I am just the maintainer, not the author, but everything indicates that gpl_2 is the correct one.

The only remaining non-experimental CPANTS issue is use_warnings. Is this something you would like to have added?

Pro - increased CPANTS rating.
Con - we lose 5.005 compat (not that there are many users around there using so old perl, I guess) + possible implications on other modules using Image::Xpm (e.g. Image::Info).

I think I am fine without "use warnings" for now.

Owner

eserte commented Dec 7, 2016

As the POD simply says that the license is the GPL with no version identified I've set this to gpl_2 for now - is this a sensible default or is the correct license some other version?

I am just the maintainer, not the author, but everything indicates that gpl_2 is the correct one.

The only remaining non-experimental CPANTS issue is use_warnings. Is this something you would like to have added?

Pro - increased CPANTS rating.
Con - we lose 5.005 compat (not that there are many users around there using so old perl, I guess) + possible implications on other modules using Image::Xpm (e.g. Image::Info).

I think I am fine without "use warnings" for now.

@eserte eserte merged commit fe4cc80 into eserte:master Dec 7, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment