-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
/universe/structures/{structure_id}/ does not return structure_id in the response. #273
Comments
It's something they are fairly inconsistent about. The character details page for example doesn't return it either. |
Gonna chip in here. To my knowledge, no endpoint that requires an id or any type to make the request returns that id in the response. That includes Characters, Corporations, and Alliances. It would be nice if the id was included in the response body. Edit: Apparently, most of the /universe/ endpoints return the request id in the response body. Excluding those from my statement |
That was pretty much my point. You can request info on a station and the id is in the returned data. You can do the same for types, groups, planets, stargates, etc. When requesting information on a structure, however, if you want to associate the data with the id you need to do more work on the returned data to add it. |
I'm way more inclined to remove the instances where we return a param passed instead. from a quick look at
ping @aquarhead for input/feedback |
Why would you prefer to remove the ID instead of add it in if you don't mind me asking? |
it's information the requestor already has |
its information the requester probably wants to store associated with the new data |
The requester doesn't always have it. Links get passed around for example. The fleet links from the client for example? Or links passed from one app to another. |
I'm more towards thinking of it as a part/property of the resource we're requesting. So I'd vote for having it in the response (as a representation of the resource) |
Closing this as it is covered by #1122 which includes more examples |
/universe/structures/{structure_id}/ does not return structure_id in the response data. All of the other /universe/xxx/{xxx_id} endpoints return xxx_id in the response, making the response for structures unique in that regard.
The text was updated successfully, but these errors were encountered: