New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Assets included items that was destroyed in-game #698

Closed
GoldenGnu opened this Issue Jan 2, 2018 · 4 comments

Comments

Projects
None yet
6 participants
@GoldenGnu
Copy link
Member

GoldenGnu commented Jan 2, 2018

Bug

Character Assets include items that no longer exist in game.
Example: The assets endpoint will return items fitted to ships that was destroyed (It only returns the items that did not drop).

Route

/characters/{character_id}/assets/
Note: It may also affect the corporation endpoint, as I have reports of this happening when trashing assets too.

Response

Reproduce with uhnboy ghost
Here is a list of ItemIDs that may fit the above description:
https://gist.github.com/GoldenGnu/bbd53ed0a42deea9b8f48bd07a40d2a7
They won't all match the description, but, some of them should. (I apologize for the overflow of data)

Expected

Only assets that still exist

@ccp-zoetrope ccp-zoetrope added in-backlog bug and removed in-backlog labels Jan 2, 2018

@tsuthers-ccpgames

This comment has been minimized.

Copy link
Contributor

tsuthers-ccpgames commented Jan 5, 2018

A quick snoop on some of these items shows that these are all inside containers of some kind, I've seen ships and cargo containers. The container itself is in the junkyard, we're probably not recursing back up the tree far enough.

@GoldenGnu

This comment has been minimized.

Copy link
Member Author

GoldenGnu commented Jan 5, 2018

I'm so happy you're able to reproduce this, thank you for looking into it. :)

@Kupuyc

This comment has been minimized.

Copy link

Kupuyc commented May 16, 2018

Similar situation with corporation assest. Some items (ihub upgrades) in list may have location_id which are not in list. For example upgrade
{"is_singleton":true,"item_id":1024930875660,"location_flag":"StructureInactive","location_id":1022890269606,"location_type":"other","quantity":1,"type_id":2027}
There is no ihub with item_id 1022890269606.

@CarbonAlabel

This comment has been minimized.

Copy link
Member

CarbonAlabel commented May 22, 2018

See #792.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment