Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing data in character stats endpoint #729

Open
Blacksmoke16 opened this issue Jan 20, 2018 · 8 comments

Comments

Projects
None yet
5 participants
@Blacksmoke16
Copy link
Member

commented Jan 20, 2018

Bug

The previous CREST stats endpoints included more data than the ESI 2017 data. Missing key/values:

Some of these may just be due to me not having data in that category.

[:combat_cap_drainedby_npc,
 :combat_damage_from_players_energy_amount,
 :combat_damage_from_players_energy_num_shots,
 :combat_damage_from_players_smart_bomb_amount,
 :combat_damage_from_players_smart_bomb_num_shots,
 :combat_damage_to_players_bomb_amount,
 :combat_damage_to_players_bomb_num_shots,
 :combat_damage_to_players_energy_amount,
 :combat_damage_to_players_energy_num_shots,
 :combat_damage_to_players_smart_bomb_amount,
 :combat_damage_to_players_smart_bomb_num_shots,
 :combat_deaths_high_sec,
 :combat_deaths_pod_high_sec,
 :combat_deaths_pod_low_sec,
 :combat_duel_requested,
 :combat_kills_high_sec,
 :combat_kills_pod_high_sec,
 :combat_repair_armor_remote_amount,
 :combat_repair_armor_self_amount,
 :combat_repair_shield_self_amount,
 :combat_self_destructs,
 :industry_jobs_completed_copy_blueprint,
 :industry_jobs_completed_manufacture,
 :industry_jobs_completed_manufacture_other,
 :industry_jobs_completed_manufacture_other_quantity,
 :industry_jobs_started_copy_blueprint,
 :industry_jobs_started_manufacture,
 :market_modify_market_order,
 :module_activations_armor_hardener,
 :module_activations_armor_repair_unit,
 :module_activations_bomb_launcher,
 :module_activations_cloaking_device,
 :module_activations_cynosural_field,
 :module_activations_damage_control,
 :module_activations_energy_weapon,
 :module_activations_interdiction_sphere_launcher,
 :module_activations_propulsion_module,
 :module_activations_remote_armor_repairer,
 :module_activations_remote_sensor_damper,
 :module_activations_sensor_booster,
 :module_activations_shield_booster,
 :module_activations_shield_hardener,
 :module_activations_smart_bomb,
 :module_activations_stasis_web,
 :module_activations_target_painter,
 :module_activations_tracking_computer,
 :module_activations_tractor_beam,
 :module_activations_warp_scrambler,
 :social_add_contact_bad,
 :social_add_contact_high,
 :social_add_contact_horrible,
 :social_add_contact_neutral,
 :social_mails_received,
 :social_mails_sent,
 :travel_acceleration_gate_activations,

Also would be cool to see like total_ly_traveled or total_nitrogen_isotope_usage etc

@a-tal

This comment has been minimized.

Copy link
Contributor

commented Jan 22, 2018

all attributes here are optional. anything with a zero value is stripped from the return

@Blacksmoke16

This comment has been minimized.

Copy link
Member Author

commented Jan 22, 2018

That probably accounts for some of them, but I definitely sent mails, lit cynos etc and those are not reported.

@Aradina

This comment has been minimized.

Copy link

commented Jan 22, 2018

Definitely things missing. I lived in a wormhole for most of the year without ever cloaking once according to it. I also didn't send or receive any mail, repair myself with an armor rep, gave myself 3200 cap without using a cap booster, activate a HIC bubble, I hacked 16 things without activating a hacking module and I managed to drain 7 cap without activating a neut.

@a-tal

This comment has been minimized.

Copy link
Contributor

commented Jan 22, 2018

can confirm mails seems to have an issue. i'm currently running a script to find all columns with a lack of distinct values. results soon™

@a-tal

This comment has been minimized.

Copy link
Contributor

commented Jan 22, 2018

the following attributes have only 0 values for everyone, in 2017:

combat:damage_from_players_energy_amount
combat:damage_from_players_energy_num_shots
combat:damage_from_players_fighter_bomber_amount
combat:damage_from_players_fighter_bomber_num_shots
combat:damage_from_players_fighter_drone_amount
combat:damage_from_players_fighter_drone_num_shots
combat:damage_from_players_smart_bomb_amount
combat:damage_from_players_smart_bomb_num_shots
combat:damage_from_players_super_amount
combat:damage_from_players_super_num_shots
combat:damage_from_structures_total_amount
combat:damage_from_structures_total_num_shots
combat:damage_to_players_energy_amount
combat:damage_to_players_energy_num_shots
combat:damage_to_players_fighter_bomber_amount
combat:damage_to_players_fighter_bomber_num_shots
combat:damage_to_players_fighter_drone_amount
combat:damage_to_players_fighter_drone_num_shots
combat:damage_to_players_smart_bomb_amount
combat:damage_to_players_smart_bomb_num_shots
combat:damage_to_players_super_amount
combat:damage_to_players_super_num_shots
industry:jobs_completed_manufacture_asteroid
industry:jobs_completed_manufacture_asteroid_quantity
module:activations_armor_hardener
module:activations_armor_repair_unit
module:activations_armor_resistance_shift_hardener
module:activations_automated_targeting_system
module:activations_bastion
module:activations_capacitor_booster
module:activations_cargo_scanner
module:activations_cloaking_device
module:activations_clone_vat_bay
module:activations_cynosural_field
module:activations_damage_control
module:activations_data_miners
module:activations_drone_control_unit
module:activations_drone_tracking_modules
module:activations_eccm
module:activations_ecm
module:activations_ecm_burst
module:activations_energy_destabilizer
module:activations_energy_vampire
module:activations_energy_weapon
module:activations_fueled_armor_repairer
module:activations_fueled_shield_booster
module:activations_gang_coordinator
module:activations_gas_cloud_harvester
module:activations_hull_repair_unit
module:activations_micro_jump_drive
module:activations_passive_targeting_system
module:activations_projected_eccm
module:activations_propulsion_module
module:activations_remote_armor_repairer
module:activations_remote_capacitor_transmitter
module:activations_remote_ecm_burst
module:activations_remote_hull_repairer
module:activations_remote_sensor_booster
module:activations_remote_sensor_damper
module:activations_remote_shield_booster
module:activations_remote_tracking_computer
module:activations_salvager
module:activations_sensor_booster
module:activations_shield_booster
module:activations_shield_hardener
module:activations_ship_scanner
module:activations_siege
module:activations_smart_bomb
module:activations_stasis_web
module:activations_super_weapon
module:activations_survey_scanner
module:activations_target_breaker
module:activations_target_painter
module:activations_tracking_computer
module:activations_tracking_disruptor
module:activations_tractor_beam
module:activations_triage
module:activations_warp_disrupt_field_generator
module:activations_warp_scrambler
orbital:strike_characters_killed
orbital:strike_damage_to_players_armor_amount
orbital:strike_damage_to_players_shield_amount
social:mails_received
social:mails_sent

we're looking into it. unfortunately that means we'll have to regenerate the data, which takes a non-trivial amount of time.

@Blacksmoke16

This comment has been minimized.

Copy link
Member Author

commented Mar 11, 2018

Any update on this?

@Blacksmoke16

This comment has been minimized.

Copy link
Member Author

commented Apr 9, 2018

Take that as a no :(

@HakShak

This comment has been minimized.

Copy link
Contributor

commented Apr 9, 2018

This is being heavily re-evaluated. Basically we found a really old dragon in this data that isn't tenable. We are aiming to lock a subset of this data down in newer features coming out Soon(tm). Again, this will start as a subset that we must build up over time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.