New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/characters/{character_id}/assets/ returns implants/skills/wardrobe items for some characters #911

Closed
wvdvegt opened this Issue May 11, 2018 · 5 comments

Comments

Projects
None yet
4 participants
@wvdvegt
Copy link

wvdvegt commented May 11, 2018

Bug

the v1 endpoint:

/characters/{character_id}/assets/

returns implants/skills and/or wardrobe items for some characters as part of the inventory.
This without specifying that implants can be queried (so no scope for it).

The character returned by this as a container (but not for all pilots and not with all item types). So I have 3 pilots with skills+implants+wardrobe) , one with only implants an and one that does not have his character returned as a asset container.

Request

I used:
/characters/{character_id}/assets/
esi-assets.read_assets.v1

I read all pages until less than a 1000 where returned.

Response

For some characters not only assets in stations are returned, but also the character itself containing items like implants, learned skills and/or wardrobe items.

Status Code

200

Headers

Body

One item returned is:

  {
    "is_singleton" : true,
    "item_id" : 165495902,
    "location_flag" : "Skill",
    "location_id" : 148948054,
    "location_type" : "other",
    "quantity" : 1,
    "type_id" : 3303
  }

Expected

As there are other endpoints covering these (at least the skills/implants) I would expect them not to be present in this endpoint (especially as implants requires a separate scope not present in my app).

200

Checklist

Check all boxes that apply to this issue:

  • Bug description is provided
  • Request path is provided
  • Response status code is provided
  • Response headers are provided
  • Response body is provided
  • Expected response is provided

@a-tal a-tal self-assigned this May 11, 2018

@a-tal

This comment has been minimized.

Copy link
Contributor

a-tal commented May 11, 2018

thanks for this. the only items you should see now where location_id == character_id are wardrobe items, because there's no other route for retrieving that information.

@a-tal a-tal closed this May 11, 2018

@CarbonAlabel

This comment has been minimized.

Copy link
Member

CarbonAlabel commented May 11, 2018

@a-tal what about those who can't see our clothes in the assets list?

@a-tal

This comment has been minimized.

Copy link
Contributor

a-tal commented May 11, 2018

@CarbonAlabel I'd have to look into why it's only returned sometimes. it wouldn't surprise me if "characters who haven't changed clothes for a long time" played into it somehow though.

feel free to make a separate issue for that, will require some monolith investigation

@GoldenGnu

This comment has been minimized.

Copy link
Member

GoldenGnu commented May 11, 2018

I don't know if you already excluded them, but, at one point, active boosters was also returned.
Maybe you already excluded them, in that case, sorry to waste time...

@wvdvegt

This comment has been minimized.

Copy link
Author

wvdvegt commented May 11, 2018

I do not see any characters anymore, even the one that had the wardrobe item.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment