Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Historical PI items displaying in assets #943

Closed
Dusty-Meg opened this issue May 30, 2018 · 1 comment
Closed

Historical PI items displaying in assets #943

Dusty-Meg opened this issue May 30, 2018 · 1 comment
Assignees

Comments

@Dusty-Meg
Copy link
Contributor

@Dusty-Meg Dusty-Meg commented May 30, 2018

Bug

While requesting a characters assets, Planetary structures are now appearing from planets that have been deleted..
In one occasion from a planet that I used and deleted in 2010.

Request

GET /v3/characters/{character_id}/assets/

Response

Body

  {
    "is_singleton": false,
    "item_id": 1001052229117,
    "location_flag": "AutoFit",
    "location_id": 40016092,
    "location_type": "other",
    "quantity": 1,
    "type_id": 2848
  },
  {
    "is_singleton": false,
    "item_id": 1001052562605,
    "location_flag": "AutoFit",
    "location_id": 40016092,
    "location_type": "other",
    "quantity": 1,
    "type_id": 2848
  }

Expected

The above items to not be shown on the assets at all, the planet was supposedly decommissioned in 2010.

Checklist

Check all boxes that apply to this issue:

  • Bug description is provided
  • Request path is provided
  • Response status code is provided
  • Response headers are provided
  • Response body is provided
  • Expected response is provided
GoldenGnu added a commit to GoldenGnu/jeveassets that referenced this issue Jun 1, 2018
GoldenGnu added a commit to GoldenGnu/jeveassets that referenced this issue Jun 1, 2018
GoldenGnu added a commit to GoldenGnu/jeveassets that referenced this issue Jun 1, 2018
@tsuthers-ccpgames tsuthers-ccpgames self-assigned this Jun 18, 2018
@tsuthers-ccpgames
Copy link
Contributor

@tsuthers-ccpgames tsuthers-ccpgames commented Jun 21, 2018

I've submitted a change to formalise Gnu's fix in the proc. There are no valid assets located on planets (except arguably your current PI installations which are available through the PI endpoints), so I am simply hiding everything located on planets. Next time there's a server patch they'll all disappear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants