Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using -square seems to take forever #55

Closed
mosic opened this issue Nov 17, 2019 · 4 comments
Closed

Using -square seems to take forever #55

mosic opened this issue Nov 17, 2019 · 4 comments
Assignees

Comments

@mosic
Copy link

mosic commented Nov 17, 2019

I used caire with a couple of images, and aside from the girl example in the README, I haven't gotten it to actually provide an output with any of the images I tried, even after 10-15mins. I have tried using different flags to make it faster, but it seems to be stuck processing forever.

Here's an example to reproduce my issue:

wget -O input.jpg "https://unsplash.com/photos/CaDoHQ3fB8w/download?force=true"
caire -in input.jpg -out output.jpg -face=false -scale -square -width=500 -height=500 -blur=0

Any suggestions?

@esimov esimov self-assigned this Nov 18, 2019
esimov added a commit that referenced this issue Nov 18, 2019
esimov added a commit that referenced this issue Nov 18, 2019
@esimov
Copy link
Owner

esimov commented Nov 18, 2019

Thanks for letting me know this issue. It was a missing conditional check in the image processing part. This issue should have been fixed now. Please test it and let me know if it's working on your end.

Below is the end result obtained running the command you have used.

output

@mosic
Copy link
Author

mosic commented Nov 18, 2019

That was fast! Yeah, the issue seems to be fixed on my side as well. Thanks for looking into it.

I tried it with another image and got a weird result though, maybe it should be a separate issue:

wget -O input.jpg "https://unsplash.com/photos/TjOH0ymV7oU/download?force=true"
caire -in input.jpg -out output.jpg -face=false -scale -square -width=500 -height=500 -blur=0

This is the original:

input

And this is the output:

output

@esimov
Copy link
Owner

esimov commented Nov 18, 2019

This is not related to some bug or issue in the algorithm, since it has a "dense" background the nature of this image does not permits to generate a good output.

@mosic
Copy link
Author

mosic commented Nov 18, 2019

Ah, fair enough. 👍

@mosic mosic closed this as completed Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants