Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter REST commands by subcategory as well #2426

Merged
merged 1 commit into from Sep 2, 2019
Merged

Conversation

fenek
Copy link
Member

@fenek fenek commented Aug 22, 2019

This PR fixes #2278

Commands in REST weren't filtered by subcategory, so for any two commands with the same method and category but different subcategories, the handler will crash and return 500 error.

Tests that would have detected the problem were for some reason disabled.

Copy link
Collaborator

@NelsonVides NelsonVides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
PS: CircleCI failure is the unstable test I'm trying to fix right now, we can ignore it.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Aug 22, 2019

7036.1 / Erlang 22.0 / small_tests / 87f9172
Reports root / small


7036.2 / Erlang 22.0 / internal_mnesia / 87f9172
Reports root/ big
OK: 1261 / Failed: 0 / User-skipped: 175 / Auto-skipped: 0


7036.3 / Erlang 22.0 / odbc_mssql_mnesia / 87f9172
Reports root/ big
OK: 3168 / Failed: 0 / User-skipped: 284 / Auto-skipped: 0


7036.4 / Erlang 22.0 / mysql_redis / 87f9172
Reports root/ big
OK: 3166 / Failed: 0 / User-skipped: 286 / Auto-skipped: 0


7036.7 / Erlang 22.0 / elasticsearch_and_cassandra_mnesia / 87f9172
Reports root/ big
OK: 548 / Failed: 0 / User-skipped: 55 / Auto-skipped: 0


7036.6 / Erlang 22.0 / ldap_mnesia / 87f9172
Reports root/ big
OK: 1228 / Failed: 0 / User-skipped: 208 / Auto-skipped: 0


7036.5 / Erlang 22.0 / riak_mnesia / 87f9172
Reports root/ big
OK: 1493 / Failed: 0 / User-skipped: 176 / Auto-skipped: 0


7036.9 / Erlang 21.3 / pgsql_mnesia / 87f9172
Reports root/ big / small
OK: 3181 / Failed: 0 / User-skipped: 271 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Aug 23, 2019

Codecov Report

Merging #2426 into master will decrease coverage by 0.38%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2426      +/-   ##
==========================================
- Coverage   72.62%   72.23%   -0.39%     
==========================================
  Files         340      340              
  Lines       29392    29392              
==========================================
- Hits        21345    21231     -114     
- Misses       8047     8161     +114
Impacted Files Coverage Δ
src/mongoose_commands.erl 75.36% <ø> (-1.48%) ⬇️
src/mongoose_api_client.erl 0% <0%> (ø) ⬆️
src/mongoose_api_admin.erl 82.45% <100%> (ø) ⬆️
src/mod_auth_token_rdbms.erl 0% <0%> (-100%) ⬇️
src/inbox/mod_inbox_rdbms_pgsql.erl 0% <0%> (-100%) ⬇️
src/rdbms/mongoose_rdbms_pgsql.erl 0% <0%> (-85.3%) ⬇️
src/mod_auth_token.erl 0% <0%> (-82.84%) ⬇️
src/rdbms/mongoose_rdbms_pgsql_codec_boolean.erl 0% <0%> (-77.78%) ⬇️
src/mod_keystore.erl 0% <0%> (-77.09%) ⬇️
src/mod_keystore_mnesia.erl 0% <0%> (-71.43%) ⬇️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79fcb6a...7ce33b1. Read the comment docs.

@michalwski michalwski merged commit 112e784 into master Sep 2, 2019
@michalwski michalwski deleted the issue-2278 branch September 2, 2019 18:22
@fenek fenek added this to the 3.4.0++ milestone Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REST API DELETE /contacts/{user}/{contact} got 500
4 participants