Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly convert binary to atom where possible #2445

Merged
merged 1 commit into from Sep 10, 2019
Merged

Explicitly convert binary to atom where possible #2445

merged 1 commit into from Sep 10, 2019

Conversation

michalwski
Copy link
Contributor

It is a port of #2444 for the previous release (3.4)

@michalwski
explicitly convert binary to atom where possible
6b8a4b7 
in other cases make sure the used encoding is utf8 and not latin1
@mongoose-im
Copy link
Collaborator

mongoose-im commented Sep 9, 2019 •
edited

7130.1 / Erlang 20.3 / small_tests / 56b6a9d
Reports root / small

7130.2 / Erlang 20.3 / internal_mnesia / 56b6a9d
Reports root/ big
OK: 1297 / Failed: 3 / User-skipped: 167 / Auto-skipped: 0

sm_SUITE:parallel:subscription_requests_are_buffered_properly 
{error,{{badmatch,false},
    [{escalus_session,stream_management,2,
              [{file,"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
               {line,240}]},
     {escalus_connection,connection_step,2,
               [{file,"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
                {line,154}]},
     {lists,foldl,3,[{file,"lists.erl"},{line,1263}]},
     {escalus_connection,start,2,
               [{file,"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
                {line,138}]},
     {sm_SUITE,'-subscription_requests_are_buffered_properly/1-fun-3-',6,
           [{file,"sm_SUITE.erl"},{line,848}]},
     {escalus_story,story,4,
            [{file,"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1546}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1062}]}]}}

Report log

sm_SUITE:parallel:subscription_requests_are_buffered_properly 
{error,{{badmatch,false},
    [{escalus_session,stream_management,2,
              [{file,"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
               {line,240}]},
     {escalus_connection,connection_step,2,
               [{file,"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
                {line,154}]},
     {lists,foldl,3,[{file,"lists.erl"},{line,1263}]},
     {escalus_connection,start,2,
               [{file,"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
                {line,138}]},
     {sm_SUITE,'-subscription_requests_are_buffered_properly/1-fun-3-',6,
           [{file,"sm_SUITE.erl"},{line,848}]},
     {escalus_story,story,4,
            [{file,"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1546}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1062}]}]}}

Report log

sm_SUITE:parallel:subscription_requests_are_buffered_properly 
{error,{{badmatch,false},
    [{escalus_session,stream_management,2,
              [{file,"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
               {line,240}]},
     {escalus_connection,connection_step,2,
               [{file,"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
                {line,154}]},
     {lists,foldl,3,[{file,"lists.erl"},{line,1263}]},
     {escalus_connection,start,2,
               [{file,"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
                {line,138}]},
     {sm_SUITE,'-subscription_requests_are_buffered_properly/1-fun-3-',6,
           [{file,"sm_SUITE.erl"},{line,848}]},
     {escalus_story,story,4,
            [{file,"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1546}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1062}]}]}}

Report log

7130.3 / Erlang 20.3 / odbc_mssql_mnesia / 56b6a9d
Reports root/ big
OK: 3159 / Failed: 0 / User-skipped: 278 / Auto-skipped: 0

7130.5 / Erlang 20.3 / elasticsearch_and_cassandra_mnesia / 56b6a9d
Reports root/ big
OK: 548 / Failed: 0 / User-skipped: 55 / Auto-skipped: 0

7130.4 / Erlang 20.3 / ldap_mnesia / 56b6a9d
Reports root/ big
OK: 1240 / Failed: 9 / User-skipped: 206 / Auto-skipped: 0

pubsub_SUITE:tree+basic:request_all_items_test 
{error,{{badmatch,false},
    [{pubsub_tools,check_response,2,
             [{file,"pubsub_tools.erl"},{line,472}]},
     {pubsub_tools,receive_response,3,
             [{file,"pubsub_tools.erl"},{line,462}]},
     {pubsub_tools,receive_and_check_response,4,
             [{file,"pubsub_tools.erl"},{line,452}]},
     {escalus_story,story,4,
            [{file,"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1546}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1062}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,994}]}]}}

Report log

pubsub_SUITE:tree+basic:publish_only_retract_items_scope_test 
{error,{{badmatch,false},
    [{pubsub_tools,check_response,2,
             [{file,"pubsub_tools.erl"},{line,472}]},
     {pubsub_tools,receive_response,3,
             [{file,"pubsub_tools.erl"},{line,462}]},
     {pubsub_tools,receive_and_check_response,4,
             [{file,"pubsub_tools.erl"},{line,452}]},
     {escalus_story,story,4,
            [{file,"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1546}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1062}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,994}]}]}}

Report log

pubsub_SUITE:tree+basic:purge_all_items_test 
{error,{{badmatch,false},
    [{pubsub_tools,check_response,2,
             [{file,"pubsub_tools.erl"},{line,472}]},
     {pubsub_tools,receive_response,3,
             [{file,"pubsub_tools.erl"},{line,462}]},
     {pubsub_tools,receive_and_check_response,4,
             [{file,"pubsub_tools.erl"},{line,452}]},
     {escalus_story,story,4,
            [{file,"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1546}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1062}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,994}]}]}}

Report log

pubsub_SUITE:tree+basic:retract_test 
{error,{{badmatch,false},
    [{pubsub_tools,check_response,2,
             [{file,"pubsub_tools.erl"},{line,472}]},
     {pubsub_tools,receive_response,3,
             [{file,"pubsub_tools.erl"},{line,462}]},
     {pubsub_tools,receive_and_check_response,4,
             [{file,"pubsub_tools.erl"},{line,452}]},
     {pubsub_SUITE,'-retract_test/1-fun-0-',2,
             [{file,"pubsub_SUITE.erl"},{line,625}]},
     {escalus_story,story,4,
            [{file,"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1546}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1062}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,994}]}]}}

Report log

pubsub_SUITE:tree+basic:request_particular_item_test 
{error,{{badmatch,false},
    [{pubsub_tools,check_response,2,
             [{file,"pubsub_tools.erl"},{line,472}]},
     {pubsub_tools,receive_response,3,
             [{file,"pubsub_tools.erl"},{line,462}]},
     {pubsub_tools,receive_and_check_response,4,
             [{file,"pubsub_tools.erl"},{line,452}]},
     {escalus_story,story,4,
            [{file,"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1546}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1062}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,994}]}]}}

Report log

pubsub_SUITE:tree+basic:subscribe_options_separate_request_test 
{error,{{badmatch,false},
    [{pubsub_tools,check_response,2,
             [{file,"pubsub_tools.erl"},{line,472}]},
     {pubsub_tools,receive_response,3,
             [{file,"pubsub_tools.erl"},{line,462}]},
     {pubsub_tools,receive_and_check_response,4,
             [{file,"pubsub_tools.erl"},{line,452}]},
     {escalus_story,story,4,
            [{file,"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1546}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1062}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,994}]}]}}

Report log

pubsub_SUITE:tree+basic:retract_when_user_goes_offline_test 
{error,{{badmatch,false},
    [{pubsub_tools,check_response,2,
             [{file,"pubsub_tools.erl"},{line,472}]},
     {pubsub_tools,receive_response,3,
             [{file,"pubsub_tools.erl"},{line,462}]},
     {pubsub_tools,receive_and_check_response,4,
             [{file,"pubsub_tools.erl"},{line,452}]},
     {escalus_story,story,4,
            [{file,"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1546}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1062}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,994}]}]}}

Report log

pubsub_SUITE:tree+hometree_specific:deleting_parent_path_deletes_children 
{error,{{badmatch,false},
    [{pubsub_tools,check_response,2,
             [{file,"pubsub_tools.erl"},{line,472}]},
     {pubsub_tools,receive_response,3,
             [{file,"pubsub_tools.erl"},{line,462}]},
     {pubsub_tools,receive_and_check_response,4,
             [{file,"pubsub_tools.erl"},{line,452}]},
     {pubsub_SUITE,'-deleting_parent_path_deletes_children/1-fun-0-',1,
             [{file,"pubsub_SUITE.erl"},{line,1815}]},
     {escalus_story,story,4,
            [{file,"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1546}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1062}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,994}]}]}}

Report log

mod_global_distrib_SUITE:mod_global_distrib:test_pm_with_ungraceful_reconnection_to_different_server 
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,<<"eve37.888654@localhost/res1">>,escalus_tcp,
          <0.20073.1>,
          [{event_manager,<0.20064.1>},
           {server,<<"localhost">>},
           {username,<<"eve37.888654">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.20064.1>},
            {server,<<"localhost">>},
            {username,<<"eve37.888654">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"eve37.888654">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"eve37.888654">>},
           {server,<<"localhost">>},
           {password,<<"password">>},
           {port,5222},
           {stream_management,true},
           {stream_id,<<"C81554AAA7011BBC">>}]},
        10000],
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {mod_global_distrib_SUITE,
       '-test_pm_with_ungraceful_reconnection_to_different_server/1-fun-0-',
       4,
       [{file,"mod_global_distrib_SUITE.erl"},{line,610}]},
     {escalus_story,story,4,
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
        {line,72}]},
    ...

Report log

7130.8 / Erlang 21.3 / mysql_redis / 56b6a9d
Reports root/ big
OK: 3157 / Failed: 0 / User-skipped: 280 / Auto-skipped: 0

7130.7 / Erlang 21.3 / pgsql_mnesia / 56b6a9d
Reports root/ big / small
OK: 3194 / Failed: 1 / User-skipped: 246 / Auto-skipped: 0

pubsub_SUITE:tree+hometree_specific:disco_node_children_by_path_prefix 
{error,{{badmatch,false},
    [{pubsub_tools,check_response,2,
             [{file,"pubsub_tools.erl"},{line,472}]},
     {pubsub_tools,receive_response,3,
             [{file,"pubsub_tools.erl"},{line,462}]},
     {pubsub_tools,receive_and_check_response,4,
             [{file,"pubsub_tools.erl"},{line,452}]},
     {pubsub_SUITE,'-disco_node_children_by_path_prefix/1-fun-0-',2,
             [{file,"pubsub_SUITE.erl"},{line,1796}]},
     {escalus_story,story,4,
            [{file,"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1562}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1080}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1012}]}]}}

Report log

7130.9 / Erlang 21.3 / riak_mnesia / 56b6a9d
Reports root/ big / small
OK: 1505 / Failed: 0 / User-skipped: 149 / Auto-skipped: 0

7130.2 / Erlang 20.3 / internal_mnesia / 56b6a9d
Reports root/ big
OK: 1254 / Failed: 0 / User-skipped: 167 / Auto-skipped: 0

fenek
fenek approved these changes Sep 9, 2019
View reviewed changes
Copy link
Member

@fenek fenek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for Travis

@codecov
Copy link

codecov bot commented Sep 10, 2019 •
edited

Codecov Report

Merging #2445 into rel-3.4 will decrease coverage by 0.56%.
The diff coverage is 78.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##           rel-3.4   #2445      +/-   ##
==========================================
- Coverage    78.27%   77.7%   -0.57%     
==========================================
  Files          335     335              
  Lines        29317   29339      +22     
==========================================
- Hits         22949   22799     -150     
- Misses        6368    6540     +172
Impacted Files Coverage Δ
src/ejabberd_zlib.erl 67.56% <ø> (ø) ⬆️
src/mod_commands.erl 86.27% <100%> (+0.27%) ⬆️
src/mod_blocking.erl 86.66% <100%> (+0.36%) ⬆️
src/mod_auth_token.erl 85.4% <100%> (+0.32%) ⬆️
src/auth/ejabberd_auth_jwt.erl 89.13% <100%> (ø) ⬆️
src/mod_muc_room.erl 76.62% <100%> (-1.18%) ⬇️
src/pubsub/pubsub_form_utils.erl 57.69% <14.28%> (-2.31%) ⬇️
src/pubsub/mod_pubsub.erl 72.4% <92.85%> (+0.15%) ⬆️
src/inbox/mod_inbox_rdbms_mysql.erl 0% <0%> (-100%) ⬇️
src/event_pusher/mod_event_pusher_rabbit.erl 0% <0%> (-97.02%) ⬇️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c21254b...6b8a4b7. Read the comment docs.

@fenek fenek merged commit ce97795 into rel-3.4 Sep 10, 2019
@fenek fenek deleted the binary_to_atom_fix_for_rel-3.4 branch September 10, 2019 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fenek fenek fenek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@michalwski @mongoose-im @fenek