New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
System Metrics - prod node GA Tracking ID #2610
Conversation
7835.1 / Erlang 22.0 / small_tests / 310cb81 7835.2 / Erlang 22.0 / internal_mnesia / 310cb81 7835.3 / Erlang 22.0 / odbc_mssql_mnesia / 310cb81 7835.4 / Erlang 22.0 / mysql_redis / 310cb81 7835.7 / Erlang 22.0 / elasticsearch_and_cassandra_mnesia / 310cb81 7835.5 / Erlang 22.0 / riak_mnesia / 310cb81 7835.6 / Erlang 22.0 / ldap_mnesia / 310cb81 7835.9 / Erlang 21.3 / pgsql_mnesia / 310cb81 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I've found only some cosmetic things to improve.
Codecov Report
@@ Coverage Diff @@
## master #2610 +/- ##
==========================================
+ Coverage 76.81% 79.03% +2.22%
==========================================
Files 354 354
Lines 30040 30040
==========================================
+ Hits 23074 23743 +669
+ Misses 6966 6297 -669
Continue to review full report at Codecov.
|
7836.1 / Erlang 22.0 / small_tests / 9b02d3a 7836.2 / Erlang 22.0 / internal_mnesia / 9b02d3a 7836.3 / Erlang 22.0 / odbc_mssql_mnesia / 9b02d3a pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription{error,
{{badmatch,
[{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_unsubscribe_after_presence_unsubscription_83.494314@localhost">>},
{<<"to">>,
<<"bob_unsubscribe_after_presence_unsubscription_83.494314@localhost/res1">>},
{<<"type">>,<<"headline">>}],
[{xmlel,<<"event">>,
[{<<"xmlns">>,
<<"http://jabber.org/protocol/pubsub#event">>}],
[{xmlel,<<"items">>,
[{<<"node">>,<<"ReB2XVml4oIP4l4RdunyqA==">>}],
[{xmlel,<<"item">>,
[{<<"id">>,<<"salmon">>}],
[{xmlel,<<"entry">>,
[{<<"xmlns">>,
<<"http://www.w3.org/2005/Atom">>}],
[]}]}]}]},
{xmlel,<<"headers">>,
[{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
[]}]}]},
[{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
[{file,
"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/ejabberd_tests/tests/pep_SUITE.erl"},
{line,300}]},
{escalus_story,story,4,
[{file,
"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1748}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1263}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1195}]}]}} 7836.4 / Erlang 22.0 / mysql_redis / 9b02d3a 7836.5 / Erlang 22.0 / riak_mnesia / 9b02d3a 7836.7 / Erlang 22.0 / elasticsearch_and_cassandra_mnesia / 9b02d3a 7836.6 / Erlang 22.0 / ldap_mnesia / 9b02d3a 7836.9 / Erlang 21.3 / pgsql_mnesia / 9b02d3a |
Co-Authored-By: Nelson Vides <nelson.vides@erlang-solutions.com>
This PR: