Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System Metrics - prod node GA Tracking ID #2610

Merged
merged 4 commits into from Jan 28, 2020
Merged

Conversation

janciesla8818
Copy link
Contributor

This PR:

  • enables system metrics service by default on all nodes
  • new GA Tracking ID is added for prod nodes
  • metrics tests refactoring

@mongoose-im
Copy link
Collaborator

mongoose-im commented Jan 27, 2020

7835.1 / Erlang 22.0 / small_tests / 310cb81
Reports root / small


7835.2 / Erlang 22.0 / internal_mnesia / 310cb81
Reports root/ big
OK: 1377 / Failed: 0 / User-skipped: 155 / Auto-skipped: 0


7835.3 / Erlang 22.0 / odbc_mssql_mnesia / 310cb81
Reports root/ big
OK: 2612 / Failed: 0 / User-skipped: 200 / Auto-skipped: 0


7835.4 / Erlang 22.0 / mysql_redis / 310cb81
Reports root/ big
OK: 2607 / Failed: 0 / User-skipped: 205 / Auto-skipped: 0


7835.7 / Erlang 22.0 / elasticsearch_and_cassandra_mnesia / 310cb81
Reports root/ big
OK: 328 / Failed: 0 / User-skipped: 28 / Auto-skipped: 0


7835.5 / Erlang 22.0 / riak_mnesia / 310cb81
Reports root/ big
OK: 1510 / Failed: 0 / User-skipped: 162 / Auto-skipped: 0


7835.6 / Erlang 22.0 / ldap_mnesia / 310cb81
Reports root/ big
OK: 1342 / Failed: 0 / User-skipped: 190 / Auto-skipped: 0


7835.9 / Erlang 21.3 / pgsql_mnesia / 310cb81
Reports root/ big / small
OK: 2625 / Failed: 0 / User-skipped: 187 / Auto-skipped: 0

Copy link
Contributor

@michalwski michalwski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I've found only some cosmetic things to improve.

big_tests/tests/service_mongoose_system_metrics_SUITE.erl Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 27, 2020

Codecov Report

Merging #2610 into master will increase coverage by 2.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2610      +/-   ##
==========================================
+ Coverage   76.81%   79.03%   +2.22%     
==========================================
  Files         354      354              
  Lines       30040    30040              
==========================================
+ Hits        23074    23743     +669     
+ Misses       6966     6297     -669
Impacted Files Coverage Δ
...system_metrics/service_mongoose_system_metrics.erl 69.81% <ø> (ø) ⬆️
src/event_pusher/mod_event_pusher_sns.erl 85.13% <0%> (-5.41%) ⬇️
src/mam/mod_mam_meta.erl 94.25% <0%> (-2.3%) ⬇️
src/mam/mod_mam.erl 89.09% <0%> (-0.95%) ⬇️
src/muc_light/mod_muc_light.erl 83.25% <0%> (-0.94%) ⬇️
src/ejabberd_sm.erl 75.46% <0%> (-0.32%) ⬇️
src/mod_roster.erl 79.58% <0%> (-0.24%) ⬇️
src/mod_muc_log.erl 77.69% <0%> (ø) ⬆️
src/ejabberd_c2s.erl 88.51% <0%> (ø) ⬆️
src/mod_muc_room.erl 77.54% <0%> (+0.11%) ⬆️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22bfe35...0925db5. Read the comment docs.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Jan 27, 2020

7836.1 / Erlang 22.0 / small_tests / 9b02d3a
Reports root / small


7836.2 / Erlang 22.0 / internal_mnesia / 9b02d3a
Reports root/ big
OK: 1377 / Failed: 0 / User-skipped: 155 / Auto-skipped: 0


7836.3 / Erlang 22.0 / odbc_mssql_mnesia / 9b02d3a
Reports root/ big
OK: 2619 / Failed: 1 / User-skipped: 200 / Auto-skipped: 0

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription
{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_unsubscribe_after_presence_unsubscription_83.494314@localhost">>},
         {<<"to">>,
        <<"bob_unsubscribe_after_presence_unsubscription_83.494314@localhost/res1">>},
         {<<"type">>,<<"headline">>}],
        [{xmlel,<<"event">>,
           [{<<"xmlns">>,
           <<"http://jabber.org/protocol/pubsub#event">>}],
           [{xmlel,<<"items">>,
            [{<<"node">>,<<"ReB2XVml4oIP4l4RdunyqA==">>}],
            [{xmlel,<<"item">>,
               [{<<"id">>,<<"salmon">>}],
               [{xmlel,<<"entry">>,
                  [{<<"xmlns">>,
                  <<"http://www.w3.org/2005/Atom">>}],
                  []}]}]}]},
         {xmlel,<<"headers">>,
           [{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
           []}]}]},
   [{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
      [{file,
         "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/ejabberd_tests/tests/pep_SUITE.erl"},
       {line,300}]},
    {escalus_story,story,4,
      [{file,
         "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1748}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1263}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1195}]}]}}

Report log


7836.4 / Erlang 22.0 / mysql_redis / 9b02d3a
Reports root/ big
OK: 2607 / Failed: 0 / User-skipped: 205 / Auto-skipped: 0


7836.5 / Erlang 22.0 / riak_mnesia / 9b02d3a
Reports root/ big
OK: 1510 / Failed: 0 / User-skipped: 162 / Auto-skipped: 0


7836.7 / Erlang 22.0 / elasticsearch_and_cassandra_mnesia / 9b02d3a
Reports root/ big
OK: 328 / Failed: 0 / User-skipped: 28 / Auto-skipped: 0


7836.6 / Erlang 22.0 / ldap_mnesia / 9b02d3a
Reports root/ big
OK: 1342 / Failed: 0 / User-skipped: 190 / Auto-skipped: 0


7836.9 / Erlang 21.3 / pgsql_mnesia / 9b02d3a
Reports root/ big / small
OK: 2625 / Failed: 0 / User-skipped: 187 / Auto-skipped: 0

@michalwski michalwski added this to the 3.6.0 milestone Jan 28, 2020
Co-Authored-By: Nelson Vides <nelson.vides@erlang-solutions.com>
@michalwski michalwski merged commit 58d7678 into master Jan 28, 2020
@michalwski michalwski deleted the metrics_prod_tracking_id branch January 28, 2020 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants