Add line breaks before ordered and unordered lists. #18

Closed
wants to merge 7 commits into
from

Projects

None yet

3 participants

@beadsland
Contributor

Only substantive changes are lines 170 & 171.

beadsland added some commits May 12, 2012
@beadsland @beadsland beadsland add <br> before ordered and unordered lists
carriage return before unordered and ordered lists
2e2d5b0
@beadsland beadsland fix indentation
AnyEdit plugin converted tabs to spaces, and the result was inconsistent
indentation. Manually reasserted indents to reflect proper nesting.
1b6d66e
@beadsland beadsland newline before definition list (just like ul and ol) abcc607
@beadsland @beadsland beadsland markdown pre rule
leave leading spaces alone

see if replace is taking

pre no longer needs html

set boolean back to true

don't pass pre to xmerl

rule is running, lets see if tab preserved on own

brstrip now respects leading tabs (edown for preformatted)

just match on word boundary

remove extraneous caret
26d92b6
@beadsland
Contributor

Preformatted text was being rendered without whitespace between lines when rendered as HTML.

Converted to markdown format (leading tab), and updated brstrip to respect this.

beadsland added some commits May 22, 2012
@beadsland beadsland space before bracket href links 4d4cc58
@beadsland @beadsland beadsland brstrip match only on spaces, not generic whitespace
only strip trailing spaces (ASCII 32); tabs and newlines are left in
place

revert newlines before ul, ol, dl

test if br is still necessary

strip only spaces at end of lines, not generic whitespace
5a722fa
@beadsland
Owner

brstrip was stripping newlines at end of plain text blocks. Result was that elements were being appended to plain text blocks without intervening whitespace.

This commit fixes brstrip, and reverts changes to dl, ul, and ol meant to fix missing newlines.

Edits to edown_layout reflect cleanup of trailing whitespace and conversion of tabs to spaces.

@uwiger
Contributor
uwiger commented Jun 25, 2012

Hmm, this pull request is still open. Forgive me for being a bit unresponsive and confused, but is there something that still needs pulling?

@norton
Contributor
norton commented Jul 5, 2012

I'm not able to understand the set of patches but I am (**) interested in the "Preformatted text was being rendered without whitespace between lines when rendered as HTML." changes in particular.

** Hmm ... but I'm puzzled because it now seems that GitHub has improved it's rendering of verbatim text blocks.

This verbatim text of this link below used to be displayed on my browser as a single line.

https://github.com/norton/lets#quick-start-recipe

I'm unsure if this used to be an issue of with my browser, markdown, edown, or asciiedoc. Oh well.

@uwiger
Contributor
uwiger commented Jul 5, 2012

Well, some of those issues are annoyingly subtle. I can partly agree with
Richard O'Keefe's rants about Markdown - it holds many surprises when you
try to do something more clever than just straightforward text. :)

BR,
Ulf

2012/7/5 Joseph Wayne Norton <
reply@reply.github.com

I'm not able to understand the set of patches but I am (**) interested in
the "Preformatted text was being rendered without whitespace between lines
when rendered as HTML." changes in particular.

** Hmm ... but I'm puzzled because it now seems that GitHub has improved
it's rendering of verbatim text blocks.

This verbatim text of this link below used to be displayed on my browser
as a single line.

https://github.com/norton/lets#quick-start-recipe

I'm unsure if this used to be an issue of with my browser, markdown,
edown, or asciiedoc. Oh well.


Reply to this email directly or view it on GitHub:
#18 (comment)

@norton
Contributor
norton commented Aug 2, 2012

Just a follow up on my previous comment.

This verbatim text of this link below is now displayed (again) on my browser as a single line.

https://github.com/norton/lets#quick-start-recipe

More strangeness.

@uwiger
Contributor
uwiger commented Mar 25, 2013

@norton, are you still having problems, or can I close this issue?

@norton
Contributor
norton commented Mar 26, 2013

I'm not seeing any such strangeness now. Thanks for asking. Please close this issue.

@uwiger
Contributor
uwiger commented Mar 26, 2013

Ok, will do. Thanks.

@uwiger uwiger closed this Mar 26, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment