Fix missing xml-escape file #18
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
eslint-formatter-checkstylepackage (v9.0.0) was failing when used with ESLint due to a missingxml-escapemodule:Error: Cannot find module './xml-escape' Require stack: - /app/node_modules/eslint-formatter-checkstyle/index.jsThis issue also affected
eslint-formatter-jslint-xmlandeslint-formatter-junit, which also depend on thexml-escape.jsfile.Root Cause
The
filesarray in each package'spackage.jsonexplicitly listed onlyindex.jsandindex.d.ts, which excluded thexml-escape.jsfile required by the XML-based formatters. This was introduced in PR #12.Solution
filesarray from all 10 package.json files inpackages/*9.0.0to9.0.1for all packagesBy removing the
filesarray, npm will now automatically include all necessary files when publishing the packages (based on.npmignoreor default behavior), ensuring thatxml-escape.jsand any other required files are included.Verification
All three XML-based formatters now load and execute successfully:
eslint-formatter-checkstyle- loads xml-escape and formats output correctlyeslint-formatter-jslint-xml- loads xml-escape and formats output correctlyeslint-formatter-junit- loads xml-escape and formats output correctlyOther formatters (compact, json, unix, etc.) continue to work as expected.
Fixes #13
Original prompt
Fixes #17
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.