From 4e454c50b0ef21e310c38f82096a4801023f4ca9 Mon Sep 17 00:00:00 2001 From: Sebastian Good <2230835+scagood@users.noreply.github.com> Date: Tue, 7 May 2024 11:52:30 +0200 Subject: [PATCH 1/2] test: Add tests for #265 --- tests/lib/rules/no-unsupported-features/node-builtins.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/lib/rules/no-unsupported-features/node-builtins.js b/tests/lib/rules/no-unsupported-features/node-builtins.js index 458729e8..2fcf72ce 100644 --- a/tests/lib/rules/no-unsupported-features/node-builtins.js +++ b/tests/lib/rules/no-unsupported-features/node-builtins.js @@ -218,6 +218,10 @@ new RuleTester({ languageOptions: { sourceType: "module" } }).run( }, ], }, + { + code: "new Buffer(123)", + options: [{ version: "6.0.0" }], + }, ], invalid: [ { From 7fad443c807f050aa99a360c8c7cd4b0ddc27aca Mon Sep 17 00:00:00 2001 From: Sebastian Good <2230835+scagood@users.noreply.github.com> Date: Tue, 7 May 2024 11:58:31 +0200 Subject: [PATCH 2/2] chore: Add supported version to Buffer constructor --- lib/unsupported-features/node-builtins-modules/buffer.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/unsupported-features/node-builtins-modules/buffer.js b/lib/unsupported-features/node-builtins-modules/buffer.js index 639c8ac1..1723864f 100644 --- a/lib/unsupported-features/node-builtins-modules/buffer.js +++ b/lib/unsupported-features/node-builtins-modules/buffer.js @@ -23,7 +23,7 @@ const buffer = { }, Buffer: { [READ]: { supported: ["0.1.90"] }, - [CONSTRUCT]: { deprecated: ["6.0.0"] }, + [CONSTRUCT]: { supported: ["0.1.90"], deprecated: ["6.0.0"] }, alloc: { [READ]: { supported: ["5.10.0", "4.5.0"] } }, allocUnsafe: { [READ]: { supported: ["5.10.0", "4.5.0"] } }, allocUnsafeSlow: { [READ]: { supported: ["5.12.0", "4.5.0"] } },