From 1aeca29829b6208ec281ca58ac317a6c83d0cc94 Mon Sep 17 00:00:00 2001 From: Rebecca Stevens Date: Thu, 29 Sep 2022 16:44:31 +1300 Subject: [PATCH] feat!(no-this-expression): remove `no-this-expression` from recommended and lite rulesets --- README.md | 2 +- src/configs/recommended.ts | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 86519f68b..23bb34221 100644 --- a/README.md +++ b/README.md @@ -84,7 +84,7 @@ The [below section](#rules) gives details on which rules are enabled by each rul | ---------------------------------------------------------- | ------------------------------------------------------------------ | :----------------------------------------------------: | :-----------------------------------------: | :--------------------------------------------: | :--------------------------------------: | :------: | :---------------: | | [`no-class`](./docs/rules/no-class.md) | Disallow classes | :heavy_check_mark: | :heavy_check_mark: | :heavy_check_mark: | :heavy_check_mark: | | | | [`no-mixed-type`](./docs/rules/no-mixed-type.md) | Disallow types that contain both callable and non-callable members | :heavy_check_mark: | :heavy_check_mark: | :heavy_check_mark: | :heavy_check_mark: | | :thought_balloon: | -| [`no-this-expression`](./docs/rules/no-this-expression.md) | Disallow `this` access | :heavy_check_mark: | :heavy_check_mark: | :heavy_check_mark: | :heavy_check_mark: | | | +| [`no-this-expression`](./docs/rules/no-this-expression.md) | Disallow `this` access | :heavy_check_mark: | :heavy_check_mark: | | | | | ### No Statements Rules diff --git a/src/configs/recommended.ts b/src/configs/recommended.ts index f2d5c7e22..f86cbe5d5 100644 --- a/src/configs/recommended.ts +++ b/src/configs/recommended.ts @@ -4,6 +4,7 @@ import { Immutability } from "is-immutable-type"; import * as functionalParameters from "~/rules/functional-parameters"; import * as noConditionalStatement from "~/rules/no-conditional-statement"; import * as noLet from "~/rules/no-let"; +import * as noThisExpression from "~/rules/no-this-expression"; import * as noThrowStatement from "~/rules/no-throw-statement"; import * as noTryStatement from "~/rules/no-try-statement"; import * as preferImmutableParameterTypes from "~/rules/prefer-immutable-parameter-types"; @@ -36,6 +37,7 @@ const overrides: Linter.Config = { allowInForLoopInit: true, }, ], + [`functional/${noThisExpression.name}`]: "off", [`functional/${noThrowStatement.name}`]: [ "error", {