Skip to content

Conversation

@MikeMcC399
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request?

Jobs in the workflow .github/workflows/ci-build-all-pm.yml are using inconsistent versions of Node.js and do not align to the usage of Node.js LTS in the main CI workflow workflow.

The workflow is changed to used Node.js LTS consistently.

What changes did you make? (Give an overview)

Add actions/setup-node@v4 to each job in .github/workflows/ci-build-all-pm.yml where it is missing and set all jobs to use the Node.js Active LTS version.

Related Issues

Is there anything you'd like reviewers to focus on?

Check that https://github.com/eslint/css/actions/workflows/ci-build-all-pm.yml completes successfully

@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Mar 24, 2025
@eslint-github-bot
Copy link

Hi @MikeMcC399!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
  • There should be a space following the initial tag and colon, for example 'feat: Message'.
  • The first letter of the tag should be in lowercase

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

@MikeMcC399 MikeMcC399 force-pushed the ci/node-lts-build-install branch from 9ad8296 to 52e3a6e Compare March 24, 2025 14:43
@eslint-github-bot
Copy link

Hi @MikeMcC399!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
  • There should be a space following the initial tag and colon, for example 'feat: Message'.
  • The first letter of the tag should be in lowercase

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

@MikeMcC399 MikeMcC399 changed the title CI: Use consistent Node.js LTS version in CI Build install workflow ci: Use consistent Node.js LTS version in CI Build install workflow Mar 24, 2025
@MikeMcC399
Copy link
Contributor Author

Wrong case for commit message is fixed!

@MikeMcC399 MikeMcC399 marked this pull request as ready for review March 24, 2025 14:46
@MikeMcC399
Copy link
Contributor Author

MikeMcC399 commented Mar 24, 2025

Jobs in https://github.com/eslint/css/actions/runs/14038202522 are successful

image

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@nzakas nzakas merged commit 38c7bfe into eslint:main Mar 24, 2025
22 checks passed
@github-project-automation github-project-automation bot moved this from Needs Triage to Complete in Triage Mar 24, 2025
@MikeMcC399 MikeMcC399 deleted the ci/node-lts-build-install branch March 24, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

Change Request: Use consistent Node.js LTS version in CI Build install workflow

2 participants