Permalink
Browse files

Docs: suggest deleting branches after merging PRs (#9449)

This updates the maintainer guide to recommend deleting the git branch
after merging a PR. (It seems like we usually already do this, but I
    think we should document it to make the recommendation more official.)
  • Loading branch information...
not-an-aardvark committed Oct 16, 2017
1 parent b31e55a commit 052c50491a1aca1e6bbd22920a4582089d7f3691
Showing with 2 additions and 0 deletions.
  1. +2 −0 docs/maintainer-guide/pullrequests.md
@@ -69,6 +69,8 @@ Otherwise, team members should observe a waiting period before merging a pull re
The waiting period ensures that other team members have a chance to review the pull request before it is merged.
If the pull request was created from a branch on the `eslint/eslint` repository (as opposed to a fork), delete the branch after merging the pull request. (GitHub will display a "Delete branch" button after the pull request is merged.)
**Note:** You should not merge your own pull request unless you're received feedback from at least one other team member.
## When to Close a Pull Request

0 comments on commit 052c504

Please sign in to comment.