diff --git a/conf/eslint-recommended.js b/conf/eslint-recommended.js index 447a99638a4..d6368000fc9 100644 --- a/conf/eslint-recommended.js +++ b/conf/eslint-recommended.js @@ -9,7 +9,10 @@ const builtInRules = require("../lib/built-in-rules-index"); module.exports = { - rules: Object.assign({}, ...Object.keys(builtInRules).map(ruleId => ({ - [ruleId]: builtInRules[ruleId].meta.docs.recommended ? "error" : "off" - }))) + rules: Object.assign( + {}, + ...Object.keys(builtInRules) + .filter(ruleId => builtInRules[ruleId].meta.docs.recommended) + .map(ruleId => ({ [ruleId]: "error" })) + ) }; diff --git a/tests/conf/eslint-recommended.js b/tests/conf/eslint-recommended.js new file mode 100644 index 00000000000..89d9f4447fd --- /dev/null +++ b/tests/conf/eslint-recommended.js @@ -0,0 +1,24 @@ +/** + * @fileoverview Tests for eslint:recommended. + * @author Kevin Partington + */ + +"use strict"; + +//------------------------------------------------------------------------------ +// Requirements +//------------------------------------------------------------------------------ + +const assert = require("chai").assert; +const eslintRecommended = require("../../conf/eslint-recommended"); +const rules = eslintRecommended.rules; + +describe("eslint-recommended", () => { + it("should configure recommended rules as error", () => { + assert.strictEqual(rules["no-undef"], "error"); + }); + + it("should not configure non-recommended rules", () => { + assert.notProperty(rules, "camelcase"); + }); +}); diff --git a/tests/lib/cli-engine.js b/tests/lib/cli-engine.js index 2a445bd9df0..ff5e041d367 100644 --- a/tests/lib/cli-engine.js +++ b/tests/lib/cli-engine.js @@ -1532,7 +1532,7 @@ describe("CLIEngine", () => { const report = engine.executeOnFiles(["lib/cli*.js"]); - assert.deepStrictEqual( + assert.sameDeepMembers( report.usedDeprecatedRules, [ { ruleId: "indent-legacy", replacedBy: ["indent"] },