From e12d3bca44fed8f4103cbdcaaff6c289be2a6d65 Mon Sep 17 00:00:00 2001 From: Joel Mathew Koshy Date: Thu, 16 Nov 2023 19:56:11 -0500 Subject: [PATCH] ++ or -- in the token before is not always safe. --- lib/rules/no-console.js | 4 +--- tests/lib/rules/no-console.js | 9 +++++++++ 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/lib/rules/no-console.js b/lib/rules/no-console.js index 24f2fa1ae09..d20477c5d9a 100644 --- a/lib/rules/no-console.js +++ b/lib/rules/no-console.js @@ -125,9 +125,7 @@ module.exports = { tokenAfter.value !== "++" && tokenAfter.value !== "--" && Boolean(tokenBefore) && - !SAFE_TOKENS_BEFORE.test(tokenBefore.value) && - tokenBefore.value !== "++" && - tokenBefore.value !== "--" + !SAFE_TOKENS_BEFORE.test(tokenBefore.value) ); } diff --git a/tests/lib/rules/no-console.js b/tests/lib/rules/no-console.js index 648173836d2..d55cf5c2d58 100644 --- a/tests/lib/rules/no-console.js +++ b/tests/lib/rules/no-console.js @@ -162,6 +162,15 @@ ruleTester.run("no-console", rule, { suggestions: null }] }, + { + code: "a++\nconsole.log();\n/b/", + parserOptions: { ecmaVersion: "latest" }, + errors: [{ + messageId: "unexpected", + type: "MemberExpression", + suggestions: null + }] + }, { code: "a();\nconsole.log(foo);\n[1, 2, 3].forEach(a => doSomething(a));", parserOptions: { ecmaVersion: "latest" },