Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Chore: Remove unused parameter in dot-location (#12464)
- Loading branch information
Showing
with
9 additions
and
10 deletions.
-
+9
−10
lib/rules/dot-location.js
|
|
@@ -47,19 +47,18 @@ module.exports = { |
|
|
|
|
|
/** |
|
|
* Reports if the dot between object and property is on the correct loccation. |
|
|
* @param {ASTNode} obj The object owning the property. |
|
|
* @param {ASTNode} prop The property of the object. |
|
|
* @param {ASTNode} node The corresponding node of the token. |
|
|
* @param {ASTNode} node The `MemberExpression` node. |
|
|
* @returns {void} |
|
|
*/ |
|
|
function checkDotLocation(obj, prop, node) { |
|
|
const dot = sourceCode.getTokenBefore(prop); |
|
|
function checkDotLocation(node) { |
|
|
const property = node.property; |
|
|
const dot = sourceCode.getTokenBefore(property); |
|
|
|
|
|
// `obj` expression can be parenthesized, but those paren tokens are not a part of the `obj` node. |
|
|
const tokenBeforeDot = sourceCode.getTokenBefore(dot); |
|
|
|
|
|
const textBeforeDot = sourceCode.getText().slice(tokenBeforeDot.range[1], dot.range[0]); |
|
|
const textAfterDot = sourceCode.getText().slice(dot.range[1], prop.range[0]); |
|
|
const textAfterDot = sourceCode.getText().slice(dot.range[1], property.range[0]); |
|
|
|
|
|
if (onObject) { |
|
|
if (!astUtils.isTokenOnSameLine(tokenBeforeDot, dot)) { |
|
|
@@ -69,15 +68,15 @@ module.exports = { |
|
|
node, |
|
|
loc: dot.loc, |
|
|
messageId: "expectedDotAfterObject", |
|
|
fix: fixer => fixer.replaceTextRange([tokenBeforeDot.range[1], prop.range[0]], `${neededTextAfterToken}.${textBeforeDot}${textAfterDot}`) |
|
|
fix: fixer => fixer.replaceTextRange([tokenBeforeDot.range[1], property.range[0]], `${neededTextAfterToken}.${textBeforeDot}${textAfterDot}`) |
|
|
}); |
|
|
} |
|
|
} else if (!astUtils.isTokenOnSameLine(dot, prop)) { |
|
|
} else if (!astUtils.isTokenOnSameLine(dot, property)) { |
|
|
context.report({ |
|
|
node, |
|
|
loc: dot.loc, |
|
|
messageId: "expectedDotBeforeProperty", |
|
|
fix: fixer => fixer.replaceTextRange([tokenBeforeDot.range[1], prop.range[0]], `${textBeforeDot}${textAfterDot}.`) |
|
|
fix: fixer => fixer.replaceTextRange([tokenBeforeDot.range[1], property.range[0]], `${textBeforeDot}${textAfterDot}.`) |
|
|
}); |
|
|
} |
|
|
} |
|
|
@@ -89,7 +88,7 @@ module.exports = { |
|
|
*/ |
|
|
function checkNode(node) { |
|
|
if (!node.computed) { |
|
|
checkDotLocation(node.object, node.property, node); |
|
|
checkDotLocation(node); |
|
|
} |
|
|
} |
|
|
|
|
|
|