Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also .

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also .
base repository: eslint/eslint
Choose a Base Repository
eslint/eslint
2ndOfJuly/eslint
Acidburn0zzz/eslint
Ainerce/eslint
Bartvds/eslint
BlookHo/eslint
BridgeAR/eslint
Bumkeyy/eslint
CNXTEoEorg/eslint
CTmr07/eslint
ConnectionMaster/eslint
Constellation/eslint
Delapouite/eslint
EricSeokgon/eslint
Erik-Roth/eslint
Ginholuca/eslint
GrayedFox/eslint
IjzerenHein/eslint-browser
InfinityCollaborations/eslint
JJoGeon/eslint
JedWatson/eslint
LeoChowChina/eslint
NateEag/eslint
NicsxSec/eslint
PiIsFour/eslint
RReverser/eslint
RobLoach/eslint
StyMaar/eslint
TGOlson/eslint
ThanhTuan1695/eslint
TheCodeWorm/eslint
Trott/eslint
Vladimir-Okulovich/eslint
WilliamMajanja/eslint
ZIJ/eslint
Zarel/eslint
Zenwolf/eslint
Zzzen/eslint
a0viedo/eslint
alihalabyah/eslint
altruism/eslint
andersekdahl/eslint
andrewdeandrade/eslint
andreypopp/eslint
angelozerr/eslint
april/eslint
arturdent/eslint
arv/eslint
azu/eslint
balykinaao/eslint
bbondy/eslint
bdougherty/eslint
bernatp3rs/eslint
bolinfest/eslint
brandonpayton/eslint
brandynbennett/eslint
brianloveswords/eslint
btmills/eslint
c089/eslint
captainbrosset/eslint
captbaritone/eslint
caseman72/eslint
chrisdickinson/eslint
chriswong/eslint
codeschool/eslint
conradz/eslint
dannygriffin000/eslint
davidjnelson/eslint
doug-wade/eslint
dschenkelman/eslint
dulare84/eslint
dwelle/eslint
dzinxed/eslint
ealize/eslint
electron-userland/electron-eslint
emilbayes/eslint
enter-diannesans/eslint
es128/eslint
evangoer/eslint
fearphage/eslint
forivall/eslint
gaearon/eslint
gavrilyak/eslint
glenjamin/eslint
goatslacker/eslint
goodluck2016/eslint
hayes/eslint
hgwood/eslint
huarhere/eslint
hzoo/eslint
ianwremmel/eslint
iconWave/eslint
ifraixedes/eslint
igoryan-909/eslint
ilovejary/eslint
imakewebthings/eslint
iyangming/eslint
iyyappanGitHub/eslint
jamesallardice/eslint
jamiepg1/eslint
jbenito/eslint
jedmao/eslint
jgable/eslint
jkol/eslint
johanbrook/eslint
jonkessler/eslint
joshuacc/eslint
jrajav/eslint
jrencz/eslint
kaisermann/eslint
kanongil/eslint
karthikkp/eslint
karuppasamy/eslint
kbweaver/eslint
keithpitt/eslint
kimwooglae/eslint
lehni/eslint-nullish-coalescing
letsgetrandy/eslint
lionknox/eslint
ljharb/eslint
lo1tuma/eslint
lucalanca/eslint
lukeenterprise/eslint
luoguangyao1987/eslint
makepanic/eslint
marcoslimacom/eslint
marek-saji/eslint
mcanthony/eslint
mendenhallmagic/eslint
mgol/eslint
michaelficarra/eslint
mike-north/eslint
mindofmicah/eslint
modernserf/eslint
monraza/eslint
mrowa44/eslint-kurwa
mrseadev/eslint
mstuart/eslint
mysticatea/eslint
nertus/eslint
nimba9/eslint
noahcollins/eslint
npup/eslint
nvdnkpr/eslint
okonet/eslint
okuryu/eslint
oliveiraf/eslint
orald/eslint
paulirish/eslint
payne/eslint
pdehaan/eslint
pedrosland/eslint
pkyeck/eslint
pselden/eslint
qmx/eslint
ram0812-zz/eslint
rauchg/eslint-es6
remitbri/eslint
rlidwka/eslint
ruffle1986/eslint
ruudkarthick/eslint
rynodivino/eslint
salomvary/eslint
samcday/eslint
sasmbo/eslint
satya164/eslint-browser
shrey7070/eslint
smikes/eslint
spadgos/eslint
spmurrayzzz/eslint
stevemao/eslint
sthagen/eslint
telaviv/eslint
teppeis/eslint
tlvince/eslint
tomgco/eslint
tonytamsf/eslint
tschaub/eslint
tswaters/eslint
uhoreg/eslint
victor-homyakov/eslint
vinone/eslint
viswanathm/eslint
vv314/eslint
wavded/eslint
wavebeem/eslint
wicked7578/eslint
wilmoore/eslint
xjamundx/eslint
yannickcr/eslint
yjose/eslint
yoshuawuyts/eslint
yvg/eslint
yxiong-twitter/eslint
yyx990803/eslint
zafar-saleem/eslint
zba/eslint
zeusdeux/eslint
zhaoxingyue/eslint
zmthy/eslint
Nothing to show
base: v3.19.0
head repository: eslint/eslint
Choose a Head Repository
eslint/eslint
2ndOfJuly/eslint
Acidburn0zzz/eslint
Ainerce/eslint
Bartvds/eslint
BlookHo/eslint
BridgeAR/eslint
Bumkeyy/eslint
CNXTEoEorg/eslint
CTmr07/eslint
ConnectionMaster/eslint
Constellation/eslint
Delapouite/eslint
EricSeokgon/eslint
Erik-Roth/eslint
Ginholuca/eslint
GrayedFox/eslint
IjzerenHein/eslint-browser
InfinityCollaborations/eslint
JJoGeon/eslint
JedWatson/eslint
LeoChowChina/eslint
NateEag/eslint
NicsxSec/eslint
PiIsFour/eslint
RReverser/eslint
RobLoach/eslint
StyMaar/eslint
TGOlson/eslint
ThanhTuan1695/eslint
TheCodeWorm/eslint
Trott/eslint
Vladimir-Okulovich/eslint
WilliamMajanja/eslint
ZIJ/eslint
Zarel/eslint
Zenwolf/eslint
Zzzen/eslint
a0viedo/eslint
alihalabyah/eslint
altruism/eslint
andersekdahl/eslint
andrewdeandrade/eslint
andreypopp/eslint
angelozerr/eslint
april/eslint
arturdent/eslint
arv/eslint
azu/eslint
balykinaao/eslint
bbondy/eslint
bdougherty/eslint
bernatp3rs/eslint
bolinfest/eslint
brandonpayton/eslint
brandynbennett/eslint
brianloveswords/eslint
btmills/eslint
c089/eslint
captainbrosset/eslint
captbaritone/eslint
caseman72/eslint
chrisdickinson/eslint
chriswong/eslint
codeschool/eslint
conradz/eslint
dannygriffin000/eslint
davidjnelson/eslint
doug-wade/eslint
dschenkelman/eslint
dulare84/eslint
dwelle/eslint
dzinxed/eslint
ealize/eslint
electron-userland/electron-eslint
emilbayes/eslint
enter-diannesans/eslint
es128/eslint
evangoer/eslint
fearphage/eslint
forivall/eslint
gaearon/eslint
gavrilyak/eslint
glenjamin/eslint
goatslacker/eslint
goodluck2016/eslint
hayes/eslint
hgwood/eslint
huarhere/eslint
hzoo/eslint
ianwremmel/eslint
iconWave/eslint
ifraixedes/eslint
igoryan-909/eslint
ilovejary/eslint
imakewebthings/eslint
iyangming/eslint
iyyappanGitHub/eslint
jamesallardice/eslint
jamiepg1/eslint
jbenito/eslint
jedmao/eslint
jgable/eslint
jkol/eslint
johanbrook/eslint
jonkessler/eslint
joshuacc/eslint
jrajav/eslint
jrencz/eslint
kaisermann/eslint
kanongil/eslint
karthikkp/eslint
karuppasamy/eslint
kbweaver/eslint
keithpitt/eslint
kimwooglae/eslint
lehni/eslint-nullish-coalescing
letsgetrandy/eslint
lionknox/eslint
ljharb/eslint
lo1tuma/eslint
lucalanca/eslint
lukeenterprise/eslint
luoguangyao1987/eslint
makepanic/eslint
marcoslimacom/eslint
marek-saji/eslint
mcanthony/eslint
mendenhallmagic/eslint
mgol/eslint
michaelficarra/eslint
mike-north/eslint
mindofmicah/eslint
modernserf/eslint
monraza/eslint
mrowa44/eslint-kurwa
mrseadev/eslint
mstuart/eslint
mysticatea/eslint
nertus/eslint
nimba9/eslint
noahcollins/eslint
npup/eslint
nvdnkpr/eslint
okonet/eslint
okuryu/eslint
oliveiraf/eslint
orald/eslint
paulirish/eslint
payne/eslint
pdehaan/eslint
pedrosland/eslint
pkyeck/eslint
pselden/eslint
qmx/eslint
ram0812-zz/eslint
rauchg/eslint-es6
remitbri/eslint
rlidwka/eslint
ruffle1986/eslint
ruudkarthick/eslint
rynodivino/eslint
salomvary/eslint
samcday/eslint
sasmbo/eslint
satya164/eslint-browser
shrey7070/eslint
smikes/eslint
spadgos/eslint
spmurrayzzz/eslint
stevemao/eslint
sthagen/eslint
telaviv/eslint
teppeis/eslint
tlvince/eslint
tomgco/eslint
tonytamsf/eslint
tschaub/eslint
tswaters/eslint
uhoreg/eslint
victor-homyakov/eslint
vinone/eslint
viswanathm/eslint
vv314/eslint
wavded/eslint
wavebeem/eslint
wicked7578/eslint
wilmoore/eslint
xjamundx/eslint
yannickcr/eslint
yjose/eslint
yoshuawuyts/eslint
yvg/eslint
yxiong-twitter/eslint
yyx990803/eslint
zafar-saleem/eslint
zba/eslint
zeusdeux/eslint
zhaoxingyue/eslint
zmthy/eslint
Nothing to show
compare: v6.6.0
This comparison is big! We’re only showing the most recent 250 commits
Commits on Jun 05, 2019
Commits on Jun 07, 2019
ESLint Jenkins
Commits on Jun 08, 2019
* removed '>' prefix from from docs/working-with-rules

* retained the line space
* Chore: removes unnecessary assignment in loop

also reduces cyclomatic complexity with a slight reconfiguring of some conditions

* uses ternary based on review notes
* Update: support "bigint" in valid-typeof rule

BigInt just moved to Stage 4, so add support for it to
the valid-typeof rule.

* Docs: add Further Reading to valid-typeof rule

This commit adds a Further Reading section to the
valid-typeof rule documentation.
…) (#11805)

Examples: 08, 018, 08.1
…1625)

* Fix #11624 by adding minKeys option to sort-keys

* Update documentation for sort-keys with minKeys option
Commits on Jun 10, 2019
ESLint Jenkins
Commits on Jun 11, 2019
ESLint Jenkins
Commits on Jun 17, 2019
Commits on Jun 18, 2019
🚨 As of Babel 7.4.0, this package has been deprecated in favor of directly including core-js/stable (to polyfill ECMAScript features) and regenerator-runtime/runtime (needed to use transpiled generator functions):
Commits on Jun 19, 2019
Commits on Jun 20, 2019
This ESLint rule handles both leading and trailing decimal points.
In order to ease discovery of this ESLint rule, mention the latter
warning as well, as users might only find those in their code.

https://github.com/jshint/jshint/blob/7993101/src/style.js#L100-L116
Commits on Jun 21, 2019
Commits on Jun 22, 2019
ESLint Jenkins
Commits on Jun 23, 2019
Commits on Jun 24, 2019
* Docs: Update examples with the new default option (refs #11503)

- Remove redundant sentence from the summary as the default for allowParens is now true.
- Update examples according to the new default.

* Docs: Fix examples

- Moved an example from correct to incorrect.
- Added a new correct example.
Commits on Jun 25, 2019
ESLint Jenkins
Commits on Jun 26, 2019
* Docs: add 'stricter rule config validating' in migrating docs

* Docs: fix typo
Commits on Jun 27, 2019
* Upgrade: some deps to latest

* Chore: fix linting errors
Commits on Jul 03, 2019
* Chore: add v8-compile-cache to speed up instantiation time

v8-compile-cache attaches a require hook to use V8's code cache to speed up instantiation time.
The "code cache" is the work of parsing and compiling done by V8.
…) (#11938)

* Docs: Fix incorrect example comments for unicode-bom rule (fixes #11937)

* Docs: Add explicit default option in "never" examples (fixes #11937)
Commits on Jul 04, 2019
Commits on Jul 06, 2019
… (#11935)

* Fix: creating of enabledGlobals object without prototype

* Chore: Add test (#11935)
Commits on Jul 11, 2019
Commits on Jul 12, 2019
Commits on Jul 14, 2019
Commits on Jul 16, 2019
Issue in lodash filed at lodash/lodash#4348
* Fix: --init with Vue.js failed (fixes #11970)

* move 'naming.js' to 'shared' directory

* use naming utility
Commits on Jul 18, 2019
ESLint Jenkins
Commits on Jul 19, 2019
Commits on Jul 21, 2019
ESLint Jenkins
Commits on Jul 31, 2019
`eslint.linter` exists for backwards compatibility, but we do not recommend using it because any mutations to it are shared among every module that uses `eslint`. Instead, please create your own instance of `eslint.Linter`.
Commits on Aug 01, 2019
ESLint Jenkins
Commits on Aug 02, 2019
The global variable that the user doesn't want to use is event not error
I think the confusion came from the rule setting being named error
Commits on Aug 03, 2019
* Update: Check computed method keys in no-extra-parens

* Remove member null check
Commits on Aug 05, 2019
ESLint Jenkins
ESLint Jenkins
Commits on Aug 06, 2019
…) (#12053)

* Docs: Remove readonly/writable global logic from no-undef (fixes #11963)

* Add references to other rules
Commits on Aug 12, 2019
Commits on Aug 13, 2019
#12001)

* ternary operators added to tule

* ternary operators added

* cases added for ternary operator mixed with logical

* documentation updated

* hard coded string message removed and in place added the operator..

* test cases fixed

* added the option to check for ternary operator and extra tests

* documentation and tests updated

* check for test or left node moved to a sperate function

* wrong comment. Has been updated
…#12076)

* Fix: no-extra-boolean-cast invalid autofix for Boolean() without args

* Add test cases

* Prevent removal of comments
Commits on Aug 18, 2019
* Fix: fix on TemplateLiteral

* Fix: fix on AssignmentPattern

* Fix: fix SequenceExpression at TemplateLiteral
…12062)

* Update: Fix accessor-pairs to enforce pairs per property in literals

* Use getFunctionNameWithKind and getFunctionHeadLoc, fix tests

* Add Known Limitations section in documentation
* New: noInlineConfig setting (refs eslint/rfcs#22)

* fix typo

Co-Authored-By: Kevin Partington <platinum.azure@kernelpanicstudios.com>

* fix typo in tests

* add tests for line comments

* add config name
* upgrade deps

* make CodePathAnalyzer handling ImportExpression as throwable

* fix new-cap rule

* fix astUtils.getPrecedence

* fix astUtils.isNullLiteral

* add env.es2020

* fix func-call-spacing rule

* fix function-paren-newline rule

* fix indent rule

* fix no-extra-parens rule

* Upgrade: espree@^6.1.0, eslint-visitor-keys@^1.1.0

* Chore: Ignore tools/internal-rules/node_modules

* Upgrade: acorn@^7.0.0

This avoids a dependency deduplication conflict for developers
ESLint Jenkins
Commits on Aug 19, 2019
* update docs for ecmaVersion 2020

* fix first list
Commits on Aug 20, 2019
ESLint Jenkins
ESLint Jenkins
Commits on Aug 23, 2019
ESLint Jenkins
ESLint Jenkins
Commits on Aug 24, 2019
ESLint Jenkins
Commits on Aug 28, 2019
Commits on Aug 29, 2019
Commits on Aug 30, 2019
* Chore: use GitHub Actions

* fix syntax error

* fix syntax error

* fix fuzz test

* change triggers

* remove badge

* add badge

* re-add Azure Pipelines files and badge
* New: support TypeScript at config initializer (fixes #11789)

* fix lint

* tiny fixes
* Chore: refactor code

* Fix: minor tweak

* Minor tweak

* Fix: lint

* Fix: minor tweak

have deps as a Set rather than an array

* Fix: tweak

* fix: typo
ESLint Jenkins
Commits on Sep 01, 2019
ESLint Jenkins
Commits on Sep 04, 2019
ESLint Jenkins
Commits on Sep 06, 2019
This also updates the rule description to be clearer, and refactors the 
code to use messageIds instead of constants. Removes some superfluous 
code.
Commits on Sep 07, 2019
* New: add rule default-param-last (fixes #11361)

* Chore: fix typos

* Chore: add test cases

* Apply suggestion: add column for a test case

* Update: change error message

* Docs: add example in opening section

* Add test cases about parameter destructuring
Commits on Sep 08, 2019
ESLint Jenkins
Commits on Sep 12, 2019
ESLint Jenkins
ESLint Jenkins
Commits on Sep 14, 2019
* New: Add prefer-regex-literals rule (fixes #12238)

* Update docs/rules/prefer-regex-literals.md

Co-Authored-By: Kevin Partington <platinum.azure@kernelpanicstudios.com>

* Update docs/rules/prefer-regex-literals.md

Co-Authored-By: Kevin Partington <platinum.azure@kernelpanicstudios.com>

* Pass ecmaVersion to RuleTester constructor

* Check global String reference
* New: add no-import-assign (fixes #12237)

* add destructuring and for-in/of syntax

* add mutation functions

* add a more test

* allow seal and preventExtensions

* add a test
* Fix: object-shorthand providing invalid fixes for typescript

* Chore: refactor to not rely on async modifier check

* Chore: ensure return type isn't wiped for no arguments

* Chore: add ts code test to prevent regressions
* Fix: no-sequences is reporting incorrect locations

* Report full location
* Docs: Added naming convention details user guide

Added clarification about the answer regarding #12190.

* Docs: reverted markdown list style to the original
* Docs: Improve examples and clarify default option

The "default" option is now set to `overrides` instead of `after` because examples in after may be misleading.
A new incorrect example is added to `overrides` to clarify whether the overridden style can still be used.

* Docs: Reformat operator-linebreak
ESLint Jenkins
note: this is a breaking change in eslint-config-eslint.

refs:0313441
Commits on Sep 17, 2019
ESLint Jenkins
Commits on Sep 19, 2019
ESLint Jenkins
Commits on Sep 20, 2019
* Docs: fix links in array-callback-return

* Remove extra space
Commits on Sep 23, 2019
ESLint Jenkins
Commits on Sep 25, 2019
ESLint Jenkins
Commits on Sep 28, 2019
Commits on Sep 29, 2019
* Chore: enable eslint-plugin-jsdoc (refs #11146)

* Chore: enable jsdoc/check-types

* Chore: enable jsdoc/check-param-names

* Chore: enable jsdoc/check-alignment

* Chore: enable jsdoc/check-tag-names

* Chore: enable jsdoc/check-syntax

* Chore: enable jsdoc/implements-on-classes

* Chore: enable jsdoc/require-param-descriptions

* Chore: enable jsdoc/require-param-name

* Chore: enable jsdoc/require-param-type

* Chore: enable jsdoc/require-param

* Chore: enable jsdoc/require-returns-description

* Chore: enable jsdoc/require-returns-type

* Chore: enable jsdoc/require-returns

* Fix: eslint-plugin-jsdoc uses Function by default

* Chore: fix test

* Fix: remove out of date comment
…12322)

* Update: no-useless-rename also reports default values (fixes #12301)

* Refactor
ESLint Jenkins
Commits on Sep 30, 2019
ESLint Jenkins
Commits on Oct 03, 2019
* Chore: enable jsdoc/newline-after-description

* Chore: enable jsdoc/require-hyphen-before-param-description
Commits on Oct 04, 2019
* Docs: Fix link to code conventions

* Docs: Fix formattting

* Docs: Fix formatting of example config

All other example configs in the docs spaced curly braces in object literals, so this commit updates this for consistency.

* Docs: Fixed grammar

* Docs: Revert link to code conventions

This reverts commit ab5dba7.

* Docs: Revert link to code conventions

* Docs: Revert link to code conventions

Sorry for all the commits.
Commits on Oct 08, 2019
Signed-off-by: Gabriel R. Sezefredo <g@briel.dev>
* Give variable name to matched text

This simply makes the code a bit easier to read by giving a name to `match[1]`.

* Refactor: Untangle logic for parsing directives

There are a few thing going on in this function which were getting
conflated:

1. Parsing a `directiveType` out of the comment.
2. Ignoring directives that are in line comments but only support block
   comments.
3. Warning on and ignoring line comments that span multiple lines.

Previously these three pieces of functionality were tightly coupled
which made the code harder to read. After this change each task is
handled independently of the other.

* Core: Consolidate handling disable directives

Rather than conditionally set a mutable value and check for it at the end of the switch statement, we can actually just handle it inline by using a fallthrough.
ESLint Jenkins
Commits on Oct 10, 2019
Commits on Oct 12, 2019
Commits on Oct 15, 2019
)

* Update: no-self-assign should detect member expression with this

* Remove redundant condition
Commits on Oct 16, 2019
* New: pass cwd from cli engine

* fix linting error
ESLint Jenkins
Commits on Oct 18, 2019
* Update: improve report location for no-space-in-parens

* Add test cases with multiple spaces
…12411)

* Update: remove default property in override scheme

* Chore: Add a "missing after in overrides" test case for keyword-spacing
Commits on Oct 21, 2019
…#12414)

* Update: add option to no-unsafe-negation (fixes #12163)

* Chore: undo autoformatting + rename function

* Update: code review changes
- typos
- clarity of docs
- extra test cases

* Fix: fix failing tests

* Update: code review changes - add backticks

* Chore: remove comma
Commits on Oct 22, 2019
ESLint Jenkins
* Docs: fix docs for no-unneeded-ternary (fixes #12098)

* Update: add test cases
- default assignment on right hand side
- default assignment not on right side
- assignment that is not default e.g. x ? 1 : x

* Update doc for clarity
Commits on Oct 23, 2019
…2475)

* Docs: Add note about Node.js requiring SSL support

Adds a small note that Node.js requires SSL to be built in. While this hasn't affected many users, it's good to document in case this comes up in the future. (And the Node.js project itself did run into this as a problem.)

* Docs: Update getting started guide with SSL note

* Chore: rm trailing space
Commits on Oct 24, 2019
ESLint Jenkins
* Fix: problematic installation issue (fixes #11018)

* update espree
Uses new `ignoredPropertyAssignmentsRegex` option.
We merged a PR that had been waiting for a while, and we had added a
lint rule since it had been opened that caused the build to fail once
merged to master.
Commits on Oct 25, 2019
)

* Update: Add enforceForIndexOf option to use-isnan (fixes #12207)

* Remove Array prototype from a sentence and fix newlines in docs
…) (#12280)

* Fix: false positives on newlines in object/array args (fixes #12123)

* Update: Additional tests for multi-line template string
ESLint Jenkins
Showing 1,188 changed files with 148,519 additions and 43,703 deletions.
@@ -0,0 +1,37 @@
parameters:
name: ""
displayName: ""
vmImage: ""
nodeVersion: ""

jobs:
- job: ${{parameters.name}}
displayName: ${{parameters.displayName}}
pool:
vmImage: ${{parameters.vmImage}}
steps:
- task: NodeTool@0
displayName: Install Node.js
inputs:
versionSpec: ${{parameters.nodeVersion}}

- script: npm install
displayName: Install Packages

- script: npm test
displayName: Test

- task: PublishTestResults@2
displayName: Process Test Results
condition: succeededOrFailed()
inputs:
testRunner: JUnit
testResultsFiles: $(System.DefaultWorkingDirectory)/test-results.xml

- task: PublishCodeCoverageResults@1
displayName: Process Coverage Results
condition: succeededOrFailed()
inputs:
codeCoverageTool: Cobertura
summaryFileLocation: $(System.DefaultWorkingDirectory)/coverage/cobertura-coverage.xml
reportDirectory: $(System.DefaultWorkingDirectory)/coverage
@@ -7,4 +7,7 @@
/tests/fixtures/**
/tests/performance/**
/tmp/**
/tools/internal-rules/node_modules/**
/lib/rules/utils/unicode/is-combining-character.js
test.js
!.eslintrc.js
@@ -0,0 +1,187 @@
"use strict";

const internalFiles = [
"**/cli-engine/**/*",
"**/init/**/*",
"**/linter/**/*",
"**/rule-tester/**/*",
"**/rules/**/*",
"**/source-code/**/*"
];

module.exports = {
root: true,
plugins: [
"eslint-plugin",
"internal-rules"
],
extends: [
"eslint",
"plugin:eslint-plugin/recommended"
],
rules: {
"eslint-plugin/consistent-output": "error",
"eslint-plugin/no-deprecated-context-methods": "error",
"eslint-plugin/prefer-output-null": "error",
"eslint-plugin/prefer-placeholders": "error",
"eslint-plugin/report-message-format": ["error", "[^a-z].*\\.$"],
"eslint-plugin/require-meta-type": "error",
"eslint-plugin/test-case-property-ordering": [
"error",

// https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/issues/79
[
"filename",
"code",
"output",
"options",
"parser",
"parserOptions",
"globals",
"env",
"errors"
]
],
"eslint-plugin/test-case-shorthand-strings": "error",
"internal-rules/multiline-comment-style": "error"
},
overrides: [
{
files: ["lib/rules/*", "tools/internal-rules/*"],
excludedFiles: ["index.js"],
rules: {
"internal-rules/no-invalid-meta": "error",
"internal-rules/consistent-docs-description": "error"

/*
* TODO: enable it when all the rules using meta.messages
* "internal-rules/consistent-meta-messages": "error"
*/
}
},
{
files: ["lib/rules/*"],
excludedFiles: ["index.js"],
rules: {
"internal-rules/consistent-docs-url": "error"
}
},
{
files: ["tests/**/*"],
env: { mocha: true },
rules: {
"no-restricted-syntax": ["error", {
selector: "CallExpression[callee.object.name='assert'][callee.property.name='doesNotThrow']",
message: "`assert.doesNotThrow()` should be replaced with a comment next to the code."
}]
}
},

// Restrict relative path imports
{
files: ["lib/*"],
rules: {
"no-restricted-modules": ["error", {
patterns: [
...internalFiles
]
}]
}
},
{
files: ["lib/cli-engine/**/*"],
rules: {
"no-restricted-modules": ["error", {
patterns: [
...internalFiles,
"**/init"
]
}]
}
},
{
files: ["lib/init/**/*"],
rules: {
"no-restricted-modules": ["error", {
patterns: [
...internalFiles,
"**/rule-tester"
]
}]
}
},
{
files: ["lib/linter/**/*"],
rules: {
"no-restricted-modules": ["error", {
patterns: [
...internalFiles,
"fs",
"**/cli-engine",
"**/init",
"**/rule-tester"
]
}]
}
},
{
files: ["lib/rules/**/*"],
rules: {
"no-restricted-modules": ["error", {
patterns: [
...internalFiles,
"fs",
"**/cli-engine",
"**/init",
"**/linter",
"**/rule-tester",
"**/source-code"
]
}]
}
},
{
files: ["lib/shared/**/*"],
rules: {
"no-restricted-modules": ["error", {
patterns: [
...internalFiles,
"**/cli-engine",
"**/init",
"**/linter",
"**/rule-tester",
"**/source-code"
]
}]
}
},
{
files: ["lib/source-code/**/*"],
rules: {
"no-restricted-modules": ["error", {
patterns: [
...internalFiles,
"fs",
"**/cli-engine",
"**/init",
"**/linter",
"**/rule-tester",
"**/rules"
]
}]
}
},
{
files: ["lib/rule-tester/**/*"],
rules: {
"no-restricted-modules": ["error", {
patterns: [
...internalFiles,
"**/cli-engine",
"**/init"
]
}]
}
}
]
};

This file was deleted.

@@ -1,4 +1,8 @@
# Convert text file line endings to lf
* text=auto

*.js text eol=lf
*.js text eol=lf

# The test fixtures are text files.
/tests/fixtures/**/* text eol=lf
/tests/fixtures/ignored-paths/crlf/.eslintignore text eol=crlf
@@ -0,0 +1 @@
open_collective: eslint
@@ -1,15 +1,22 @@
<!--
This template is for bug reports. If you are reporting a bug, please continue on. If you are here for another reason, please see below:
ESLint adheres to the [JS Foundation Code of Conduct](https://js.foundation/community/code-of-conduct).
1. To propose a new rule: http://eslint.org/docs/developer-guide/contributing/new-rules
2. To request a change: http://eslint.org/docs/developer-guide/contributing/changes
3. If you have any questions, please stop by our chatroom: https://gitter.im/eslint/eslint
This template is for bug reports. If you are here for another reason, please see below:
Note that leaving sections blank will make it difficult for us to troubleshoot and we may have to close the issue.
1. To propose a new rule: https://eslint.org/docs/developer-guide/contributing/new-rules
2. To request a rule change: https://eslint.org/docs/developer-guide/contributing/rule-changes
3. To request a change that is not a bug fix, rule change, or new rule: https://eslint.org/docs/developer-guide/contributing/changes
4. If you have any questions, please stop by our chatroom: https://gitter.im/eslint/eslint
Note that leaving sections blank will make it difficult for us to troubleshoot and we may have to close the issue.
-->

**Tell us about your environment**

<!--
If you are using ESLint v6.5.0 or later, you can run ESLint with the `--env-info` flag and paste the output here.
-->

* **ESLint Version:**
* **Node Version:**
* **npm Version:**
@@ -18,22 +25,25 @@ Note that leaving sections blank will make it difficult for us to troubleshoot a

**Please show your full configuration:**

<!-- Paste your configuration below: -->
```
<details>
<summary>Configuration</summary>

<!-- Paste your configuration below: -->
```js
```

**What did you do? Please include the actual source code causing the issue.**
</details>

**What did you do? Please include the actual source code causing the issue, as well as the command that you used to run ESLint.**

<!-- Paste the source code below: -->
```js
```

<!-- Paste the command you used to run ESLint: -->
```bash
```

@@ -0,0 +1,65 @@
---
name: "\U0001F41E Bug report"
about: Report an issue with ESLint or rules bundled with ESLint
title: ''
labels: bug, triage
assignees: ''

---

<!--
ESLint adheres to the [JS Foundation Code of Conduct](https://js.foundation/community/code-of-conduct).
This template is for bug reports. If you are here for another reason, please see below:
1. To propose a new rule: https://eslint.org/docs/developer-guide/contributing/new-rules
2. To request a rule change: https://eslint.org/docs/developer-guide/contributing/rule-changes
3. To request a change that is not a bug fix, rule change, or new rule: https://eslint.org/docs/developer-guide/contributing/changes
4. If you have any questions, please stop by our chatroom: https://gitter.im/eslint/eslint
Note that leaving sections blank will make it difficult for us to troubleshoot and we may have to close the issue.
-->

**Tell us about your environment**

<!--
If you are using ESLint v6.5.0 or later, you can run ESLint with the `--env-info` flag and paste the output here.
-->

* **ESLint Version:**
* **Node Version:**
* **npm Version:**

**What parser (default, Babel-ESLint, etc.) are you using?**

**Please show your full configuration:**

<details>
<summary>Configuration</summary>

<!-- Paste your configuration below: -->
```js
```

</details>

**What did you do? Please include the actual source code causing the issue, as well as the command that you used to run ESLint.**

<!-- Paste the source code below: -->
```js
```

<!-- Paste the command you used to run ESLint: -->
```bash
```

**What did you expect to happen?**


**What actually happened? Please include the actual, raw output from ESLint.**


**Are you willing to submit a pull request to fix this bug?**

No commit comments for this range