Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename result -> foo #11210

Merged
merged 1 commit into from Jan 25, 2019
Merged

Rename result -> foo #11210

merged 1 commit into from Jan 25, 2019

Conversation

OmgImAlexis
Copy link
Contributor

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

What changes did you make? (Give an overview)
Renamed result to foo as the const below both of those are also called result.

Is there anything you'd like reviewers to focus on?
N/A

@jsf-clabot
Copy link

jsf-clabot commented Dec 26, 2018

CLA assistant check
All committers have signed the CLA.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Dec 26, 2018
@not-an-aardvark not-an-aardvark added rule Relates to ESLint's core rules documentation Relates to ESLint's documentation accepted There is consensus among the team that this change meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Jan 4, 2019
@nzakas
Copy link
Member

nzakas commented Jan 16, 2019

@OmgImAlexis Thanks for the pull request. It looks like you haven't yet signed the contributor license agreement. This is a simple agreement that just says you give us permission to use your code. If you can take a moment to electronically sign it, we can get this PR merged:
https://cla.js.foundation/eslint/eslint?pullRequest=11210

Thanks!

@OmgImAlexis
Copy link
Contributor Author

@nzakas done. Sorry I had lost this in my notifications.

@nzakas
Copy link
Member

nzakas commented Jan 25, 2019

@OmgImAlexis no problem, thanks for following up, and thanks for the contribution!

@nzakas nzakas merged commit c464e27 into eslint:master Jan 25, 2019
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Jul 25, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants