Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-confusing-arrow enable allowParens: true by default #11503

Closed
aladdin-add opened this issue Mar 13, 2019 · 3 comments

Comments

Projects
4 participants
@aladdin-add
Copy link
Member

commented Mar 13, 2019

What rule do you want to change?
no-confusing-arrow
Does this change cause the rule to produce more or fewer warnings?
fewer
How will the change be implemented? (New option, new default behavior, etc.)?
enable allowParens: true by default
Please provide some example code that this change will affect:

var x = a => (1 ? 2 : 3);

What does the rule currently do for this code?
report an error.
What will the rule do after it's changed?
no error reported.
Are you willing to submit a pull request to implement this change?
yes.

@platinumazure

This comment has been minimized.

Copy link
Member

commented Mar 13, 2019

Although this will probably result in strictly fewer warnings, I'm adding "breaking" label as users would need to change their configurations to preserve the current behavior if that's what they desire.

I'm 👍 for the change (as semver-major).

@g-plane

This comment has been minimized.

Copy link
Member

commented Mar 13, 2019

Really valuable change.

@aladdin-add aladdin-add self-assigned this Mar 13, 2019

@not-an-aardvark not-an-aardvark added this to Needs discussion in v6.0.0 Mar 14, 2019

@ilyavolodin ilyavolodin moved this from Needs discussion to Accepted, ready to implement in v6.0.0 Mar 14, 2019

@aladdin-add aladdin-add added accepted and removed evaluating labels Mar 15, 2019

@not-an-aardvark

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

This proposal was accepted in yesterday's TSC meeting.

aladdin-add added a commit to aladdin-add/eslint that referenced this issue Mar 17, 2019

aladdin-add added a commit to aladdin-add/eslint that referenced this issue Mar 17, 2019

@not-an-aardvark not-an-aardvark moved this from Accepted, ready to implement to Implemented, pending review in v6.0.0 Mar 18, 2019

aladdin-add added a commit to aladdin-add/eslint that referenced this issue Apr 2, 2019

v6.0.0 automation moved this from Implemented, pending review to Done Apr 4, 2019

kaicataldo added a commit that referenced this issue Jun 24, 2019

Docs: Update no-confusing-arrow with the new default option (#11886)
* Docs: Update examples with the new default option (refs #11503)

- Remove redundant sentence from the summary as the default for allowParens is now true.
- Update examples according to the new default.

* Docs: Fix examples

- Moved an example from correct to incorrect.
- Added a new correct example.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.