Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RuleTester should report syntax error of fixed code #11615

Closed
mysticatea opened this issue Apr 13, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@mysticatea
Copy link
Member

commented Apr 13, 2019

The version of ESLint you are using.

  • master

The problem you want to solve.

I found RuleTester doesn't report any errors even if autofix makes a syntax error in #11579.

image

I expected above test results to be "A fatal parsing error occurred in autofix: Parsing error: ..." rather than "Output is incorrect".

Your take on the correct solution to problem.

RuleTester makes failing if autofix made a syntax error.

Are you willing to submit a pull request to implement this change?

Yes.

@mysticatea mysticatea added this to Memorandum in v7.0.0 Apr 13, 2019

@mysticatea mysticatea self-assigned this Apr 13, 2019

@kaicataldo

This comment has been minimized.

Copy link
Member

commented May 29, 2019

This feels like a bug - I wonder if we need to wait for a major release to fix this?

@mysticatea

This comment has been minimized.

Copy link
Member Author

commented Jun 3, 2019

I'm fine to fix it as a bug.

@mysticatea mysticatea removed this from Memorandum in v7.0.0 Jun 3, 2019

mysticatea added a commit that referenced this issue Jun 3, 2019

mysticatea added a commit that referenced this issue Jun 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.