Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endColumn to no-useless-escape #11629

Closed
YodaDaCoda opened this issue Apr 18, 2019 · 2 comments

Comments

Projects
None yet
3 participants
@YodaDaCoda
Copy link

commented Apr 18, 2019

What rule do you want to change? no-useless-escape

Does this change cause the rule to produce more or fewer warnings? no

How will the change be implemented? (New option, new default behavior, etc.)? New default behaviour: return an endColumn

Please provide some example code that this change will affect:

var regex = /[\.]/;

What does the rule currently do for this code? Currently, the rule correctly detects an issue with the code. However, since the rule doesn't return an endColumn, my IDE (Atom) highlights until the end of the line in this example (from my testing, I think it highlights until the end of the line, or until the next \), which makes for a rather confusing UX.

What will the rule do after it's changed? Return an endColumn

Are you willing to submit a pull request to implement this change? No

@platinumazure

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

Thanks @YodaDaCoda for creating a new issue!

Personally I'm on the fence about whether this should be a bug fix or an enhancement. In any event, I will champion this change.

@platinumazure platinumazure self-assigned this Apr 18, 2019

@kaicataldo kaicataldo added accepted and removed evaluating labels May 29, 2019

@kaicataldo

This comment has been minimized.

Copy link
Member

commented May 29, 2019

This is now accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.